Hi people,
I implemented a new feature: import from open clip art library. When you have some time (and if you have interest), take a look on this and give me some feedback.
Thanks
Am Donnerstag, den 16.08.2007, 21:43 -0300 schrieb Bruno Dilly:
Hi,
my first test was like this: - started Inkscape - opened File -> Import from OPAL First hint, please write openclipart.org or Open Clip Art Library and not OCAL. - then I entered a tag and nothing happened - then I started Incskape from the command line and got there this warning:
WARNING **: Could not find the Open Clip Art Library rss feed. Verify if the OCAL url is correct in Configuration
1. What is the right URL? 2. Why is it configurable?
- Then I looked into the preferences and found it in Misc
Why in Misc and not an one category? Perhaps add an category Import/Export and move the other import/export related preferences into that new category too. Here I would like to have a reset to default button behind the URL. (If the URL really need to be an user visible option) The other think that I don't like is that the password is saved in plain text in the preferences.xml. Perhaps you can find a better solution here.
Regards, Tobias
Hi Tobias,
thanks for the feedback.
Right, I changed it.
OK, to avoid it, now Inkscape displays an error dialog.
The URL of the library you want to use: openclipart.org
I let it configurable for two reasons:
1) if someone want to use another library based on ccHost (maybe he want to create one for his work group, or something like that) he could change the URL, and it should work fine.
2) if Open Clip Art Library changes its url, the Inkscape user won't need to download a new version of Inkscape (OK, I believe the probability of this happen is near 0)
But there are any problem letting it configurable? What the other guys think about it?
I let it in Misc because I don't think it could be included in another one...
Perhaps add an category Import/Export and move the other import/export related preferences into that new category too.
I could do that, but I really didn't find the other import/export related preferences. What are them?
When I was coding it, I thank the same thing. So I took a look in the Gaim and SVN approaches, and they save in plain text, too. I could give the option to input your username and password when you try to export the document, so it won't be stored. But you will have to do it everytime. What do you think about it?
Regards, Tobias
On Fri, Aug 17, 2007 at 09:48:28PM -0300, Bruno Dilly wrote:
It's good to have it configurable - imagine an art studio may wish to provide their own clipart repo, or a college may wish to provide a cached mirror of openclipart for student use to ease bandwidth.
Even if they do it, saving passwords in plain text is rarely a good idea. For now, keep the password in memory but only prompt once at first use per Inkscape session. This isn't perfect, since someone could for example get the password out of a crash dump or memory dump, but it will at least eliminate a lot of blatant security risks.
Kees, do you have recommendations here?
Bryce
Am Freitag, den 17.08.2007, 21:48 -0300 schrieb Bruno Dilly:
Nice, thanks.
WARNING **: Could not find the Open Clip Art Library rss feed. Verify ...
OK, to avoid it, now Inkscape displays an error dialog.
Much better.
My vote would be to have it in the config file but not in the UI. But if we let it in the dialog I'd like to have a button to set it to default (openclipart.org).
- Default Export resolution - Import bitmap as <image> + your 3
Perhaps you can add a button that lings to the registration page from OCAL(http://openclipart.org/media/register) or even better make a dialog to create a new account.
Everything is better then saving it plain text. I think Bryce proposal for keeping the password in memory but only prompt once at first use per Inkscape session sounds good. As you are using gnome-vfs (btw does it work witt Windows?) berhaps it's the best to use GNOME Keyring for the password. Perhaps with an configure option, so we will have no problems on MacOS or Windows.
Regards, Tobias
On Sat, 2007-08-18 at 13:31 +0200, Tobias Jakobs wrote:
Yes, should have in the dialog IMO and a quick way to set to default.
Yes, agree, this needs to be part of it...
Yes, this sounds like a good practice...
Bruno, my general comments are that on import, the tag search is funky. I think that it would be good to start the search upon change of focus of the search window (like tab), and also, there *has* to be a little search button to the right of the search terms, otherwise, ppl. don't know that hitting <return> actually does anything...
After I figured that out, dude, totally cool to see all my clipart on search of tag 'rejon'!!!!
It will be great to see how export works more once you finish that up in your gsoc sprint ;)
The ui for the import could be a bit more unified into the inkscape UI, and, I wonder if anyone on Inkscape-devel has suggestions to this effect, as well as ideas for better names on the menu verbs?
Sweet! Keep em coming, last day for gsoc is monday!!!
Jon
On 8/16/07, Bruno Dilly <bruno.dilly@...400...> wrote:
Just tried it. First, I had to enter openclipart.org in prefs - this of course must be the default (btw, don't call it URL if it's just the server name).
Then I opened the import dialog and searched for "pen". It returned some results. But selecting these results did not show a preview, and opening one of them added nothing to the document. What am I doing wrong?
On 8/18/07, Bruno Dilly <bruno.dilly@...400...> wrote:
bulia, to select the row: if you are using the keyboard you must press enter, and if you are using the mouse you must double click.
Hmm, I'm afraid this must not be documented - it must be fixed instead :) It's very unintuitive and plain wrong: single click must select, double click or Enter must open selected (closing the dialog).
Anyway, now that I double click, I can import something, but only PNG files. Any SVG file fails to show or open, writing in the console:
(inkscape:23667): glibmm-CRITICAL **: unhandled exception (type Glib::Error) in signal handler: domain: gdk-pixbuf-error-quark code : 3 what : Couldn't recognize the image file format for file '/tmp/johnny_automatic_pen.svg'
By the way, it would be nice to have a line added to the dialog that would show some information about the selected image: filename, format, file size, date, etc.
On 8/18/07, bulia byak <buliabyak@...400...> wrote:
OK, I will change it
I couldn't reproduce the bug. Everything is working fine here, I've imported a lot of SVG files, including johnny_automatic_pen.svg. Could you make a test for me? Try to import the file directly from /tmp/, with the Import feature. Is it working for you?
Do you have any other information that you think could help me to find what is happening?
Good idea, I will see it later
On 8/18/07, Bruno Dilly <bruno.dilly@...400...> wrote:
Yes it's working. In fact I have in /tmp all those OCAL files that I tried to import, and I can now successfully import them using the regular Import command.
Do you have any other information that you think could help me to find what is happening?
No idea :(
Just an idea: looks like the files from OCAL in temp have execute permissions set. Dunno if this can be the problem - I can still import them using the regular import command.
On 8/18/07, bulia byak <buliabyak@...400...> wrote:
As of rev 15861, this error is displayed only when I select a file in the list, and preview is not shown. But when I click Open, the file is imported successfully into the document.
I have tried to use this in windows using the following autobuild: Inkscape 0.46dev+devel, built Aug 19 2007 (Inkscape0708192326.7z)
And it does not seem to work,
When using import, I type in a tag, press search and nothing happens... (should there be any feedback at all? Like if it cant reach the server etc)
And when I try to export, it goes to the "select file to export to" dialog, I press save and nothing happens, no feedback, nothing. (except in the status bar at the bottom it says "Document Saved")
What am I doing wrong? Has anyone else had issues with this feature under windows? (im using Vista)
Cheers,
ryanlerch
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of Bruno Dilly Sent: Monday, 20 August 2007 2:21 PM To: bulia byak Cc: Inkscape Devel List Subject: Re: [Inkscape-devel] Import from OCAL feature
Hi,
I still trying to find the bug, but I can't reproduce it until now. There are more people with this problem? Suggestions?
Thanks
On 8/19/07, bulia byak <buliabyak@...400...> wrote:
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Hi,
Same thing here. Import from / export to OCAL shows no internet activity (logs of my firewall show nothing related to this function).
Also, in today's Inkscape0708210339 SVN build the import/export to/from OCAL is unavailable in the File menu (but it has a section in the Inkscape preferences dialog)
Is that deliberate (and the feature needs to be updated), or it is a regression?
Thanks!
Molumen
----- Original Message ----- From: "Ryan Lerch" <ryanlerch@...400...> To: "'Bruno Dilly'" <bruno.dilly@...400...>; "'bulia byak'" <buliabyak@...400...> Cc: "'Inkscape Devel List'" inkscape-devel@lists.sourceforge.net Sent: Tuesday, August 21, 2007 2:16 AM Subject: Re: [Inkscape-devel] Import from OCAL feature
Hi Ryan and Molumen,
the feature depends of gnome-vfs. So, before including gnome-vfs and using its functions, I'm using the #ifdef approach. But I've forgotten that I should show import/export to/from OCAL in the File menu only if gnome-vfs is available. I fixed it on Sunday. But I forgot to do the same with the preferences dialog =( .... I'll fix it
When using Linux, you have to install gnome-vfs and configure Inkscape again, but I'm afraid gnome-vfs can't work with Windows. I've searched about that in gnome-vfs documentation and I didn't find anything, but I'm almost sure about it. Could we find another library and use it when building in Windows? Is it possible?
On 8/21/07, momo <momo@...1386...> wrote:
On Tue, 2007-08-21 at 11:37 -0300, Bruno Dilly wrote:
Gnome-vfs is to be replaced by gvfs which has cross-platform design goals...unfortunately, it is at an early stage, but is supposed to have some type of compatibility as a drop-in gnome-vfs replacement...
Has there been any cross-platformization on gnome-vfs on windows? I thoughts so...C'mon guys, switch to linux! :) No, really, we need to get this feature to work on windows...
Jon
On Tue, Aug 21, 2007 at 11:37:40AM -0300, Bruno Dilly wrote:
Good attention to detail there - yes, it should disappear if gnome-vfs is not available. Make sure to mention this in Inkscape's README, and maybe one or two other prominant locations like the wiki, so users will be able to find out why it's not present. Make sure the ReleaseNotes have a complete entry as well.
That's not a bad thought, but it would also be worthwhile to inquire with the gnome folks on any chance of getting gnome-vfs ported to Windows.
Bryce
according to this: http://www.gnome.org/start/2.12/notes/en/rndevelopers.html
gnome-vfs should be buildable on win
On 8/21/07, Bryce Harrington <bryce@...961...> wrote:
On Tue, 2007-08-21 at 14:08 -0400, Brandon Miles wrote:
How hard to package that up with win32 releases? ishmal, others?
Jon
On Thu, Aug 16, 2007 at 09:43:41PM -0300, Bruno Dilly wrote:
Hi Bruno,
Just wanted to say, great work on this feature! The import-from-ocal seems quite solid now, although I did find a couple little glitches (like search for 'cat'), but I'm sure those will get worked out in time.
For the export dialog, I would like to see some additional context given to the user. For example, they may not know what OCAL is, and so when prompted for username and password, they might not realize they need an open clip art library account, and get frustrated when they enter the wrong account info. I think a couple sentences to explain what OCAL is, and point them at the openclipart.org website should suffice. There should probably also be a link to 'register new account'.
But aside from ui tweaks like this, I'm quite impressed with how far you've gotten with the work, and especially impressed at how smoothly the import from ocal works. Kudos! :-)
Bryce
Great!
I liked the ideas about the export dialog, I will implement it soon. The 'register new account' should be a link to the registration page from openclipart or should I make a dialog to create a new account, as Tobias has suggested? What do you think is the better choice?
About the problem of some searches, like "cat", there are something going wrong when trying to parse xml. I will see if its a problem with the xml tags, if there is a bug in lib2xml, or if I'm missing something before calling the parser.
I want to thank you, Bryce, by being my mentor, and to thank all the other guys that have helped me reporting bugs and suggesting new ideas or modifications. I'm impressed how inkscape developers community is active and helpful.
On 8/21/07, Bryce Harrington <bryce@...961...> wrote:
On 8/21/07, Bruno Dilly <bruno.dilly@...400...> wrote:
I think if we can do fine without an extra dialog. Everyone has a web browser these days.
As for my preview-not-working problem, are you using gdk-pixmap for it? Can you just switch it to using Inkscape's own renderer as the Open dialog preview does?
On Thu, Aug 16, 2007 at 09:43:41PM -0300, Bruno Dilly wrote:
Another general comment: Unfortunately the SVG's in OCAL can be quite varied, and not all will import into Inkscape cleanly. Since the errors will occur with your import-from-ocal, people may report these issues to you, however they aren't your bugs. People can submit SVGs to OCAL generated from a wide variety of programs, and since there are few enforced standards for the style/quality of SVG submitted, some are just not going to work.
I would suggest that you should simply strive to provide a clean and reliable way to _report_ these bugs, and make it clear in the error messages where the issues originate.
Bryce
participants (9)
-
Brandon Miles
-
Bruno Dilly
-
Bryce Harrington
-
bulia byak
-
john cliff
-
Jon Phillips
-
momo
-
Ryan Lerch
-
Tobias Jakobs