To the maintainer of our libcroco copy,
Please have a look at rev. 13178, where I fixed errors in pointer type signed-ness (Glib functions like g_strdup want a gchar*, not a guchar*).
I guess you'd want to upstream the small change.
cheers, Johan
2014-03-21 18:48 GMT+01:00 Johan Engelen <jbc.engelen@...2592...>:
To the maintainer of our libcroco copy,
Please have a look at rev. 13178, where I fixed errors in pointer type signed-ness (Glib functions like g_strdup want a gchar*, not a guchar*).
I guess you'd want to upstream the small change.
I don't think there is a "maintainer" on our side for any of the in-tree libraries.
Regards, Krzysztof
On 22-3-2014 13:27, Krzysztof Kosiński wrote:
2014-03-21 18:48 GMT+01:00 Johan Engelen <jbc.engelen@...2592...>:
To the maintainer of our libcroco copy,
Please have a look at rev. 13178, where I fixed errors in pointer type signed-ness (Glib functions like g_strdup want a gchar*, not a guchar*).
I guess you'd want to upstream the small change.
I don't think there is a "maintainer" on our side for any of the in-tree libraries.
We do. lib2geom and libuemf I am certain about. Alex Valavanis has been working on synchronizing libgdl, and also libcroco recently.
- Johan
Hi,
Not sure if I qualify as maintainer, but I guess my main concern is that we don't unnecessarily increase the delta against upstream. We may be better off just suppressing harmless warnings (unused args/variables etc) than fixing them in-tree. If we do fix things, we should try to follow GNOME style etc, and submit patches upstream where possible.
Really, the best "solution" is to work towards closing bug #648246 [1]. The next task is to strip out all the non-essential fixes from the Libcroco_0.6.8 -> Inkscape_trunk patch [2] and forward the remaining chunks. After that, we can build against an external lib and we won't have to worry about maintaining the fork any more :)
AV
[1] https://bugs.launchpad.net/inkscape/+bug/648246 [2] https://launchpadlibrarian.net/155708206/inkscape-changes-0.6.8.diff
On 22 March 2014 12:33, Johan Engelen <jbc.engelen@...2592...> wrote:
On 22-3-2014 13:27, Krzysztof Kosiński wrote:
2014-03-21 18:48 GMT+01:00 Johan Engelen <jbc.engelen@...2592...>:
To the maintainer of our libcroco copy,
Please have a look at rev. 13178, where I fixed errors in pointer type signed-ness (Glib functions like g_strdup want a gchar*, not a guchar*).
I guess you'd want to upstream the small change.
I don't think there is a "maintainer" on our side for any of the in-tree libraries.
We do. lib2geom and libuemf I am certain about. Alex Valavanis has been working on synchronizing libgdl, and also libcroco recently.
- Johan
Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Hi, I went through all the changes compared to upstream and extracted two patches that fix minor problems (see attachments). The other changes are mostly gchar*->guchar* and the like. Then there's the newly implemented cr-node-iface and the cr-libxml-... wrapper that are used in cr-sel-eng.c but that's it. Where should I send these two patches to? Should I append them to bug #648246? Or would you like to do that?
Regards, Markus
-----Ursprüngliche Nachricht----- Von: Alex Valavanis [mailto:valavanisalex@...400...] Gesendet: Montag, 24. März 2014 16:25 An: Johan Engelen Cc: Inkscape-Devel Betreff: Re: [Inkscape-devel] libcroco fix
Hi,
Not sure if I qualify as maintainer, but I guess my main concern is that we don't unnecessarily increase the delta against upstream. We may be better off just suppressing harmless warnings (unused args/variables etc) than fixing them in-tree. If we do fix things, we should try to follow GNOME style etc, and submit patches upstream where possible.
Really, the best "solution" is to work towards closing bug #648246 [1]. The next task is to strip out all the non-essential fixes from the Libcroco_0.6.8 -> Inkscape_trunk patch [2] and forward the remaining chunks. After that, we can build against an external lib and we won't have to worry about maintaining the fork any more :)
AV
[1] https://bugs.launchpad.net/inkscape/+bug/648246 [2] https://launchpadlibrarian.net/155708206/inkscape-changes-0.6.8.diff
On 22 March 2014 12:33, Johan Engelen <jbc.engelen@...2592...> wrote:
On 22-3-2014 13:27, Krzysztof Kosiński wrote:
2014-03-21 18:48 GMT+01:00 Johan Engelen <jbc.engelen@...2592...>:
To the maintainer of our libcroco copy,
Please have a look at rev. 13178, where I fixed errors in pointer type signed-ness (Glib functions like g_strdup want a gchar*, not a guchar*).
I guess you'd want to upstream the small change.
I don't think there is a "maintainer" on our side for any of the in-tree libraries.
We do. lib2geom and libuemf I am certain about. Alex Valavanis has been working on synchronizing libgdl, and also libcroco recently.
- Johan
-------- Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Hi Markus,
They need to be reported on the GNOME Bugzilla tracker for libcroco [1], but yes, please could you update bug #648246 too? There are already a couple of forwarded patches on the tracker which may need attention before they'll be accepted. e.g., this one [2]
Once they accept all our patches, and release a new version, we can build against the external lib and celebrate accordingly :)
AV
[1] https://bugzilla.gnome.org/browse.cgi?product=libcroco [2] https://bugzilla.gnome.org/show_bug.cgi?id=721806
On 24 March 2014 17:42, Markus Engel <p637777@...1081...> wrote:
Hi, I went through all the changes compared to upstream and extracted two patches that fix minor problems (see attachments). The other changes are mostly gchar*->guchar* and the like. Then there's the newly implemented cr-node-iface and the cr-libxml-... wrapper that are used in cr-sel-eng.c but that's it. Where should I send these two patches to? Should I append them to bug #648246? Or would you like to do that?
Regards, Markus
-----Ursprüngliche Nachricht----- Von: Alex Valavanis [mailto:valavanisalex@...400...] Gesendet: Montag, 24. März 2014 16:25 An: Johan Engelen Cc: Inkscape-Devel Betreff: Re: [Inkscape-devel] libcroco fix
Hi,
Not sure if I qualify as maintainer, but I guess my main concern is that we don't unnecessarily increase the delta against upstream. We may be better off just suppressing harmless warnings (unused args/variables etc) than fixing them in-tree. If we do fix things, we should try to follow GNOME style etc, and submit patches upstream where possible.
Really, the best "solution" is to work towards closing bug #648246 [1]. The next task is to strip out all the non-essential fixes from the Libcroco_0.6.8 -> Inkscape_trunk patch [2] and forward the remaining chunks. After that, we can build against an external lib and we won't have to worry about maintaining the fork any more :)
AV
[1] https://bugs.launchpad.net/inkscape/+bug/648246 [2] https://launchpadlibrarian.net/155708206/inkscape-changes-0.6.8.diff
On 22 March 2014 12:33, Johan Engelen <jbc.engelen@...2592...> wrote:
On 22-3-2014 13:27, Krzysztof Kosiński wrote:
2014-03-21 18:48 GMT+01:00 Johan Engelen <jbc.engelen@...2592...>:
To the maintainer of our libcroco copy,
Please have a look at rev. 13178, where I fixed errors in pointer type signed-ness (Glib functions like g_strdup want a gchar*, not a guchar*).
I guess you'd want to upstream the small change.
I don't think there is a "maintainer" on our side for any of the in-tree libraries.
We do. lib2geom and libuemf I am certain about. Alex Valavanis has been working on synchronizing libgdl, and also libcroco recently.
- Johan
-------- Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Thanks for your work guys. Reading the patch comment of [2], I feel sorry for you to have to cooperate with developers who'd rather delay a simple fix to their bugged library than replace one string for another.
... Johan
On 24-3-2014 19:11, Alex Valavanis wrote:
Hi Markus,
They need to be reported on the GNOME Bugzilla tracker for libcroco [1], but yes, please could you update bug #648246 too? There are already a couple of forwarded patches on the tracker which may need attention before they'll be accepted. e.g., this one [2]
Once they accept all our patches, and release a new version, we can build against the external lib and celebrate accordingly :)
AV
[1] https://bugzilla.gnome.org/browse.cgi?product=libcroco [2] https://bugzilla.gnome.org/show_bug.cgi?id=721806
On 24 March 2014 17:42, Markus Engel <p637777@...1081...> wrote:
Hi, I went through all the changes compared to upstream and extracted two patches that fix minor problems (see attachments). The other changes are mostly gchar*->guchar* and the like. Then there's the newly implemented cr-node-iface and the cr-libxml-... wrapper that are used in cr-sel-eng.c but that's it. Where should I send these two patches to? Should I append them to bug #648246? Or would you like to do that?
Regards, Markus
-----Ursprüngliche Nachricht----- Von: Alex Valavanis [mailto:valavanisalex@...400...] Gesendet: Montag, 24. März 2014 16:25 An: Johan Engelen Cc: Inkscape-Devel Betreff: Re: [Inkscape-devel] libcroco fix
Hi,
Not sure if I qualify as maintainer, but I guess my main concern is that we don't unnecessarily increase the delta against upstream. We may be better off just suppressing harmless warnings (unused args/variables etc) than fixing them in-tree. If we do fix things, we should try to follow GNOME style etc, and submit patches upstream where possible.
Really, the best "solution" is to work towards closing bug #648246 [1]. The next task is to strip out all the non-essential fixes from the Libcroco_0.6.8 -> Inkscape_trunk patch [2] and forward the remaining chunks. After that, we can build against an external lib and we won't have to worry about maintaining the fork any more :)
AV
[1] https://bugs.launchpad.net/inkscape/+bug/648246 [2] https://launchpadlibrarian.net/155708206/inkscape-changes-0.6.8.diff
On 22 March 2014 12:33, Johan Engelen <jbc.engelen@...2592...> wrote:
On 22-3-2014 13:27, Krzysztof Kosiński wrote:
2014-03-21 18:48 GMT+01:00 Johan Engelen <jbc.engelen@...2592...>:
To the maintainer of our libcroco copy,
Please have a look at rev. 13178, where I fixed errors in pointer type signed-ness (Glib functions like g_strdup want a gchar*, not a guchar*).
I guess you'd want to upstream the small change.
I don't think there is a "maintainer" on our side for any of the in-tree libraries.
We do. lib2geom and libuemf I am certain about. Alex Valavanis has been working on synchronizing libgdl, and also libcroco recently.
- Johan
-------- Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Mon, 2014-03-24 at 20:33 +0100, Johan Engelen wrote:
Thanks for your work guys. Reading the patch comment of [2], I feel sorry for you to have to cooperate with developers who'd rather delay a simple fix to their bugged library than replace one string for another.
Considering the size of the patch, it would have been quicker for everyone if they'd posted a counter patch.
It's one of those behaviors in projects which is counter productive to getting contributions. Nit picking on tiny little things like this.[1]
Martin,
[1] Not to be confused with the giant changes to fundamental functionality while using c-strings in c++ ;-)
participants (5)
-
Alex Valavanis -
Johan Engelen -
Krzysztof Kosiński -
Markus Engel -
Martin Owens