newer
[Fwd: Re: [Inkscape-devel] Added...

PATCH: Export dialog improvements

older
[elliott.bignell@...1255...: Re:...

Jonathon Jongsma

30 Apr 2006 30 Apr '06

3:36 a.m.

Hi all,

I've attached a patch to improve the look of the Export dialog window (mostly following the guidelines of the GNOME HIG and somewhat inspired by this article: http://www.gnomejournal.org/article/44/three-simple-tips-for-interface-desig...). While I was modifying the layout of the window, I couldn't help but move some of the widgets to gtkmm since I find it so much easier to write and to understand than GTK+. I know Inkscape uses some gtkmm, but I know you also use a lot of plain GTK+. I don't know if the goal / policy is to move more toward gtkmm, so I'm not sure whether you'll appreciate my gtkmm-ification or not :) Of course, this was by no means a complete gtkmm-ification, it's very incremental. In any case, if this sort of patch is welcomed, I may work on a couple other dialogs that could use a bit of improvement as well.

A couple of notes about the patch: Most of the GTK+ widgets that I replaced with gtkmm widgets were being allocated with gtk_*_new() but I didn't notice them being freed anywhere. So my code follows the same pattern. I'm not particularly familiar with the code-base of Inkscape, but from what I was able to tell, these kinds of dialogs are basically singletons that are managed by some sort of dialog factory. So while we aren't really keeping track of these widgets that are getting allocated, there's not much danger since they'll only be instantiated once and live for the life of the application (??). Am I understanding this more-or-less correctly? Or am I way off?

I should also add that this patch changes some translatable strings by adding some Pango markup to the 'section headers'. Is this the accepted way to do this or is there a better way (i.e. just marking the words between the markup as translatable)?

BTW, I'm not subscribed to Inkscape-devel, so please cc me on replies.

Jonner

Attachments:

inkscape-export-dialog.patch (text/x-patch — 17.4 KB)

Show replies by date

Bryce Harrington

30 Apr 30 Apr

5:07 a.m.

On Sat, Apr 29, 2006 at 10:36:46PM -0500, Jonathon Jongsma wrote:

...

Hi all,

I've attached a patch to improve the look of the Export dialog window (mostly following the guidelines of the GNOME HIG and somewhat inspired by this article: http://www.gnomejournal.org/article/44/three-simple-tips-for-interface-desig...).

Cool, would you mind uploading this to the patch tracker on the website? That is the official place for patches.

...

While I was modifying the layout of the window, I couldn't help but move some of the widgets to gtkmm since I find it so much easier to write and to understand than GTK+. I know Inkscape uses some gtkmm, but I know you also use a lot of plain GTK+. I don't know if the goal / policy is to move more toward gtkmm, so I'm not sure whether you'll appreciate my gtkmm-ification or not :) Of course, this was by no means a complete gtkmm-ification, it's very incremental. In any case, if this sort of patch is welcomed, I may work on a couple other dialogs that could use a bit of improvement as well.

Actually, this is *great*. The GTK+ dialogs are legacy; our intention has been to move all of them to gtkmm. Ultimately, I think we'd like to move entirely to gtkmm, so I would definitely encourage you to explore this interest. :-)

...

A couple of notes about the patch: Most of the GTK+ widgets that I replaced with gtkmm widgets were being allocated with gtk_*_new() but I didn't notice them being freed anywhere. So my code follows the same pattern. I'm not particularly familiar with the code-base of Inkscape, but from what I was able to tell, these kinds of dialogs are basically singletons that are managed by some sort of dialog factory. So while we aren't really keeping track of these widgets that are getting allocated, there's not much danger since they'll only be instantiated once and live for the life of the application (??). Am I understanding this more-or-less correctly? Or am I way off?

That's right. I had originally cleared the widgets in the destructors but it actually caused problems. I suspect things may be getting cleared at some other level, so I don't think the current code leaks memory or anything, but can't prove it.

...

I should also add that this patch changes some translatable strings by adding some Pango markup to the 'section headers'. Is this the accepted way to do this or is there a better way (i.e. just marking the words between the markup as translatable)?

You'll want to make sure to enclose the translatable strings with the _() macro in order to ensure they can get handled by the translators. Some of your new strings in your patch aren't set up for doing translations.

Bryce

...

Index: src/dialogs/export.cpp

--- src/dialogs/export.cpp (revision 11446) +++ src/dialogs/export.cpp (working copy) @@ -20,6 +20,15 @@ #endif

#include <gtk/gtk.h> +#include <gtkmm/box.h> +#include <gtkmm/buttonbox.h> +#include <gtkmm/label.h> +#include <gtkmm/widget.h> +#include <gtkmm/togglebutton.h> +#include <gtkmm/entry.h> +#include <gtkmm/image.h> +#include <gtkmm/stockid.h> +#include <gtkmm/stock.h>

#include <glibmm/i18n.h> #include "helper/unit-menu.h" @@ -240,40 +249,38 @@ } // end of sp_export_spinbutton_new()

-static GtkWidget * -sp_export_dialog_area_frame (GtkWidget * dlg) +static Gtk::VBox * +sp_export_dialog_area_box (GtkWidget * dlg) {

GtkWidget * f, * t, * hb, * b, * us, * l, * vb, * unitbox;

Gtk::VBox* vb = new Gtk::VBox(false, 6);

f = gtk_frame_new (_("Export area"));
vb = gtk_vbox_new (FALSE, 2);
gtk_container_add (GTK_CONTAINER (f), vb);

Gtk::Label* lbl = new Gtk::Label("<big><b>Export area</b></big>", Gtk::ALIGN_LEFT);
lbl->set_use_markup(true);
vb->pack_start(*lbl);

/* Units box */

unitbox = gtk_hbox_new (FALSE, 0);
gtk_container_set_border_width (GTK_CONTAINER (unitbox), 4);

Gtk::HBox* unitbox = new Gtk::HBox(false, 0); /* gets added to the vbox later, but the unit selector is needed earlier than that */

us = sp_unit_selector_new (SP_UNIT_ABSOLUTE | SP_UNIT_DEVICE);

Gtk::Widget* us = Glib::wrap(sp_unit_selector_new (SP_UNIT_ABSOLUTE | SP_UNIT_DEVICE)); SPDesktop *desktop = SP_ACTIVE_DESKTOP; if (desktop)

   sp_unit_selector_set_unit (SP_UNIT_SELECTOR(us), sp_desktop_namedview(desktop)->doc_units);

gtk_box_pack_end (GTK_BOX (unitbox), us, FALSE, FALSE, 0);
l = gtk_label_new (_("Units:"));
gtk_box_pack_end (GTK_BOX (unitbox), l, FALSE, FALSE, 3);
gtk_object_set_data (GTK_OBJECT (dlg), "units", us);

   sp_unit_selector_set_unit (SP_UNIT_SELECTOR(us->gobj()), sp_desktop_namedview(desktop)->doc_units);

unitbox->pack_end(*us, Gtk::PACK_EXPAND_WIDGET);
Gtk::Label* l = new Gtk::Label(_("Units:"));
unitbox->pack_end(*l, false, false, 3);
gtk_object_set_data (GTK_OBJECT (dlg), "units", us->gobj());

hb = gtk_hbox_new (TRUE, 0);
gtk_container_set_border_width (GTK_CONTAINER (hb), 4);
gtk_box_pack_start(GTK_BOX(vb), hb, FALSE, FALSE, 3);

Gtk::HBox* togglebox = new Gtk::HBox(true, 0);
Gtk::ToggleButton* b; for (int i = 0; i < SELECTION_NUMBER_OF; i++) {

   b = gtk_toggle_button_new_with_mnemonic (_(selection_labels[i]));

   gtk_object_set_data (GTK_OBJECT (b), "key", GINT_TO_POINTER(i));

   gtk_object_set_data (GTK_OBJECT (dlg), selection_names[i], b);

   gtk_box_pack_start (GTK_BOX (hb), b, FALSE, TRUE, 0);

   gtk_signal_connect ( GTK_OBJECT (b), "clicked",

   b = new Gtk::ToggleButton(_(selection_labels[i]), true);

   b->set_data("key", GINT_TO_POINTER(i));

   gtk_object_set_data (GTK_OBJECT (dlg), selection_names[i], b->gobj());

   togglebox->pack_start(*b, false, true, 0);

   gtk_signal_connect ( GTK_OBJECT (b->gobj()), "clicked", 
                        GTK_SIGNAL_FUNC (sp_export_area_toggled), dlg );

}

@@ -284,55 +291,55 @@ g_signal_connect ( G_OBJECT (INKSCAPE), "activate_desktop", G_CALLBACK (sp_export_selection_changed), dlg );

t = gtk_table_new (2, 6, FALSE);
gtk_box_pack_start(GTK_BOX(vb), t, FALSE, FALSE, 0);
gtk_table_set_row_spacings (GTK_TABLE (t), 4);
gtk_table_set_col_spacings (GTK_TABLE (t), 4);
gtk_container_set_border_width (GTK_CONTAINER (t), 4);

Gtk::Table* t = new Gtk::Table(2, 6, FALSE);
t->set_row_spacings (4);
t->set_col_spacings (4);

sp_export_spinbutton_new ( "x0", 0.0, -1000000.0, 1000000.0, 0.1, 1.0, us,

                          t, 0, 0, _("_x0:"), NULL, EXPORT_COORD_PRECISION, 1,

sp_export_spinbutton_new ( "x0", 0.0, -1000000.0, 1000000.0, 0.1, 1.0, us->gobj(),

                          GTK_WIDGET(t->gobj()), 0, 0, _("_x0:"), NULL, EXPORT_COORD_PRECISION, 1,
                          G_CALLBACK ( sp_export_area_x_value_changed), 
                          dlg );

sp_export_spinbutton_new ( "x1", 0.0, -1000000.0, 1000000.0, 0.1, 1.0, us,

                          t, 2, 0, _("x_1:"), NULL, EXPORT_COORD_PRECISION, 1,

sp_export_spinbutton_new ( "x1", 0.0, -1000000.0, 1000000.0, 0.1, 1.0, us->gobj(),

                          GTK_WIDGET(t->gobj()), 2, 0, _("x_1:"), NULL, EXPORT_COORD_PRECISION, 1,
                          G_CALLBACK (sp_export_area_x_value_changed), 
                          dlg );

sp_export_spinbutton_new ( "width", 0.0, -1000000.0, 1000000.0, 0.1, 1.0,

                          us, t, 4, 0, _("Width:"), NULL, EXPORT_COORD_PRECISION, 1,

                          us->gobj(), GTK_WIDGET(t->gobj()), 4, 0, _("Width:"), NULL, EXPORT_COORD_PRECISION, 1,
                          G_CALLBACK 
                              (sp_export_area_width_value_changed), 
                          dlg );

sp_export_spinbutton_new ( "y0", 0.0, -1000000.0, 1000000.0, 0.1, 1.0, us,

                          t, 0, 1, _("_y0:"), NULL, EXPORT_COORD_PRECISION, 1,

sp_export_spinbutton_new ( "y0", 0.0, -1000000.0, 1000000.0, 0.1, 1.0, us->gobj(),

                          GTK_WIDGET(t->gobj()), 0, 1, _("_y0:"), NULL, EXPORT_COORD_PRECISION, 1,
                          G_CALLBACK (sp_export_area_y_value_changed), 
                          dlg );

sp_export_spinbutton_new ( "y1", 0.0, -1000000.0, 1000000.0, 0.1, 1.0, us,

                          t, 2, 1, _("y_1:"), NULL, EXPORT_COORD_PRECISION, 1,

sp_export_spinbutton_new ( "y1", 0.0, -1000000.0, 1000000.0, 0.1, 1.0, us->gobj(),

                          GTK_WIDGET(t->gobj()), 2, 1, _("y_1:"), NULL, EXPORT_COORD_PRECISION, 1,
                          G_CALLBACK (sp_export_area_y_value_changed), 
                          dlg );

sp_export_spinbutton_new ( "height", 0.0, -1000000.0, 1000000.0, 0.1, 1.0,

                          us, t, 4, 1, _("Height:"), NULL, EXPORT_COORD_PRECISION, 1,

                          us->gobj(), GTK_WIDGET(t->gobj()), 4, 1, _("Height:"), NULL, EXPORT_COORD_PRECISION, 1,
                          G_CALLBACK (sp_export_area_height_value_changed), 
                          dlg );

/* Adding in the unit box */
gtk_box_pack_start(GTK_BOX(vb), unitbox, FALSE, FALSE, 0);

vb->pack_start(*togglebox, false, false, 3);
vb->pack_start(*t, false, false, 0);
vb->pack_start(*unitbox, false, false, 0);

return f;

-} // end of sp_export_dialog_area_frame

return vb;

+} // end of sp_export_dialog_area_box

void sp_export_dialog (void) { if (!dlg) {

```
   GtkWidget *vb, *hb;
```

```
   Gtk::VBox* vb;
```

   Gtk::HBox* hb;

   gchar title[500];
   sp_ui_dialog_title_string (Inkscape::Verb::get(SP_VERB_FILE_EXPORT), title);

@@ -388,28 +395,35 @@

     GtkTooltips *tt = gtk_tooltips_new();

```
   vb = gtk_vbox_new (FALSE, 4);
```

   gtk_container_set_border_width (GTK_CONTAINER (vb), 0);

   gtk_container_add (GTK_CONTAINER (dlg), vb);

```
   vb = new Gtk::VBox(false, 12);
```
```
   vb->set_border_width(12);
```

   gtk_container_add (GTK_CONTAINER (dlg), GTK_WIDGET(vb->gobj()));

   /* Export area frame */
   {

       GtkWidget *f = sp_export_dialog_area_frame(dlg);

       gtk_box_pack_start (GTK_BOX (vb), f, FALSE, FALSE, 0);

       Gtk::VBox *area_box = sp_export_dialog_area_box(dlg);

```
       area_box->set_border_width(6);
```

       vb->pack_start(*area_box, false, false, 0);
   }

   /* Bitmap size frame */
   {

       GtkWidget *f = gtk_frame_new (_("Bitmap size"));

       gtk_box_pack_start (GTK_BOX (vb), f, FALSE, FALSE, 0);

       GtkWidget *t = gtk_table_new (2, 5, FALSE);

       gtk_table_set_row_spacings (GTK_TABLE (t), 4);

       gtk_table_set_col_spacings (GTK_TABLE (t), 4);

       gtk_container_set_border_width (GTK_CONTAINER (t), 4);

       gtk_container_add (GTK_CONTAINER (f), t);

       Gtk::VBox *size_box = new Gtk::VBox(false, 6);

```
       size_box->set_border_width(6);
```

       Gtk::Label* lbl = new Gtk::Label(_("<big><b>Bitmap size</b></big>"), Gtk::ALIGN_LEFT);

```
       lbl->set_use_markup(true);
```

       size_box->pack_start(*lbl, false, false, 0);

```
       const int rows = 2;
```
```
       const int cols = 5;
```
```
       const bool homogeneous = false;
```

       Gtk::Table *t = new Gtk::Table(rows, cols, homogeneous);

```
       t->set_row_spacings (4);
```
```
       t->set_col_spacings (4);
```
```
       size_box->pack_start(*t);
```

       sp_export_spinbutton_new ( "bmwidth", 16.0, 1.0, 1000000.0, 1.0, 10.0,

                                  NULL, t, 0, 0,

                                  NULL, GTK_WIDGET(t->gobj()), 0, 0,
                                  _("_Width:"), _("pixels at"), 0, 1,
                                  G_CALLBACK 
                                  (sp_export_bitmap_width_value_changed),

@@ -419,13 +433,13 @@ prefs_get_double_attribute ( "dialogs.export.defaultxdpi", "value", DPI_BASE),

                                  0.01, 100000.0, 0.1, 1.0, NULL, t, 3, 0,

                                  0.01, 100000.0, 0.1, 1.0, NULL, GTK_WIDGET(t->gobj()), 3, 0,
                                  NULL, _("dp_i"), 2, 1,
                                  G_CALLBACK (sp_export_xdpi_value_changed), 
                                  dlg );

       sp_export_spinbutton_new ( "bmheight", 16.0, 1.0, 1000000.0, 1.0, 10.0,

                                  NULL, t, 0, 1,

                                  NULL, GTK_WIDGET(t->gobj()), 0, 1, 
                                  _("Height:"), _("pixels at"), 0, 1, 
                                  G_CALLBACK
                                  (sp_export_bitmap_height_value_changed),

@@ -438,19 +452,24 @@ sp_export_spinbutton_new ( "ydpi", prefs_get_double_attribute ( "dialogs.export.defaultxdpi", "value", DPI_BASE),

                                  0.01, 100000.0, 0.1, 1.0, NULL, t, 3, 1,

                                  0.01, 100000.0, 0.1, 1.0, NULL, GTK_WIDGET(t->gobj()), 3, 1,
                                  NULL, _("dpi"), 2, 0, NULL, dlg );

       vb->pack_start(*size_box);
   }

   /* File entry */
   {

       GtkWidget *frame = gtk_frame_new ("");

       GtkWidget *flabel = gtk_label_new_with_mnemonic (_("_Filename"));

       gtk_frame_set_label_widget (GTK_FRAME(frame), flabel);

       gtk_box_pack_start (GTK_BOX (vb), frame, FALSE, FALSE, 0);

       Gtk::VBox* file_box = new Gtk::VBox(false, 6);

```
       file_box->set_border_width(6);
```

       GtkWidget *fe = gtk_entry_new ();

```
       // true = has mnemonic
```

       Gtk::Label *flabel = new Gtk::Label(_("<big><b>_Filename</b></big>"), Gtk::ALIGN_LEFT, Gtk::ALIGN_CENTER, true);

```
       flabel->set_use_markup(true);
```

       file_box->pack_start(*flabel, false, false, 0);

       Gtk::Entry *fe = new Gtk::Entry();

       /*
        * set the default filename to be that of the current path + document
        * with .png extension

@@ -488,63 +507,87 @@ extension_point[0] = '\0';

                     final_name = g_strconcat(uri_copy, ".png", NULL);

                   gtk_entry_set_text (GTK_ENTRY (fe), final_name);

                   fe->set_text(final_name);

                   g_free(final_name);
                   g_free(uri_copy);
               }
           } else {
               name = g_strconcat(uri, ".png", NULL);

               gtk_entry_set_text (GTK_ENTRY (fe), name);

               fe->set_text(name);
               g_free(name);
           }

           doc_export_name = g_strdup(gtk_entry_get_text(GTK_ENTRY(fe)));

           doc_export_name = g_strdup(fe->get_text().c_str());
       }

       g_signal_connect ( G_OBJECT (fe), "changed",

       g_signal_connect ( G_OBJECT (fe->gobj()), "changed",
                          G_CALLBACK (sp_export_filename_modified), dlg);

```
       hb = gtk_hbox_new (FALSE, 5);
```

       gtk_container_add (GTK_CONTAINER (frame), hb);

       gtk_container_set_border_width (GTK_CONTAINER (hb), 4);

       hb = new Gtk::HBox(FALSE, 5);

       {

           GtkWidget *b = gtk_button_new_with_mnemonic (_("_Browse..."));

           gtk_box_pack_end (GTK_BOX (hb), b, FALSE, FALSE, 4);

           g_signal_connect ( G_OBJECT (b), "clicked",

```
           // true = has mnemonic
```

           Gtk::Button *b = new Gtk::Button();

           Gtk::HBox* pixlabel = new Gtk::HBox(false, 3);

           Gtk::Image *im = new Gtk::Image(Gtk::StockID(Gtk::Stock::DIRECTORY),

                   Gtk::ICON_SIZE_BUTTON);

```
           pixlabel->pack_start(*im);
```

           Gtk::Label *l = new Gtk::Label();

           l->set_markup_with_mnemonic(_("_Browse..."));

```
           pixlabel->pack_start(*l);
```
```
           b->add(*pixlabel);
```

           hb->pack_end (*b, false, false, 4);

           g_signal_connect ( G_OBJECT (b->gobj()), "clicked",
                              G_CALLBACK (sp_export_browse_clicked), NULL );
       }

       gtk_box_pack_start (GTK_BOX (hb), fe, TRUE, TRUE, 0);

       gtk_object_set_data (GTK_OBJECT (dlg), "filename", fe);

       hb->pack_start (*fe, true, true, 0);

```
       file_box->add(*hb);
```

       gtk_object_set_data (GTK_OBJECT (dlg), "filename", fe->gobj());
       gtk_object_set_data (GTK_OBJECT (dlg), "filename-modified", (gpointer)FALSE);

       original_name = g_strdup(gtk_entry_get_text (GTK_ENTRY (fe)));

       original_name = g_strdup(fe->get_text().c_str());
       // pressing enter in the filename field is the same as clicking export:

       g_signal_connect ( G_OBJECT (fe), "activate",

       g_signal_connect ( G_OBJECT (fe->gobj()), "activate",
                          G_CALLBACK (sp_export_export_clicked), dlg );
       // focus is in the filename initially:

       gtk_widget_grab_focus (GTK_WIDGET (fe));

       fe->grab_focus();

       // mnemonic in frame label moves focus to filename:

       gtk_label_set_mnemonic_widget (GTK_LABEL(flabel), fe);

       flabel->set_mnemonic_widget(*fe);

       vb->pack_start(*file_box);
   }

   /* Buttons */

```
   hb = gtk_hbox_new (FALSE, 0);
```

   gtk_box_pack_end (GTK_BOX (vb), hb, FALSE, FALSE, 0);

```
   const bool homogeneous = false;
```
```
   const int spacing = 0;
```

   Gtk::HButtonBox* bb = new Gtk::HButtonBox(Gtk::BUTTONBOX_END);

```
   bb->set_border_width(6);

   {
```

       GtkWidget *b = gtk_button_new ();

       GtkWidget *l = gtk_label_new ("");

       gtk_label_set_markup_with_mnemonic (GTK_LABEL(l), _(" <b>_Export</b> "));

       gtk_container_add (GTK_CONTAINER(b), l);

       gtk_tooltips_set_tip (tt, b, _("Export the bitmap file with these settings"), NULL);

       gtk_signal_connect ( GTK_OBJECT (b), "clicked",

       Gtk::Button *b = new Gtk::Button();

       Gtk::HBox* image_label = new Gtk::HBox(false, 3);

       Gtk::Image *im = new Gtk::Image(Gtk::StockID(Gtk::Stock::APPLY),

```
               Gtk::ICON_SIZE_BUTTON);
```
```
       image_label->pack_start(*im);
```

       Gtk::Label *l = new Gtk::Label();

       l->set_markup_with_mnemonic(_("_Export"));

```
       image_label->pack_start(*l);
```
```
       b->add(*image_label);
```

       gtk_tooltips_set_tip (tt, GTK_WIDGET(b->gobj()), _("Export the bitmap file with these settings"), NULL);

       gtk_signal_connect ( GTK_OBJECT (b->gobj()), "clicked",
                            GTK_SIGNAL_FUNC (sp_export_export_clicked), dlg );

       gtk_box_pack_end (GTK_BOX (hb), b, FALSE, FALSE, 0);

       bb->pack_end(*b, false, false, 0);
   }

```
   gtk_widget_show_all (vb);
```

```
   vb->pack_end(*bb, false, false, 0);
```
```
   vb->show_all();
```
} // end of if (!dlg)

@@ -792,7 +835,6 @@ filename = g_strdup(""); } }

           break;
       }
       case SELECTION_SELECTION:

Index: ChangeLog

--- ChangeLog (revision 11469) +++ ChangeLog (working copy) @@ -1,3 +1,9 @@ +2006-04-29 Jonathon Jongsma <jonathon.jongsma@...400...>

- src/dialogs/export.cpp: Improve the look of the dialog by
applying some of the GNOME HIG recommendations. At the same time,
gtkmm-ified a bit of the code.

2006-04-29 Jon Phillips <jon@...235...>

src/dialogs/rdf.cpp: Updated cc licenses to 2.5 by default.

Jonathon Jongsma

5:45 a.m.

On 4/30/06, Bryce Harrington <bryce@...961...> wrote:

...

Cool, would you mind uploading this to the patch tracker on the website? That is the official place for patches.

I have added it to the patch tracker, but it sounds like i've got a couple things to fix yet (at least the translatable strings you mentioned)

...

Actually, this is *great*. The GTK+ dialogs are legacy; our intention has been to move all of them to gtkmm. Ultimately, I think we'd like to move entirely to gtkmm, so I would definitely encourage you to explore this interest. :-)

I'm really glad to hear this. You can probably count on me to try to clean up a few of the other dialogs then :). Moving fully to gtkmm is going to take a long time and a lot of work, but I personally think it's well worthwhile.

...

That's right. I had originally cleared the widgets in the destructors but it actually caused problems. I suspect things may be getting cleared at some other level, so I don't think the current code leaks memory or anything, but can't prove it.

Ok. good to know. Thanks for your response.

Jonner

6913

Age (days ago)

6913

Last active (days ago)

List overview

Download

2 comments

2 participants

tags (0)

participants (2)

Bryce Harrington
Jonathon Jongsma