Hi all,
I just moved the File dialog code to ui/dialog where it should be and fixed a minor error in its namespace. I adjusted the makefile_inserts for this. But let me know if this causes any problems.
This is to get filedialog to fit into the dialog manager where it should be. Also, it is good to clean up before working on that Export dialog stuff we were talking about.
bob
On Wed, Jul 12, 2006 at 04:25:25PM -0500, Bob Jamison wrote:
Hi all,
I just moved the File dialog code to ui/dialog where it should be and fixed a minor error in its namespace. I adjusted the makefile_inserts for this. But let me know if this causes any problems.
This is to get filedialog to fit into the dialog manager where it should be. Also, it is good to clean up before working on that Export dialog stuff we were talking about.
Cool, this is good to hear!
Btw, it sounds like there is concensus that upgrading our Gtk dependency to 2.6 now for 0.45 is okay. (And to Gtk 2.8 for 0.46.)
So if the Gtk 2.6 file dialog provides stuff you'd like to take advantage of, I think you can go for it.
Bryce
Bob Jamison wrote:
This is to get filedialog to fit into the dialog manager where it should be. Also, it is good to clean up before working on that Export dialog stuff we were talking about.
An export dialog? That's good news! It might be one of the most requested features right now: http://sourceforge.net/tracker/index.php?func=detail&aid=1520237&gro...
Where can I find out more about the "stuff we were talking about"? What are the plans for this export dialog? All I could find in the code was: /** * This class provides an implementation-independent API for * file "Export" dialogs. Saving as these types will not affect * the original file. */ Which doesn't sound like something the current FileSave dialog cannot handle..
Anyway, I have updated/rewritten the filedialog-win32.cpp to again be useful. (but i don't see the export dialog being used just yet) Should I upload my new file to the patch tracker? or was there a good reason for dropping the native file dialogs on Windows?
I have also come about this comment in file.cpp } // FIXME: else (i.e. if reshowing an already shown dialog) save_loc is not used, it thus always displays the previously opened dir Any ideas on how I can help fix it as it is rather annoying?
participants (3)
-
Bob Jamison -
Bryce Harrington -
Ulf Erikson