Hi,
in clearing up some warnings, I (as somewhat expected) spotted a potential issue hiding amongst the others.
libgdl/gdl-dock-item-grip.c: In function 'gdl_dock_item_grip_expose': libgdl/gdl-dock-item-grip.c:143: warning: assignment from incompatible pointer type libgdl/gdl-dock-item-grip.c:146: warning: passing argument 2 of 'gdk_draw_rectangle' from incompatible pointer type
If anyone wants something to poke at a bit, checking this might be good.
Hi,
Did you in any way check this against GDL trunk? The current goal is to get 2.30 compatible and then to switch to 3.x from my understanding...
Cheers, Josh
On Wed, Jun 29, 2011 at 2:43 AM, Jon Cruz <jon@...18...> wrote:
Hi,
in clearing up some warnings, I (as somewhat expected) spotted a potential issue hiding amongst the others.
libgdl/gdl-dock-item-grip.c: In function 'gdl_dock_item_grip_expose': libgdl/gdl-dock-item-grip.c:143: warning: assignment from incompatible pointer type libgdl/gdl-dock-item-grip.c:146: warning: passing argument 2 of 'gdk_draw_rectangle' from incompatible pointer type
If anyone wants something to poke at a bit, checking this might be good.
All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
The warning refers to a line in the focus-handling patch that was added in Inkscape... it is not present in GDL trunk. The line in question sets the colour of the dock item handle depending on whether the dock item has focus or not. I can hopefully have a look at it later.
Really, we need to find a different way of indicating focus... I seem to remember that the handle-drawing code has changed quite a bit upstream, to make use of Cairo bindings.
AV
On 29 June 2011 10:47, Josh Andler <scislac@...400...> wrote:
Hi,
Did you in any way check this against GDL trunk? The current goal is to get 2.30 compatible and then to switch to 3.x from my understanding...
Cheers, Josh
On Wed, Jun 29, 2011 at 2:43 AM, Jon Cruz <jon@...18...> wrote:
Hi,
in clearing up some warnings, I (as somewhat expected) spotted a potential issue hiding amongst the others.
libgdl/gdl-dock-item-grip.c: In function 'gdl_dock_item_grip_expose': libgdl/gdl-dock-item-grip.c:143: warning: assignment from incompatible pointer type libgdl/gdl-dock-item-grip.c:146: warning: passing argument 2 of 'gdk_draw_rectangle' from incompatible pointer type
If anyone wants something to poke at a bit, checking this might be good.
All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Fixed in trunk r10390.
Next job is to replace the use of the deprecated gdk_draw_rectangle symbol!
AV
On 29 June 2011 18:50, Alex Valavanis <valavanisalex@...400...> wrote:
The warning refers to a line in the focus-handling patch that was added in Inkscape... it is not present in GDL trunk. The line in question sets the colour of the dock item handle depending on whether the dock item has focus or not. I can hopefully have a look at it later.
Really, we need to find a different way of indicating focus... I seem to remember that the handle-drawing code has changed quite a bit upstream, to make use of Cairo bindings.
AV
On 29 June 2011 10:47, Josh Andler <scislac@...400...> wrote:
Hi,
Did you in any way check this against GDL trunk? The current goal is to get 2.30 compatible and then to switch to 3.x from my understanding...
Cheers, Josh
On Wed, Jun 29, 2011 at 2:43 AM, Jon Cruz <jon@...18...> wrote:
Hi,
in clearing up some warnings, I (as somewhat expected) spotted a potential issue hiding amongst the others.
libgdl/gdl-dock-item-grip.c: In function 'gdl_dock_item_grip_expose': libgdl/gdl-dock-item-grip.c:143: warning: assignment from incompatible pointer type libgdl/gdl-dock-item-grip.c:146: warning: passing argument 2 of 'gdk_draw_rectangle' from incompatible pointer type
If anyone wants something to poke at a bit, checking this might be good.
All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (3)
-
Alex Valavanis -
Jon Cruz -
Josh Andler