1. In src/io/Makefile_insert, several files are listed with InitialCaps but they are actually all-lowercase, so make fails.
2 After fixing 1, I get:
io/xsltstream.cpp: In member function `virtual void Inkscape::IO::XsltOutputStream::flush()': io/xsltstream.cpp:183: error: `xmlErrorPtr' undeclared (first use this function) io/xsltstream.cpp:183: error: (Each undeclared identifier is reported only once for each function it appears in.) io/xsltstream.cpp:183: error: syntax error before `=' token io/xsltstream.cpp:184: error: `err' undeclared (first use this function)
Please fix these ASAP, and please be careful to not leave CVS in uncompilable state, especially on holidays when it may be hard to reach people.
On Fri, Dec 31, 2004 at 01:12:02AM -0400, bulia byak wrote:
- In src/io/Makefile_insert, several files are listed with
InitialCaps but they are actually all-lowercase, so make fails.
I saw this (yesterday?) and fixed it in CVS.
2 After fixing 1, I get:
io/xsltstream.cpp: In member function `virtual void Inkscape::IO::XsltOutputStream::flush()': io/xsltstream.cpp:183: error: `xmlErrorPtr' undeclared (first use this function) io/xsltstream.cpp:183: error: (Each undeclared identifier is reported only once for each function it appears in.) io/xsltstream.cpp:183: error: syntax error before `=' token io/xsltstream.cpp:184: error: `err' undeclared (first use this function)
Please fix these ASAP, and please be careful to not leave CVS in uncompilable state, especially on holidays when it may be hard to reach people.
This I don't get. Have you re-run configure? libxslt was made a requirement recently (and this file hasn't changed since it was imported into CVS). What version do you have? I've got 1.1.8 (deb release 5).
2 After fixing 1, I get:
io/xsltstream.cpp: In member function `virtual void Inkscape::IO::XsltOutputStream::flush()': io/xsltstream.cpp:183: error: `xmlErrorPtr' undeclared (first use this function) io/xsltstream.cpp:183: error: (Each undeclared identifier is reported only once for each function it appears in.) io/xsltstream.cpp:183: error: syntax error before `=' token io/xsltstream.cpp:184: error: `err' undeclared (first use this function)
Please fix these ASAP, and please be careful to not leave CVS in uncompilable state, especially on holidays when it may be hard to reach people.
This I don't get. Have you re-run configure?
yes
libxslt was made a requirement recently (and this file hasn't changed since it was imported into CVS). What version do you have? I've got 1.1.8 (deb release 5).
~ $ rpm -q -a |grep xslt libxslt1-1.0.33-1mdk libxslt1-devel-1.0.33-1mdk
This passes configure but apparently does not have xmlErrorPtr declared.
-- Kees Cook @outflux.net
The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
libxslt was made a requirement recently (and this file hasn't changed since it was imported into CVS). What version do you have? I've got 1.1.8 (deb release 5).
~ $ rpm -q -a |grep xslt libxslt1-1.0.33-1mdk libxslt1-devel-1.0.33-1mdk
This passes configure but apparently does not have xmlErrorPtr declared.
According to rgrep xmlErrorPtr /usr/include/ on my system, xmlErrorPtr is declared in <libxml/xmlerror.h>.
I've just added an explicit #include <libxml/xmlerror.h> to io/xsltstream.cpp (the only source file to mention xmlErrorPtr according to grep).
Does it now compile for you?
pjrm.
On Sun, 02 Jan 2005 20:24:29 +1100, Peter Moulder <Peter.Moulder@...38...> wrote:
I've just added an explicit #include <libxml/xmlerror.h> to io/xsltstream.cpp (the only source file to mention xmlErrorPtr according to grep).
Does it now compile for you?
Nope because my libxml/xmlerror.h does not have xmlErrorPtr.
$ rpm -q -a |grep libxml libxml2-2.5.11-1mdk libxml2-utils-2.5.11-1mdk libxml2-devel-2.5.11-1mdk
On Sun, Jan 02, 2005 at 12:55:17PM -0400, bulia byak wrote:
On Sun, 02 Jan 2005 20:24:29 +1100, Peter Moulder <Peter.Moulder@...38...> wrote:
I've just added an explicit #include <libxml/xmlerror.h> to io/xsltstream.cpp (the only source file to mention xmlErrorPtr according to grep).
Does it now compile for you?
Nope because my libxml/xmlerror.h does not have xmlErrorPtr.
$ rpm -q -a |grep libxml libxml2-2.5.11-1mdk libxml2-utils-2.5.11-1mdk libxml2-devel-2.5.11-1mdk
The ChangeLog of libxml2 suggests that 2.6.0 was the first version to have xmlErrorPtr.
I've consequently bumped the required version in debian/control and configure.ac. Can you please test that configure now fails, before upgrading your libxml2 ? (You may subsequently like to test that it does compile after upgrading libxml2...)
Btw, libxml2 2.6.0 was released 2003-10-21 according to its ChangeLog. gtk 2.4.0 was released in 2004-03-xx. Any objections to requiring libxml2 >= 2.6.0 (given our requirements of gtk, gtkmm etc.) ?
(I didn't write any of io/* other than the added #include statement, so I don't know how hard it would be not to require 2.6.0, short of postponing our use of io/libio.a.)
Thanks,
pjrm.
bulia byak wrote:
On Sun, 02 Jan 2005 20:24:29 +1100, Peter Moulder <Peter.Moulder@...38...> wrote:
I've just added an explicit #include <libxml/xmlerror.h> to io/xsltstream.cpp (the only source file to mention xmlErrorPtr according to grep).
Does it now compile for you?
Nope because my libxml/xmlerror.h does not have xmlErrorPtr.
Bulia,
I think the problem might be as simple as changing xmlErrorPtr err = xmlGetLastError(); to xmlError *err = xmlGetLastError();
Here is the history. Look at vers 1.19, 2003/10/02: http://cvs.gnome.org/viewcvs/libxml2/include/libxml/xmlerror.h?rev=1.64&...
I just committed the change.
I hope that this trivial fix can get it compiling again for you. Sorry about this breaking the build for you for so many days. You're our most important guy! ;-)
By the way, the XsltStream is ready to be used already, if we can think up a dialog for it.
Bob
participants (4)
-
Bob Jamison -
bulia byak -
Kees Cook -
Peter Moulder