Hi,
at the moment, I'm facing some problems compiling Inkscape (current CVS) on Ubuntu. It used to work a few weeks ago. Error messages indicate a problem with conversions (invalid conversion from void* to guint32* or guchar*)
if g++ -DHAVE_CONFIG_H -I. -I../../inkscape/src -I.. -I/usr/include/freetype2 -DXTHREADS -I/usr/include/freetype2 -I/usr/X11R6/include -DPOTRACE="potrace " -DXTHREADS -pthread -I/usr/include/gdkmm-2.4 -I/usr/lib/gdkmm-2.4/include -I/ usr/include/glibmm-2.4 -I/usr/lib/glibmm-2.4/include -I/usr/include/pangomm-1.4 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/in clude/sigc++-2.0 -I/usr/lib/sigc++-2.0/include -I/usr/include/glib-2.0 -I/usr/li b/glib-2.0/include -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/incl ude/gtkmm-2.4 -I/usr/lib/gtkmm-2.4/include -I/usr/include/atkmm-1.6 -I/usr/inclu de/atk-1.0 -I/usr/include/libxml2 -I../../inkscape/cxxtest -Wall -W -g -O0 -Wall -MT libcroco/cr-utils.o -MD -MP -MF "libcroco/.deps/cr-utils.Tpo" \ -c -o libcroco/cr-utils.o `test -f 'libcroco/cr-utils.c' || echo '../../inksca pe/src/'`libcroco/cr-utils.c; \ then mv -f "libcroco/.deps/cr-utils.Tpo" "libcroco/.deps/cr-utils.Po"; \ else rm -f "libcroco/.deps/cr-utils.Tpo"; exit 1; \ fi ../../inkscape/src/libcroco/cr-utils.c: Dans function « CRStatus cr_utils_utf8_str_to_ucs4(const guchar*, gulong*, guint32**, gulong*) »: ../../inkscape/src/libcroco/cr-utils.c:728: error: conversion invalide de « void* » vers « guint32* » ../../inkscape/src/libcroco/cr-utils.c: Dans function « CRStatus cr_utils_ucs1_str_to_utf8(const guchar*, gulong*, guchar**, gulong*) »: ../../inkscape/src/libcroco/cr-utils.c:974: error: conversion invalide de « void* » vers « guchar* » ../../inkscape/src/libcroco/cr-utils.c: Dans function « CRStatus cr_utils_utf8_str_to_ucs1(const guchar*, gulong*, guchar**, gulong*) »: ../../inkscape/src/libcroco/cr-utils.c:1175: error: conversion invalide de « void* » vers « guchar* » make[2]: *** [libcroco/cr-utils.o] Erreur 1 make[2]: quittant le répertoire « /home/gero/inkscape-build/src » make[1]: *** [all-recursive] Erreur 1 make[1]: quittant le répertoire « /home/gero/inkscape-build » make: *** [all] Erreur 2
Does anybody face the same problem ? Should I submit a new bug ? Is there a workaround ?
Regards,
Matiphas
On Sat, Jul 16, 2005 at 01:40:34AM +1000, Peter Moulder wrote:
I'll prepare a patch, and I'll get someone else to review it.
Actually, adding a cast to the result of g_malloc0 seems like a sufficiently safe change that I'll commit now.
Appended is the patch. I've verified in emacs ediff that adding the cast is the only change in each of the changed lines.
pjrm.
Index: cr-utils.c =================================================================== RCS file: /cvsroot/inkscape/inkscape/src/libcroco/cr-utils.c,v retrieving revision 1.2 diff -d -u -p -r1.2 cr-utils.c --- cr-utils.c 7 Jun 2005 15:01:06 -0000 1.2 +++ cr-utils.c 16 Jul 2005 01:05:19 -0000 @@ -725,7 +725,7 @@ cr_utils_utf8_str_to_ucs4 (const guchar
g_return_val_if_fail (status == CR_OK, status);
- *a_out = g_malloc0 (*a_out_len * sizeof (guint32)); + *a_out = (guint32 *) g_malloc0 (*a_out_len * sizeof (guint32));
status = cr_utils_utf8_to_ucs4 (a_in, a_in_len, *a_out, a_out_len);
@@ -971,7 +971,7 @@ cr_utils_ucs1_str_to_utf8 (const guchar
in_len = *a_in_len;
- *a_out = g_malloc0 (out_len); + *a_out = (guchar *) g_malloc0 (out_len);
status = cr_utils_ucs1_to_utf8 (a_in, a_in_len, *a_out, &out_len);
@@ -1172,7 +1172,7 @@ cr_utils_utf8_str_to_ucs1 (const guchar
g_return_val_if_fail (status == CR_OK, status);
- *a_out = g_malloc0 (*a_out_len * sizeof (guint32)); + *a_out = (guchar *) g_malloc0 (*a_out_len * sizeof (guint32));
status = cr_utils_utf8_to_ucs1 (a_in, a_in_len, *a_out, a_out_len); return status;
Hi
It works fine. Thanks a lot Peter.
By the way, uk.po has a small issue (bad markup)
make[2]: entrant dans le répertoire « /home/gero/inkscape-build » uk.po: unclosed <b>: #: ../src/nodepath.cpp:3293 #, c-format msgid "<b>0</b> out of <b>%i</b> node selected. <b>Click</b>, <b>Shift+click</b> , or <b>drag around</b> nodes to select." msgid_plural "<b>0</b> out of <b>%i</b> nodes selected. <b>Click</b>, <b>Shift+c lick</b>, or <b>drag around</b> nodes to select." msgstr[0] "Виділено <b>0</b> з <b>%i</b> вузла. Щоб виділити використовуйте <b>к лацання</b>, <b>Shift+клацання</b>, чи перетягування рамки навколо вузлів." msgstr[1] "Виділено <b>0</b> з <b>%i</b> вузлів. Щоб виділити використовуйте <b> клацання</b>, <b>Shift+клацання</b>, чи перетягування рамки навколо вузлів." msgstr[2] "Виділено <b>0</b> з <b>%i</b> вузлів. Щоб виділити використовуйте <b> клацання<b>, <b>Shift+клацання</b>, чи перетягування рамки навколо вузлів."
WARNING: Bad markup found in translations. Please consider fixing the above pro blems.
Regards,
Matiphas
participants (2)
-
unknown＠example.com -
Peter Moulder