New contributor (we have new code!) that we need to help
Hey all,
I submitted a new "report" based around a patch submitted from the primary developer of Ponyscape (an Inkscape derivative project focused on making life easier for artists interested in creating My Little Pony fan art).
Check out the first new patch he has submitted upstream at: https://bugs.launchpad.net/inkscape/+bug/1157024
I've talked with him a bit and he's really doing some good work at a rapid pace, but as we know, we don't have the same leeway upstream to add features that may change on a regular basis. So, he sees Ponyscape as a good testing ground to let things have some time to mature and ripen and then he will submit patches upstream. He also doesn't want to step on any toes or anything.
That first patch is for a long awaited feature. If others would be willing to test and do some code review, it will help us to establish a tighter relationship with Ted. He's already met the 2 patch requirement and has commit access, but he really wants feedback and to get things right before stuff is committed.
My guess is with the amount of divergence and level of changes he makes, this patch vs direct commit paradigm might be around for a while (he has a lot of irons in the fire for new/improved features). My view is that I don't mind doing this side of things provided other devs will be willing to help test and give feedback.
Cheers, Josh
Hi,
First, let me say this really sounds great! Welcome Ted! I could have used Ponyscape a couple of months ago when I was preparing a Pony party for my older daughter's sixth birthday. The guests played pin the horn on Fluttershy and the birthday cake was a Pony Carousel.
Here are some random thoughts:
Let's be honest, 0.49 isn't going to happen soon. There is no sign that anybody is tackling the bitmap scaling problem from either the Inkscape or the Cairo side. And even if Cairo were to have the API's needed today it will be awhile before there is a Cairo release with them.
Given that, I don't think we need to be overly worried about changes to the Inkscape code base. (But I do think new features should be reasonably complete.)
I am intrigued by Ted's comment about using an XmlNodeObserver for handling updates. It would be good to have someone really understand how updates are handled by Inkscape. When I put in random print statements I often see the same code being executed multiple times when it should only be executed once. We seem to have quasi-circular loops going on.
Playing with the Object dialog in Ponyscape:
* Blurring an object crashes Ponyscape. * It's not clear what all the icons are for... no tooltips. What are the up/down icons for? * Clicking on the "domino" shaped icon brings up a color picker which I can't seem to get rid of. I have to restart the program. * Layers and objects seem to be randomly hidden when dragging them up and down. * Can't move objects between layers using arrows. * Not easy to move objects into and out of groups (like in the XML editor). * I see lots of error messages.
In summary, it's a good start but needs polishing before merging (note: I haven't tested the patch, just Ponyscape).
Playing with the Tagging dialog:
* Needs tooltips or other hints on how to use. * The items list is auto opened... maybe should also be auto closed? * Would be useful to be able to rename objects in dialog. * Might be good to integrate with symbols dialog (create custom symbols from tagged objects).
If Ted plans on submitting patches routinely, it might make sense for him to keep his code repository as a branch of Inkscape. It would make it easier to follow his work.
Tav
On Tue, 2013-03-19 at 00:18 -0700, Josh Andler wrote:
Hey all,
I submitted a new "report" based around a patch submitted from the primary developer of Ponyscape (an Inkscape derivative project focused on making life easier for artists interested in creating My Little Pony fan art).
Check out the first new patch he has submitted upstream at: https://bugs.launchpad.net/inkscape/+bug/1157024
I've talked with him a bit and he's really doing some good work at a rapid pace, but as we know, we don't have the same leeway upstream to add features that may change on a regular basis. So, he sees Ponyscape as a good testing ground to let things have some time to mature and ripen and then he will submit patches upstream. He also doesn't want to step on any toes or anything.
That first patch is for a long awaited feature. If others would be willing to test and do some code review, it will help us to establish a tighter relationship with Ted. He's already met the 2 patch requirement and has commit access, but he really wants feedback and to get things right before stuff is committed.
My guess is with the amount of divergence and level of changes he makes, this patch vs direct commit paradigm might be around for a while (he has a lot of irons in the fire for new/improved features). My view is that I don't mind doing this side of things provided other devs will be willing to help test and give feedback.
Cheers, Josh
Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 19-03-13 14:27, Tavmjong Bah wrote:
Let's be honest, 0.49 isn't going to happen soon. There is no sign that anybody is tackling the bitmap scaling problem from either the Inkscape or the Cairo side. And even if Cairo were to have the API's needed today it will be awhile before there is a Cairo release with them.
I had a look yesterday, and I might be able to hack in something specifically for the display of bitmaps (image elements). Would this be sufficient for now? (In terms of fixing our bitmap scaling issues.)
2013/3/20 Jasper van de Gronde <th.v.d.gronde@...528...>:
On 19-03-13 14:27, Tavmjong Bah wrote:
Let's be honest, 0.49 isn't going to happen soon. There is no sign that anybody is tackling the bitmap scaling problem from either the Inkscape or the Cairo side. And even if Cairo were to have the API's needed today it will be awhile before there is a Cairo release with them.
I had a look yesterday, and I might be able to hack in something specifically for the display of bitmaps (image elements). Would this be sufficient for now? (In terms of fixing our bitmap scaling issues.)
When it comes to hacks, the best we can do without changing Cairo is to separate the image transform into a pure scaling part and rotation/skew part, do the scaling part on our side if it's a decimation, and do the rotation/skew part with Cairo. This will give acceptable results in 90% of cases (usually big images such as photos have an uniform scale and no rotation or skew), but the output will be less-than-ideal results for skewed and rotated images.
Regards, Krzysztof
On 2013-03-20 16:45, Krzysztof Kosiński wrote:
2013/3/20 Jasper van de Gronde <th.v.d.gronde@...528...>:
On 19-03-13 14:27, Tavmjong Bah wrote:
Let's be honest, 0.49 isn't going to happen soon. There is no sign that anybody is tackling the bitmap scaling problem from either the Inkscape or the Cairo side. And even if Cairo were to have the API's needed today it will be awhile before there is a Cairo release with them.
I had a look yesterday, and I might be able to hack in something specifically for the display of bitmaps (image elements). Would this be sufficient for now? (In terms of fixing our bitmap scaling issues.)
When it comes to hacks, the best we can do without changing Cairo is to separate the image transform into a pure scaling part and rotation/skew part, do the scaling part on our side if it's a decimation, and do the rotation/skew part with Cairo. This will give acceptable results in 90% of cases (usually big images such as photos have an uniform scale and no rotation or skew), but the output will be less-than-ideal results for skewed and rotated images.
I just committed something along those lines. I've tested all sorts of transforms, and most of the time it looks fine. For all sorts of reasons it is not ideal (you want to do all resampling operations in one go, ideally), but it will probably suffice for now.
(In case anything is wrong with the code, I probably won't respond very quickly during the next couple of days.)
participants (4)
-
Jasper van de Gronde -
Josh Andler -
Krzysztof Kosiński -
Tavmjong Bah