On 10/2/06, Niko Kiirala <niko@...1267...> wrote:
Whoops, old info. Running inkscape in debugger, I just struck gold and found the reason for this problem. (a rather stupid one, too, so I won't go into further detail) Now fixed in SVN.
Thanks! Finally the blur is usable with UI - please everyone check it out (it's in the Fill & Stroke dialog at bottom).
Files saved with blur seem to render correctly in Batik though not in Firefox (which does not support filters yet).
There are still things to be done. Here's what I have proposed, please everyone feel free to discuss and add to the list:
- There is still some banding happening when I scroll the window with a blurred object so it scrolls in from beyond the screen. There's perhaps some error in determining how much the buffer needs to be enlarged so that the rendering strips tile up seamlessly.
- When nothing selected, the blur slider should be grayed out, as is the Master opacity control.
- I think it makes sense to set and display blur radius in % of the current object size (the diagonal of its bbox). Otherwise it's almost useless for small objects - a 0.01 increment is too much for them. I think 50% is a reasonable maximum value - any stronger blur just makes little difference visually.
- If the radius set by the user is bigger than 10% which is the SVG standard filter area margin, you need to also set the corresponding larger margin, so that blur is never cut off.
- Speaking of cleaning up console output: I see lots of
(inkscape:7289): GLib-GObject-WARNING **: invalid cast from `(null)' to `SPGaussianBlur'
on the console.
- While not directly related to the slider, we need to make it so that the blur radius is scaled proportionally when the object is scaled. This can be coded similar to the way stroke width is now treated. Later we can add another button in the row of "scale with object" buttons on Selector controls bar for the blur (now it has buttons for stroke width, rounded rect corners, gradients and patterns). (I think I'll try to do this myself because I know this code.)
More on filters:
- There is still some banding happening when I scroll the window with
a blurred object so it scrolls in from beyond the screen. There's perhaps some error in determining how much the buffer needs to be enlarged so that the rendering strips tile up seamlessly.
In addition to that, exporting a blurred object to bitmap produces banding.
- When nothing selected, the blur slider should be grayed out, as is
the Master opacity control.
This one I've fixed (not committed yet)
- Speaking of cleaning up console output: I see lots of
(inkscape:7289): GLib-GObject-WARNING **: invalid cast from `(null)' to `SPGaussianBlur'
on the console.
Also fixed in my copy, will commit soon
Other problems:
- Blur does not work on text and images.
- Deleting the filter from defs in XML editor crashes. This is because style.cpp does not listen to the release signal from filter (this code is commented out). Hugo, please work on this because this also gives a crash when an extension effect is applied to a document with a filter in defs, which makes effects and blur unusable together.
- It looks like blurred objects with master opacity <1 are more transparent than they should be. E.g. even with a small blur radius, a point in the middle of a large path is about twice more transparent than it is without filter applied. This must be fixed before the release, because otherwise people will start creating files with blur using the wrong opacity value - and will get a nasty surprise when this bug is finally fixed.
On 10/4/06, bulia byak <buliabyak@...400...> wrote:
- Blur does not work on text and images.
Fixed now.
- Deleting the filter from defs in XML editor crashes. This is because
style.cpp does not listen to the release signal from filter (this code is commented out). Hugo, please work on this because this also gives a crash when an extension effect is applied to a document with a filter in defs, which makes effects and blur unusable together.
Still not fixed. Hugo?
- It looks like blurred objects with master opacity <1 are more
transparent than they should be. E.g. even with a small blur radius, a point in the middle of a large path is about twice more transparent than it is without filter applied. This must be fixed before the release, because otherwise people will start creating files with blur using the wrong opacity value - and will get a nasty surprise when this bug is finally fixed.
Indeed, if a blurred object had master opacity <1, this opacity was applied twice. I fixed this. As a result, blurred objects in your files may become more opaque now. Sorry for the inconvenience, but the new rendering is correct.
Files saved with blur seem to render correctly in Batik though not in Firefox (which does not support filters yet).
Just for the information, files with blur render perfectly in Opera 9.x (it supports filters)
Thanks! Molumen
----- Original Message ----- From: "bulia byak" <buliabyak@...400...> To: "Niko Kiirala" <niko@...1267...>; "Hugo Rodrigues" <haa.rodrigues@...400...> Cc: inkscape-devel@lists.sourceforge.net Sent: Tuesday, October 03, 2006 12:42 AM Subject: [Inkscape-devel] Blur todo
On 10/2/06, Niko Kiirala <niko@...1267...> wrote:
Whoops, old info. Running inkscape in debugger, I just struck gold and found the reason for this problem. (a rather stupid one, too, so I won't go into further detail) Now fixed in SVN.
Thanks! Finally the blur is usable with UI - please everyone check it out (it's in the Fill & Stroke dialog at bottom).
Files saved with blur seem to render correctly in Batik though not in Firefox (which does not support filters yet).
There are still things to be done. Here's what I have proposed, please everyone feel free to discuss and add to the list:
- There is still some banding happening when I scroll the window with
a blurred object so it scrolls in from beyond the screen. There's perhaps some error in determining how much the buffer needs to be enlarged so that the rendering strips tile up seamlessly.
- When nothing selected, the blur slider should be grayed out, as is
the Master opacity control.
- I think it makes sense to set and display blur radius in % of the
current object size (the diagonal of its bbox). Otherwise it's almost useless for small objects - a 0.01 increment is too much for them. I think 50% is a reasonable maximum value - any stronger blur just makes little difference visually.
- If the radius set by the user is bigger than 10% which is the SVG
standard filter area margin, you need to also set the corresponding larger margin, so that blur is never cut off.
- Speaking of cleaning up console output: I see lots of
(inkscape:7289): GLib-GObject-WARNING **: invalid cast from `(null)' to `SPGaussianBlur'
on the console.
- While not directly related to the slider, we need to make it so that
the blur radius is scaled proportionally when the object is scaled. This can be coded similar to the way stroke width is now treated. Later we can add another button in the row of "scale with object" buttons on Selector controls bar for the blur (now it has buttons for stroke width, rounded rect corners, gradients and patterns). (I think I'll try to do this myself because I know this code.)
-- bulia byak Inkscape. Draw Freely. http://www.inkscape.org
Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=D... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
- There is still some banding happening when I scroll the window with
a blurred object so it scrolls in from beyond the screen. There's perhaps some error in determining how much the buffer needs to be enlarged so that the rendering strips tile up seamlessly.
I filled a bug report with screenshots showing the bug in action. It is bug 1554421
http://sourceforge.net/tracker/index.php?func=detail&aid=1554421&gro...
Thanks! Molumen
----- Original Message ----- From: "bulia byak" <buliabyak@...400...> To: "Niko Kiirala" <niko@...1267...>; "Hugo Rodrigues" <haa.rodrigues@...400...> Cc: inkscape-devel@lists.sourceforge.net Sent: Tuesday, October 03, 2006 12:42 AM Subject: [Inkscape-devel] Blur todo
On 10/2/06, Niko Kiirala <niko@...1267...> wrote:
Whoops, old info. Running inkscape in debugger, I just struck gold and found the reason for this problem. (a rather stupid one, too, so I won't go into further detail) Now fixed in SVN.
Thanks! Finally the blur is usable with UI - please everyone check it out (it's in the Fill & Stroke dialog at bottom).
Files saved with blur seem to render correctly in Batik though not in Firefox (which does not support filters yet).
There are still things to be done. Here's what I have proposed, please everyone feel free to discuss and add to the list:
- There is still some banding happening when I scroll the window with
a blurred object so it scrolls in from beyond the screen. There's perhaps some error in determining how much the buffer needs to be enlarged so that the rendering strips tile up seamlessly.
- When nothing selected, the blur slider should be grayed out, as is
the Master opacity control.
- I think it makes sense to set and display blur radius in % of the
current object size (the diagonal of its bbox). Otherwise it's almost useless for small objects - a 0.01 increment is too much for them. I think 50% is a reasonable maximum value - any stronger blur just makes little difference visually.
- If the radius set by the user is bigger than 10% which is the SVG
standard filter area margin, you need to also set the corresponding larger margin, so that blur is never cut off.
- Speaking of cleaning up console output: I see lots of
(inkscape:7289): GLib-GObject-WARNING **: invalid cast from `(null)' to `SPGaussianBlur'
on the console.
- While not directly related to the slider, we need to make it so that
the blur radius is scaled proportionally when the object is scaled. This can be coded similar to the way stroke width is now treated. Later we can add another button in the row of "scale with object" buttons on Selector controls bar for the blur (now it has buttons for stroke width, rounded rect corners, gradients and patterns). (I think I'll try to do this myself because I know this code.)
-- bulia byak Inkscape. Draw Freely. http://www.inkscape.org
Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=D... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 10/2/06, bulia byak <buliabyak@...400...> wrote:
- I think it makes sense to set and display blur radius in % of the
current object size (the diagonal of its bbox). Otherwise it's almost useless for small objects - a 0.01 increment is too much for them. I think 50% is a reasonable maximum value - any stronger blur just makes little difference visually.
- If the radius set by the user is bigger than 10% which is the SVG
standard filter area margin, you need to also set the corresponding larger margin, so that blur is never cut off.
Both these issues are addressed now. Enjoy.
participants (2)
-
bulia byak -
momo