11:07 p.m.
Hi all
Upon crawling through the source code for memory related issues, I noticed
some serious issues in the dxf2svg code. Modifying the code (at least in
entities2elements.cpp) did not result in recompilation and apparently the
code has not been looked after for years (see [1]) and was since long
excluded from the building system ([2], [3] and [4]).
Is there still some purpose for the code or could we drop the dxf2svg
extension code from the source tree?
Regards
K.
Links (with thanks to suv for the links):
[1]
http://article.gmane.org/gmane.comp.graphics.inkscape.devel/13050/match=d...
[2]
http://inkscape.svn.sourceforge.net/viewvc/inkscape/trunk/inkscape/src/ex...
[3]
http://inkscape.svn.sourceforge.net/viewvc/inkscape?view=revision&rev...
[4]
http://inkscape.svn.sourceforge.net/viewvc/inkscape/inkscape/trunk/src/ex...
1:37 a.m.
On Sat, Jan 26, 2013 at 6:07 PM, Kris De Gussem <kris.degussem@...400...> wrote:
Hi all
Upon crawling through the source code for memory related issues, I noticed
some serious issues in the dxf2svg code. Modifying the code (at least in
entities2elements.cpp) did not result in recompilation and apparently the
code has not been looked after for years (see [1]) and was since long
excluded from the building system ([2], [3] and [4]).
Is there still some purpose for the code or could we drop the dxf2svg
extension code from the source tree?
Excuse me, but do you realize that you are looking at the SVN code
repository which we haven't used for, like, 4 years? :)
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/changes?filter_f...
Alexandre Prokoudine
http://libregraphicsworld.org
1:58 a.m.
New subject: SVN Repository
On Sat, 2013-01-26 at 19:37 +0300, Alexandre Prokoudine wrote:
Excuse me, but do you realize that you are looking at the SVN code
repository which we haven't used for, like, 4 years? :)
Should the svn be deactivated? It seems confusing to have multiple code
bases floating around.
Martin,
2:01 a.m.
New subject: SVN Repository
On Sat, Jan 26, 2013 at 8:58 PM, Martin Owens wrote:
On Sat, 2013-01-26 at 19:37 +0300, Alexandre Prokoudine wrote:
>
> Excuse me, but do you realize that you are looking at the SVN code
> repository which we haven't used for, like, 4 years? :)
Should the svn be deactivated? It seems confusing to have multiple code
bases floating around.
Yeah, let's just kill our existing SVN-based website :)
Alexandre Prokoudine
http://libregraphicsworld.org
2:10 a.m.
New subject: SVN Repository
On Sat, 2013-01-26 at 20:01 +0300, Alexandre Prokoudine wrote:
Yeah, let's just kill our existing SVN-based website :)
Indeed :) shouldn't be too long now before we have the website up and
running. But can't we remove the inkscape svn branches for now?
Martin,
2:15 a.m.
New subject: SVN Repository
On 26/01/2013 17:58, Martin Owens wrote:
On Sat, 2013-01-26 at 19:37 +0300, Alexandre Prokoudine wrote:
>
> Excuse me, but do you realize that you are looking at the SVN code
> repository which we haven't used for, like, 4 years? :)
Should the svn be deactivated? It seems confusing to have multiple code
bases floating around.
It already is (as far as can be done without losing the older revision
history not included in the bazaar repository at launchpad):
<http://inkscape.svn.sourceforge.net/viewvc/inkscape/inkscape/trunk/>
See also earlier on this list:
<http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/38685/focus=38...
2:01 a.m.
On 26/01/2013 17:37, Alexandre Prokoudine wrote:
On Sat, Jan 26, 2013 at 6:07 PM, Kris De Gussem
<kris.degussem@...400...> wrote:
> Hi all
>
> Upon crawling through the source code for memory related issues, I noticed
> some serious issues in the dxf2svg code. Modifying the code (at least in
> entities2elements.cpp) did not result in recompilation and apparently the
> code has not been looked after for years (see [1]) and was since long
> excluded from the building system ([2], [3] and [4]).
> Is there still some purpose for the code or could we drop the dxf2svg
> extension code from the source tree?
Excuse me, but do you realize that you are looking at the SVN code
repository which we haven't used for, like, 4 years? :)
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/changes?filter_f...
Excuse me - do you realize that the references to the SVN repository are
there because 'src/extension/dxf2svg' doesn't appear to have been
touched in years, certainly not after the move to bazaar and launchpad
(beyond some recent changes based on cppcheck warnings and a few other
global changes to header files)?
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/files/head:/src/...
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/head:/src/e...
Since the commit history in bazaar is not going back far enough, one
needs to undig the changes in SVN…
The file your link refers to is a python-based input extension script
which AFAICT is unrelated to the C++ code in 'src/extension/dxf2svg',
originating from an earlier GSoC project (2005) aiming to implement dxf
import as library (internally):
- DXF Import / Export - Matthew Squires
<http://wiki.inkscape.org/wiki/index.php/SOC_Accepted_Proposals>
2:06 a.m.
On Sat, Jan 26, 2013 at 9:01 PM, ~suv <suv-sf@...58...> wrote:
Excuse me - do you realize that the references to the SVN repository
are
there because 'src/extension/dxf2svg' doesn't appear to have been touched in
years, certainly not after the move to bazaar and launchpad (beyond some
recent changes based on cppcheck warnings and a few other global changes to
header files)?
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/11467
Alexandre Prokoudine
http://libregraphicsworld.org
2:08 a.m.
On Sat, Jan 26, 2013 at 9:06 PM, Alexandre Prokoudine wrote:
Oh, okay. We are talking about different things.
Yes, the C++ code is dead and can be safely removed.
Alexandre Prokoudine
http://libregraphicsworld.org
3:53 a.m.
2013/1/26 Alexandre Prokoudine <alexandre.prokoudine@...400...>
On Sat, Jan 26, 2013 at 9:06 PM, Alexandre Prokoudine wrote:
> http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/11467
Oh, okay. We are talking about different things.
Yes, the C++ code is dead and can be safely removed.
dxf2svg extension (src/extension/dxf2svg/*.*) removed from the source
directory in trunk revision 12075.
5:09 a.m.
On Wed, Jan 30, 2013 at 10:53 PM, Kris De Gussem wrote:
2013/1/26 Alexandre Prokoudine
<alexandre.prokoudine@...400...>
>
> On Sat, Jan 26, 2013 at 9:06 PM, Alexandre Prokoudine wrote:
>
> > http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/11467
>
> Oh, okay. We are talking about different things.
>
> Yes, the C++ code is dead and can be safely removed.
>
dxf2svg extension (src/extension/dxf2svg/*.*) removed from the source
directory in trunk revision 12075.
Thanks, Kris :)
Alexandre Prokoudine
http://libregraphicsworld.org
3772
days inactive
3776
days old
inkscape-devel@lists.inkscape.org
10 comments
4 participants
participants (4)
-
Alexandre Prokoudine -
Kris De Gussem -
Martin Owens -
~suv