proposed change to icons
Bryce wrote:
Since our development policy is "patch first, discuss later", I don"t think we should make a decision about the defaults until the options were all available for review.
I've committed changes to eight of the icons (rotate, flip, raise, and lower), and that's all the changes I want to make. I'll leave it up to others to decide whether keep these new versions as is, tweak them further, or revert them completely to Bulia's versions. AFAIK, there is currently no mechanism for maintaining multiple versions of the icons from which users can choose. Mine are the current defaults, but if someone else wants to create a multiple-icon-option mechanism, and then debate which set should be the default, that's fine.
On Sat, Jan 01, 2005 at 03:14:35PM +0000, Ben Crowell wrote:
I've committed changes to eight of the icons (rotate, flip, raise, and lower), and that's all the changes I want to make.
Before we get to far replacing icons, I think we should focus on getting all the remaining pixmaps replaced. Here's the current list that I know of for pixmaps that are still in use:
join_miter.xpm join_round.xpm join_bevel.xpm cap_butt.xpm cap_round.xpm cap_square.xpm marker_none_start.xpm marker_triangle_start.xpm marker_arrow_start.xpm marker_none_start.xpm marker_triangle_end.xpm marker_arrow_end.xpm marker_none_end.xpm marker_triangle_end.xpm marker_arrow_end.xpm rotate_left.xpm scale_hor.xpm scale_ver.xpm arrows_hor.xpm arrows_ver.xpm dimension_hor.xpm writing_mode_lr.xpm writing_mode_tb.xpm add_xml_element_node.xpm add_xml_text_node.xpm duplicate_xml_node.xpm delete_xml_node.xpm delete_xml_attribute.xpm set.xpm fill_none.xpm fill_solid.xpm fill_gradient.xpm fill_radial.xpm fill_pattern.xpm fill_fractal.xpm toolbox_file.xpm toolbox_edit.xpm toolbox_object.xpm toolbox_select.xpm toolbox_draw.xpm toolbox_zoom.xpm toolbox_node.xpm edit_duplicate.xpm selection_top.xpm selection_bot.xpm selection_up.xpm selection_down.xpm selection_group.xpm selection_ungroup.xpm selection_combine.xpm selection_break.xpm object_rotate.xpm object_reset.xpm object_tocurve.xpm draw_select.xpm draw_node.xpm draw_rect.xpm draw_arc.xpm draw_star.xpm draw_spiral.xpm draw_freehand.xpm draw_pen.xpm draw_dynahand.xpm draw_text.xpm draw_zoom.xpm zoom_in.xpm zoom_out.xpm zoom_page.xpm zoom_draw.xpm zoom_select.xpm object_layout.xpm object_trans.xpm object_align.xpm
On Sun, Jan 02, 2005 at 11:40:13AM -0800, Kees Cook wrote:
all the remaining pixmaps replaced. Here's the current list that I know of for pixmaps that are still in use:
Correction, that was the list of those still getting _loaded_, but most were not in use. Here, I think is the current list. I've removed all the unused ones from the build. The fill* ones confuse me since the buttons in the dialog appear to be from the SVG doc, but they're still getting loaded in code. Weird.
add_xml_element_node.xpm \ add_xml_text_node.xpm \ arrows_hor.xpm \ arrows_ver.xpm \ cap_butt.xpm \ cap_round.xpm \ cap_square.xpm \ delete_xml_attribute.xpm \ delete_xml_node.xpm \ dimension_hor.xpm \ duplicate_xml_node.xpm \ fill_fractal.xpm \ fill_gradient.xpm \ fill_none.xpm \ fill_pattern.xpm \ fill_radial.xpm \ fill_solid.xpm \ join_bevel.xpm \ join_miter.xpm \ join_round.xpm \ properties_fill.xpm \ properties_layout.xpm \ properties_stroke.xpm \ rotate_left.xpm \ scale_hor.xpm \ scale_ver.xpm \ set.xpm \ writing_mode_lr.xpm \ writing_mode_tb.xpm \
Kees Cook wrote:
On Sat, Jan 01, 2005 at 03:14:35PM +0000, Ben Crowell wrote:
I've committed changes to eight of the icons (rotate, flip, raise, and lower), and that's all the changes I want to make.
Before we get to far replacing icons, I think we should focus on getting all the remaining pixmaps replaced. Here's the current list that I know of for pixmaps that are still in use:
Here are svg icons to replace add_xml_element_node.xpm, add_xml_text_node.xpm and delete_xml_attribute.xpm
http://ramnet.se/~nisse/diverse/temp/add_xml_element_node.svg http://ramnet.se/~nisse/diverse/temp/add_xml_text_node.svg http://ramnet.se/~nisse/diverse/temp/delete_xml_attribute.svg
Hope they will do. I will continue with the rest early next week. - Andreas
On Mon, Jan 03, 2005 at 09:05:47PM +0100, Andreas Nilsson wrote:
http://ramnet.se/~nisse/diverse/temp/add_xml_element_node.svg http://ramnet.se/~nisse/diverse/temp/add_xml_text_node.svg http://ramnet.se/~nisse/diverse/temp/delete_xml_attribute.svg
Hope they will do. I will continue with the rest early next week.
- Andreas
Cool! Since these are really small, can you make the "newness" indicator larger? When I make them small, I can't see the shine. A big "plus" as in the xml editor window's icons is probably the way to go. Also, for the "delete" icon, which there are two (delete node, delete attribute) they need to be distinguishable from eachother somehow.
Thanks!
participants (3)
-
Andreas Nilsson -
Ben Crowell -
Kees Cook