Re: [Inkscape-devel] [root@...1070...: [Inkscape-tester] inkscape build report]
I don't know what 'make check' does exactly but there's a great chance that it is run on a machine with a Cairo library older than 1.2 which didn't have the PDF backend enabled by default, thus it doesn't have the needed header file. Also, cairo-pdf.h is included with "" and not <> but I don't think changing this would solve the problem. In order to solve this Inkscape will have to depend on Cairo 1.2 right? Or the Cairo PDF exporter could be enabled via a configure parameter.
On Sun, 2006-07-30 at 00:46 +0200, Miklós Erdélyi wrote:
I don't know what 'make check' does exactly but there's a great chance that it is run on a machine with a Cairo library older than 1.2 which didn't have the PDF backend enabled by default, thus it doesn't have the needed header file. Also, cairo-pdf.h is included with "" and not <> but I don't think changing this would solve the problem. In order to solve this Inkscape will have to depend on Cairo 1.2 right? Or the Cairo PDF exporter could be enabled via a configure parameter.
Yes, you need 1.2 (at least on Ubuntu). I had to pull it from Debian. On the flip side, everything seems to run faster now that I've upgraded :)
I think we should set it so that it builds if you have 1.2, and not if you don't. I don't think most people will set configure options to get features. That way when people make packages for distros with 1.2, they'll get the feature.
--Ted
On Sat, 2006-07-29 at 16:51 -0700, Ted Gould wrote:
On Sun, 2006-07-30 at 00:46 +0200, Miklós Erdélyi wrote: Yes, you need 1.2 (at least on Ubuntu). I had to pull it from Debian. On the flip side, everything seems to run faster now that I've upgraded :)
I think we should set it so that it builds if you have 1.2, and not if you don't. I don't think most people will set configure options to get features. That way when people make packages for distros with 1.2, they'll get the feature.
Carl Worth suggested that we add a pkg-config test for the "cairo-pdf" package, which represents cairo PDF support.
-mental
On Sun, Jul 30, 2006 at 12:46:19AM +0200, Mikl?s Erd?lyi wrote:
I don't know what 'make check' does exactly but there's a great chance that it is run on a machine with a Cairo library older than 1.2 which didn't have the PDF backend enabled by default, thus it doesn't have the needed header file. Also, cairo-pdf.h is included with "" and not <> but I don't think changing this would solve the problem. In order to solve this Inkscape will have to depend on Cairo 1.2 right? Or the Cairo PDF exporter could be enabled via a configure parameter.
From my experiments on my own machine, this does appear to be the case.
Kees and I are planning on doing some upgrades, but this week he has DefCon and I have a vacation, so this'll have to stay broken for a little while.
For future reference, it would be good practice to always have a discussion before adding pre-requisites or upping their versions. I know we usually say "patch first, discuss later", but when it comes to dependencies the discussion is actually pretty important and the patching tends to be fairly trivial. As we saw in the Gtk+ 2.8 upgrade thread, the discussions can often help us avoid potential hornets nests that we don't want to bother with.
Bryce
participants (4)
-
Bryce Harrington -
MenTaLguY -
Miklós Erdélyi -
Ted Gould