On 2014-03-28 19:23 +0100, Martin Owens wrote:

I just saw the build failures on launchpad relating to the polar align. The problem seems to be the order of header files included relating to glib/thread. It's a weird error and I fixed a few of the compile errors when I merged, but it's come back in the build.

Does anyone have any ideas why launchpad builds could trip the this error but my local build doesn't?

AFAICT the build failure is GTK3-only.

Building with GTK+ 3.10.7 succeeds with the attached patch (and the new dialog does arrange objects - quick test only ;) ). I can't tell though whether this is the correct fix. There were a couple of other warnings, but they didn't cause the build to fail:

In file included from /Volumes/magenta/mp-trunk/quartz/include/gtkmm-3.0/gtkmm.h:247, from ../../src/ui/dialog/grid-arrange-tab.h:20, from ../../src/ui/dialog/grid-arrange-tab.cpp:18: /Volumes/magenta/mp-trunk/quartz/include/gtkmm-3.0/gtkmm/container.h:165: warning: ‘virtual void Gtk::Container::add(Gtk::Widget&)’ was hidden /Volumes/magenta/mp-trunk/quartz/include/gtkmm-3.0/gtkmm/stack.h:137: warning: by ‘Gtk::Stack::add’

Alex Valavanis was the one who fixed these kind of build / include issues in the past - maybe he can help here too?

Regards, V