I've seen these three warnings:
live_effects/lpeobject.cpp: In member function 'LivePathEffectObject* LivePathEffectObject::fork_private_if_necessary(int)': live_effects/lpeobject.cpp:261: warning: comparison between signed and unsigned integer expressions
live_effects/lpe-curvestitch.cpp: In member function 'virtual std::vector<Geom::Path, std::allocatorGeom::Path
Inkscape::LivePathEffect::LPECurveStitch::doEffect_path
(std::vector<Geom::Path, std::allocatorGeom::Path >&)': live_effects/lpe-curvestitch.cpp:92: warning: comparison between signed and unsigned integer expressions live_effects/lpe-curvestitch.cpp:93: warning: comparison between signed and unsigned integer expressions
I think the first one is minor, and the second pair just need a change from 'int' to 'gsize', but I'm not sure what it might do to calculations inside the loops.
If anyone who knows those parts could give it a quick look, that would help.
Thanks.
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of Jon A. Cruz Sent: donderdag 28 februari 2008 17:56 To: inkscape List Subject: [Inkscape-devel] minor items in LPE stuff
I've seen these three warnings:
live_effects/lpeobject.cpp: In member function 'LivePathEffectObject* LivePathEffectObject::fork_private_if_necessary(int)': live_effects/lpeobject.cpp:261: warning: comparison between signed and unsigned integer expressions
live_effects/lpe-curvestitch.cpp: In member function 'virtual std::vector<Geom::Path, std::allocatorGeom::Path
Inkscape::LivePathEffect::LPECurveStitch::doEffect_path
(std::vector<Geom::Path, std::allocatorGeom::Path >&)': live_effects/lpe-curvestitch.cpp:92: warning: comparison between signed and unsigned integer expressions live_effects/lpe-curvestitch.cpp:93: warning: comparison between signed and unsigned integer expressions
I think the first one is minor, and the second pair just need a change from 'int' to 'gsize', but I'm not sure what it might do to calculations inside the loops.
If anyone who knows those parts could give it a quick look, that would help.
Fixed.
-johan
participants (2)
-
unknown@example.com
-
Jon A. Cruz