Re: vim modelines (was Re: [Inkscape-devel] patch for typos)
Sorry, should have gone to the list.
On 11/1/05, Ben Fowler <ben.the.mole@...400...> wrote:
On 11/1/05, Mason Thomas <mlt_svn@...856...> wrote:
Hi,
In addition, I have changed the vim modelines to have filetype of "cpp" rather than "c++" because the default install of vim uses cpp. ...
See http://wiki.inkscape.org/cgi-bin/wiki.pl?InkscapeJanitors just over four fifths of the way down.
If I were asked, I would have guessed that 'cpp' was right and 'c++' was wrong. If there is a ruling that there should be 'one true vim modeline' then I would be happy to commit the changes for every one that is wrong. (That is why it is on the Janitors page!), but I haven't considered doing so to date to avoid the noise in the cvs system.
Ben
It is of course, a very good idea to have the patch in the tracker.
On 09:03 Wed 02 Nov , Ben Fowler wrote:
Sorry, should have gone to the list.
On 11/1/05, Ben Fowler <ben.the.mole@...400...> wrote:
On 11/1/05, Mason Thomas <mlt_svn@...856...> wrote:
Hi,
In addition, I have changed the vim modelines to have filetype of "cpp" rather than "c++" because the default install of vim uses cpp. ...
See http://wiki.inkscape.org/cgi-bin/wiki.pl?InkscapeJanitors just over four fifths of the way down.
If I were asked, I would have guessed that 'cpp' was right and 'c++' was wrong. If there is a ruling that there should be 'one true vim modeline' then I would be happy to commit the changes for every one that is wrong. (That is why it is on the Janitors page!), but I haven't considered doing so to date to avoid the noise in the cvs system.
Ben
It is of course, a very good idea to have the patch in the tracker.
I added the patch(es) to the tracker (#1346687). The InkscapeJanitors page refers to the CodingStyle page, on which the recommended vim modeline does in fact use a filetype of 'cpp'. Why not just correct all the modelines at once and be done with it?
-Mason
On 11/3/05, Mason Thomas <mlt_svn@...856...> wrote:
On 09:03 Wed 02 Nov , Ben Fowler wrote:
On 11/1/05, Ben Fowler <ben.the.mole@...400...> wrote:
If I were asked, I would have guessed that 'cpp' was right and 'c++' ...
I added the patch(es) to the tracker (#1346687). The InkscapeJanitors page refers to the CodingStyle page, on which the recommended vim modeline does in fact use a filetype of 'cpp'. Why not just correct all the modelines at once and be done with it?
O.K. Unless I hear to the contrary, early in the 0.44 cycle I will change all modelines to match the model one.
Thank you for uncovering this.
Ben
participants (2)
-
Ben Fowler -
Mason Thomas