SVN rev 19182 broke building on windows. Because it adds 'src/extension/param/float.h' which is apparently found first by the compiler instead of the correct <float.h>. On windows, the whole inkscape src tree is added to the include path (which is why sometimes windows edits break linux build). I think this is wrong and not necessary either.
Ishmal, can you change the buildtool such that it only adds "." and "src" to the include path instead of the whole src tree?
See attached file for details about what goes wrong.
Thanks, Johan
My svn revision is only at 18199. You mean 18182?
Yes, I probably need to make the include paths smarter. But if you think about it, if the build has been working fine for > a year, and this commit broke it, isn't the cause-and-effect backward? :-)
And you're right:
SVN rev 19182 broke building on windows.
bob
Hi Bob,
My svn revision is only at 18199. You mean 18182?
Sorry for the typo. I meant 18192, where Ted moved the extension parameter code to its own subdir.
Yes, I probably need to make the include paths smarter. But if you think about it, if the build has been working fine for
a year, and this commit broke it, isn't the
cause-and-effect backward? :-)
A simple fix would be to rename all files again to paramfloat.h etc. I don't know what the cause is, because the Inkscape src tree is added after the libraries include dirs. In any case, I tried looking into buildtool.cpp to make a quick fix but I do not yet understand how everything works; it is more intricate than I thought. Don't want to force you into changing buildtool, because we might be moving to cmake soon (it seems to be working for 80% on windows now).
I don't have time now to do the renaming though, and probably won't have internet on my own computer during the weekend..., so I hope somebody else can do the fix.
Johan
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of Bob Jamison Sent: vrijdag 4 april 2008 15:41 To: Engelen, J.B.C. (Johan); inkscape Subject: Re: [Inkscape-devel] Problem with include files seeking
My svn revision is only at 18199. You mean 18182?
Yes, I probably need to make the include paths smarter. But if you think about it, if the build has been working fine for
a year, and this commit broke it, isn't the
cause-and-effect backward? :-)
And you're right:
SVN rev 19182 broke building on windows.
bob
Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.n
et/marketplace
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (2)
-
unknown＠example.com -
Bob Jamison