LGM Video : Code review needed for Jabier's excellent rotate objects LPE improvements.
Hi everyone! I need a quick favour...
I've worked out the script for the LGM video, and there's one last piece missing from the lineup:
I'd absolutely LOVE to add Jabier's massive improvements to the LPEs :
1. "Rotate copies" opendesignstudio.org/inkscape/LPE_rotate_copies_fusioned_paths_jabier_mod.ogv 2. "Mirror Symmetry" http://www.opendesignstudio.org/inkscape/lpe_mirror_symmetry_jabier_mod.ogv
In these videos I've taken bits of Jabier's Youtube screen casts (with permission of course) to combine them into these quick demos that show what has been changed. The credits at the end are my own doing. Sorry about using the same music, for both. :)
Anyway...
As you can see, these additions push the LPE to a whole new level of usefulness that is frankly drool-worthy, a massive time-saver, and is an excellent example of the raw graphics power Inkscape is capable of.
Since the LGM video is very much about eye-candy for the state of the project, these are fireworks that are simply essential to the lineup.
If someone could help us commit these few essential modifications, it would help tremendously!
Thanks in advance!
-C
2016-03-13 8:41 GMT-07:00 C R <cajhne@...400...>:
If someone could help us commit these few essential modifications, it would help tremendously!
I added this to my calendar for tomorrow evening. Please ping me directly off-list if it's not done by Wednesday.
Best regards, Krzysztof
Thanks so much Krzysztof! -C On 15 Mar 2016 5:11 am, "Krzysztof Kosiński" <tweenk.pl@...400...> wrote:
2016-03-13 8:41 GMT-07:00 C R <cajhne@...400...>:
If someone could help us commit these few essential modifications, it
would
help tremendously!
I added this to my calendar for tomorrow evening. Please ping me directly off-list if it's not done by Wednesday.
Best regards, Krzysztof
Krzysztof, finaly Martin make a review for both branches. Ping me today if you want to make an extra review for any question.
Cheers, Jabier.
El lun, 14-03-2016 a las 22:11 -0700, Krzysztof Kosiński escribió:
2016-03-13 8:41 GMT-07:00 C R <cajhne@...400...>:
If someone could help us commit these few essential modifications, it would help tremendously!
I added this to my calendar for tomorrow evening. Please ping me directly off-list if it's not done by Wednesday.
Best regards, Krzysztof
Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
I reviewed both branches.
"Rotate copies" is reasonably OK, but "Mirror symmetry" needs fixes.
Intersecting with an infinite line by evaluating points at times 100000 and -100000 and intersecting with that line segment will not work for very large paths. You can't tell how long is 100000 and whether it's even large relative to the path because the coordinate system can be anything. Please use the line intersection functions, such as Line::intersect().
Best regards, Krzysztof
2016-03-15 2:21 GMT-07:00 Jabier Arraiza <jabier.arraiza@...2893...>:
Krzysztof, finaly Martin make a review for both branches. Ping me today if you want to make an extra review for any question.
Cheers, Jabier.
El lun, 14-03-2016 a las 22:11 -0700, Krzysztof Kosiński escribió:
2016-03-13 8:41 GMT-07:00 C R <cajhne@...400...>:
If someone could help us commit these few essential modifications, it would help tremendously!
I added this to my calendar for tomorrow evening. Please ping me directly off-list if it's not done by Wednesday.
Best regards, Krzysztof
Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (3)
-
C R -
Jabier Arraiza -
Krzysztof Kosiński