Changes in rendering of lpe tests
Can somebody knowledgeable in all things lpe have a look at the new rendering results for the "lpe shapes.svg" and "lpe-knot.svg" tests? Links to the SVG files in SVN can be found on the results page: http://home.hccnet.nl/th.v.d.gronde/inkscape/ResultViewer.html
The existing references are also in SVN: https://inkscape.svn.sourceforge.net/svnroot/inkscape/gsoc-testsuite/tester/...
(There are a few other "New" results shown on that page, but that's just due to a change in the missing file image, and the references have been updated already.)
Hi Jasper,
It is hard to notice differences. I am using perceptual diff with the tester, but it would be very nice if it would output a 'differences' png to quickly see where the changes are. Could you add that to the script?
lpe-knot: the reference file seems incorrect, could you have a look at it J-F ? (bottom right, the dark purple path crosses the light purple path without a white spacing)
lpe shapes: bend path on groups is broken. I'll have a look.
Ciao, Johan
-----Original Message----- From: Jasper van de Gronde [mailto:th.v.d.gronde@...528...] Sent: zaterdag 28 maart 2009 15:27 To: Inkscape Devel List Subject: [Inkscape-devel] Changes in rendering of lpe tests
Can somebody knowledgeable in all things lpe have a look at the new rendering results for the "lpe shapes.svg" and "lpe-knot.svg" tests? Links to the SVG files in SVN can be found on the results page: http://home.hccnet.nl/th.v.d.gronde/inkscape/ResultViewer.html
The existing references are also in SVN: https://inkscape.svn.sourceforge.net/svnroot/inkscape/gsoc-tes
tsuite/tester/references/
(There are a few other "New" results shown on that page, but that's just due to a change in the missing file image, and the references have been updated already.)
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
J.B.C.Engelen@...1578... wrote:
Hi Jasper,
It is hard to notice differences. I am using perceptual diff with the tester, but it would be very nice if it would output a 'differences' png to quickly see where the changes are. Could you add that to the script?
Hmm... A quick fix would probably be to create a batch file/script that executes perceptualdiff with the necessary options and use that to run the tests. However, I'm not entirely sure what effect this will have on differently sized images for example.
lpe-knot: the reference file seems incorrect, could you have a look at it J-F ? (bottom right, the dark purple path crosses the light purple path without a white spacing)
lpe shapes: bend path on groups is broken. I'll have a look.
Appreciate it.
When I revert svn20988, 20987 and 21003, the bug is gone. To reproduce the bug: 1. draw two separate paths 2. group them 3. apply LPE bend and node edit the bend path. You'll see it goes wrong.
Bulia, perhaps you can have a look at it? I hope I can find time soon too.
Ciao, Johan
-----Original Message----- From: Jasper van de Gronde [mailto:th.v.d.gronde@...528...] Sent: zondag 29 maart 2009 16:43 To: Engelen, J.B.C. (Johan) Cc: inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Changes in rendering of lpe tests
J.B.C.Engelen@...1578... wrote:
Hi Jasper,
It is hard to notice differences. I am using perceptual
diff with the
tester, but it would be very nice if it would output a
'differences'
png to quickly see where the changes are. Could you add
that to the script?
Hmm... A quick fix would probably be to create a batch file/script that executes perceptualdiff with the necessary options and use that to run the tests. However, I'm not entirely sure what effect this will have on differently sized images for example.
lpe-knot: the reference file seems incorrect, could you have a look
at it J-F ?
(bottom right, the dark purple path crosses the light purple path without a white spacing)
lpe shapes: bend path on groups is broken. I'll have a look.
Appreciate it.
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Hi,lt
About lpe-knot, I don't see where the trouble is. Is it the "new" entry in the result viewer? I guess it's there because I changed the testcase/reference to test new features (better closed path support and groups). As for the non crossing lines in the bottom right of the reference image, they are intentional: lpe-knot let you leave crossings unchanged if you want... (yeah, you generally don't want, but who knows?...)
Is this an answer or does the test fail indeed?
Cheers, jfb.
2009/3/29 <J.B.C.Engelen@...1578...>
Hi Jasper,
It is hard to notice differences. I am using perceptual diff with the tester, but it would be very nice if it would output a 'differences' png to quickly see where the changes are. Could you add that to the script?
lpe-knot: the reference file seems incorrect, could you have a look at it J-F ? (bottom right, the dark purple path crosses the light purple path without a white spacing)
lpe shapes: bend path on groups is broken. I'll have a look.
Ciao, Johan
-----Original Message----- From: Jasper van de Gronde [mailto:th.v.d.gronde@...528...] Sent: zaterdag 28 maart 2009 15:27 To: Inkscape Devel List Subject: [Inkscape-devel] Changes in rendering of lpe tests
Can somebody knowledgeable in all things lpe have a look at the new rendering results for the "lpe shapes.svg" and "lpe-knot.svg" tests? Links to the SVG files in SVN can be found on the results page: http://home.hccnet.nl/th.v.d.gronde/inkscape/ResultViewer.html
The existing references are also in SVN: https://inkscape.svn.sourceforge.net/svnroot/inkscape/gsoc-tes
tsuite/tester/references/https://inkscape.svn.sourceforge.net/svnroot/inkscape/gsoc-tes%0Atsuite/tester/references/
(There are a few other "New" results shown on that page, but that's just due to a change in the missing file image, and the references have been updated already.)
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
jf barraud wrote:
Hi,lt
About lpe-knot, I don't see where the trouble is. Is it the "new" entry in the result viewer? I guess it's there because I changed the testcase/reference to test new features (better closed path support and groups).
The problem is it's rendered differently from the way it used to be rendered (see attached files). And as I, personally, have zero knowledge of this feature I can't judge which is right and which is wrong. Obviously I could assume the (pass) reference is right (as it should) and the current output is wrong, but I thought the current output seemed a little too "possible" to simply assume this.
In other words: either we have a regression in Inkscape's implementation of this effect, or we used to do it wrong and the reference needs to be updated.
As for the non crossing lines in the bottom right of the reference image, they are intentional: lpe-knot let you leave crossings unchanged if you want... (yeah, you generally don't want, but who knows?...)
Is this an answer or does the test fail indeed?
You tell me :)
Argh! right. lpe-knot for groups does not work :-(
One bug is not directly in lpe-knot, but in the initialisation of the array parameter in the case of groups (which is wrong in some cases).
But trying to reopen the svg source, I see more than this about groups and lpe: when an lpe is applied to a group, the behaviour is strange: it seems the effect is definitely applied to the members each time it is run (try bend for instance). In particular, if you try to node-edit the objects, they only show up in theire deformed version... where we'd like to have the original object.
Playing with this a little generally let inkscape crash. I'm not sure, but I think the behaviour was correct when I did the lpe-knot test file... :-(
Cheers, jfb.
participants (3)
-
unknown＠example.com -
Jasper van de Gronde -
jf barraud