Re: [Inkscape-devel] Fwd: Check coding style examples
Hi everyone,
I'm forwarding this message from Sylvain (website contributor, French translator), which bounced when he tried to send it to the devel mailing list. Could someone please double-check if the salvaged code examples on the website correspond to the style guidelines?
Thanks!
Kind regards, Maren
Message from Sylvain:
Hello everybody,
There were previously code examples on the page of the website about the coding style. These were removed when a highlighter plugin was removed from the CMS. We could get them back from a backup but I restored the format myself as it was encoded (with \r\n instead of line endings and many spaces had run away). Could you please check that the 3 codes are really conformant to the coding style, then correct errors or describe them? The codes are only on the French version of the page; I will add them on the English version when we will be sure they are good.
https://inkscape.org/fr/developper/style-du-code-source/
Note: I am not on the inkscape-devel mailing list, remember to keep me as a receiver of mails about this topic. -- Sylvain
Please, could someone just take a short look? It's not a huge amount of code, and I'd like to get this done while I can...
So:
Do the given code examples here: https://inkscape.org/fr/developper/style-du-code-source/
correspond to the style guidelines after we have salvaged them from the backups and re-formatted them?
Thanks!
Kind regards, Maren
Am 05.04.2016 um 12:11 schrieb Maren Hachmann:
Hi everyone,
I'm forwarding this message from Sylvain (website contributor, French translator), which bounced when he tried to send it to the devel mailing list. Could someone please double-check if the salvaged code examples on the website correspond to the style guidelines?
Thanks!
Kind regards, Maren
Message from Sylvain:
Hello everybody,
There were previously code examples on the page of the website about the coding style. These were removed when a highlighter plugin was removed from the CMS. We could get them back from a backup but I restored the format myself as it was encoded (with \r\n instead of line endings and many spaces had run away). Could you please check that the 3 codes are really conformant to the coding style, then correct errors or describe them? The codes are only on the French version of the page; I will add them on the English version when we will be sure they are good.
https://inkscape.org/fr/developper/style-du-code-source/
Note: I am not on the inkscape-devel mailing list, remember to keep me as a receiver of mails about this topic. -- Sylvain
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
I'm not an expert on the code style, but they look good to me Maren.
On 9 April 2016 at 17:01, Maren Hachmann <maren@...3165...> wrote:
Please, could someone just take a short look? It's not a huge amount of code, and I'd like to get this done while I can...
So:
Do the given code examples here: https://inkscape.org/fr/developper/style-du-code-source/
correspond to the style guidelines after we have salvaged them from the backups and re-formatted them?
Thanks!
Kind regards, Maren
Am 05.04.2016 um 12:11 schrieb Maren Hachmann:
Hi everyone,
I'm forwarding this message from Sylvain (website contributor, French translator), which bounced when he tried to send it to the devel mailing list. Could someone please double-check if the salvaged code examples on the website correspond to the style guidelines?
Thanks!
Kind regards, Maren
Message from Sylvain:
Hello everybody,
There were previously code examples on the page of the website about the coding style. These were removed when a highlighter plugin was removed from the CMS. We could get them back from a backup but I restored the format myself as it was encoded (with \r\n instead of line endings and many spaces had run away). Could you please check that the 3 codes are really conformant to the coding style, then correct errors or describe them? The codes are only on the French version of the page; I will add them on the English version when we will be sure they are good.
https://inkscape.org/fr/developper/style-du-code-source/
Note: I am not on the inkscape-devel mailing list, remember to keep me as a receiver of mails about this topic. -- Sylvain
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/ gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Am 09.04.2016 um 23:21 schrieb Martin Owens:
I'm not an expert on the code style, but they look good to me Maren.
Thanks a lot, Martin!!!
On 9 April 2016 at 17:01, Maren Hachmann <maren@...3165...> wrote:
Please, could someone just take a short look? It's not a huge amount of code, and I'd like to get this done while I can...
So:
Do the given code examples here: https://inkscape.org/fr/developper/style-du-code-source/
correspond to the style guidelines after we have salvaged them from the backups and re-formatted them?
Thanks!
Kind regards, Maren
Am 05.04.2016 um 12:11 schrieb Maren Hachmann:
Hi everyone,
I'm forwarding this message from Sylvain (website contributor, French translator), which bounced when he tried to send it to the devel mailing list. Could someone please double-check if the salvaged code examples on the website correspond to the style guidelines?
Thanks!
Kind regards, Maren
Message from Sylvain:
Hello everybody,
There were previously code examples on the page of the website about the coding style. These were removed when a highlighter plugin was removed from the CMS. We could get them back from a backup but I restored the format myself as it was encoded (with \r\n instead of line endings and many spaces had run away). Could you please check that the 3 codes are really conformant to the coding style, then correct errors or describe them? The codes are only on the French version of the page; I will add them on the English version when we will be sure they are good.
https://inkscape.org/fr/developper/style-du-code-source/
Note: I am not on the inkscape-devel mailing list, remember to keep me as a receiver of mails about this topic. -- Sylvain
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/ gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
I agree, the examples look OK.
2016-04-09 14:01 GMT-07:00 Maren Hachmann <maren@...3165...>:
Please, could someone just take a short look? It's not a huge amount of code, and I'd like to get this done while I can...
So:
Do the given code examples here: https://inkscape.org/fr/developper/style-du-code-source/
correspond to the style guidelines after we have salvaged them from the backups and re-formatted them?
Thanks!
Kind regards, Maren
Am 05.04.2016 um 12:11 schrieb Maren Hachmann:
Hi everyone,
I'm forwarding this message from Sylvain (website contributor, French translator), which bounced when he tried to send it to the devel mailing list. Could someone please double-check if the salvaged code examples on the website correspond to the style guidelines?
Thanks!
Kind regards, Maren
Message from Sylvain:
Hello everybody,
There were previously code examples on the page of the website about the coding style. These were removed when a highlighter plugin was removed from the CMS. We could get them back from a backup but I restored the format myself as it was encoded (with \r\n instead of line endings and many spaces had run away). Could you please check that the 3 codes are really conformant to the coding style, then correct errors or describe them? The codes are only on the French version of the page; I will add them on the English version when we will be sure they are good.
https://inkscape.org/fr/developper/style-du-code-source/
Note: I am not on the inkscape-devel mailing list, remember to keep me as a receiver of mails about this topic. -- Sylvain
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/ gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Am 10.04.2016 um 00:17 schrieb Krzysztof Kosiński:
I agree, the examples look OK.
Thank you, Krzysztof!
2016-04-09 14:01 GMT-07:00 Maren Hachmann <maren@...3165...>:
Please, could someone just take a short look? It's not a huge amount of code, and I'd like to get this done while I can...
So:
Do the given code examples here: https://inkscape.org/fr/developper/style-du-code-source/
correspond to the style guidelines after we have salvaged them from the backups and re-formatted them?
Thanks!
Kind regards, Maren
participants (3)
-
Krzysztof Kosiński -
Maren Hachmann -
Martin Owens