I just committed the layers dialog UI based on the Layer Manager that Mental had done.
We know there are some compile issues with sigc++ up to 2.0.10 and gcc 4.0.x. We think that by sigc++ 2.0.16 things were corrected in sigc++, as an autopackage build using that worked on a box where the base build failed.
For me, I'm using sigc++ 2.0.11 and gcc 3.3 and all is happy-happy.
Known issues:
* gcc 4.0 compile problems * plain checkboxes instead of little eye and lock icons * layers not listed in proper order
The order issue is coming from something in the layer manager itself, and the UI stuff in the layers dialog is properly displaying what it's been told. I figure that's a short debug session on the ordering in the layer manager itself. Thus it's a minor bug.
The order issue is coming from something in the layer manager itself, and the UI stuff in the layers dialog is properly displaying what it's been told. I figure that's a short debug session on the ordering in the layer manager itself. Thus it's a minor bug.
I'm pretty sure the actual bug is in Inkscape::DocumentSubset.
I'll see if I can upgrade my version of sigc++ to work on this, but in the meantime any debugging work you might care to do on it would be appreciated.
-mental
On May 15, 2006, at 8:40 AM, MenTaLguY wrote:
The order issue is coming from something in the layer manager itself, and the UI stuff in the layers dialog is properly displaying what it's been told. I figure that's a short debug session on the ordering in the layer manager itself. Thus it's a minor bug.
I'm pretty sure the actual bug is in Inkscape::DocumentSubset.
I'll see if I can upgrade my version of sigc++ to work on this, but in the meantime any debugging work you might care to do on it would be appreciated.
Yes, it is.
I should be able to knock it down later tonight. (I've already chased things to at least their main areas in addOne() )
Incidentally, how do you feel about DocumentSubset's interface? I know there's the issue with overly broad change notifications, but are there any other annoyances/wishes you have?
I haven't had to write a class to do exactly this sort of thing before, so I'm just feeling my way along towards a reasonably humane API...
-mental
On May 15, 2006, at 8:40 AM, MenTaLguY wrote:
The order issue is coming from something in the layer manager itself, and the UI stuff in the layers dialog is properly displaying what it's been told. I figure that's a short debug session on the ordering in the layer manager itself. Thus it's a minor bug.
I'm pretty sure the actual bug is in Inkscape::DocumentSubset.
I'll see if I can upgrade my version of sigc++ to work on this, but in the meantime any debugging work you might care to do on it would be appreciated.
I've got it fixed now.
The one thing is that DocumentSubset is now building things up in document order. Since that's generally what's needed for arbitrary subsets, that's what I'm leaving.
However, that means that the list in the tree control needs to be flipped. That's a user-interface choice, and so appropriately belongs in layers-panel.cpp. I'll be able to flip that tonight.
Wow, one more. You'll kill us with those new stuffs ;)
Some proposals : The most important here to notice for the user is the layer name. That was helps him to point at one layer. It could be more visible. This could be done by filling Checkboxes with white so that they should be more integrated to the background and replace column labels with icons. see attached file.
Or best, because it is hard to remember which column does what, replace check boxes with icons themselves, as it is done in gimp.
But i don't know how it is feasible ;) and if you agree with that.
btw, crashes when multiselecting layers. Bug reported.
pygmee
On May 15, 2006, at 1:23 PM, cedric GEMY wrote:
Wow, one more. You'll kill us with those new stuffs ;)
Some proposals : The most important here to notice for the user is the layer name. That was helps him to point at one layer. It could be more visible. This could be done by filling Checkboxes with white so that they should be more integrated to the background and replace column labels with icons. see attached file.
Or best, because it is hard to remember which column does what, replace check boxes with icons themselves, as it is done in gimp.
But i don't know how it is feasible ;) and if you agree with that.
It's mainly a matter of wiring in a new CellRenderer for them. We didn't have one already kicking around, so I'll have to write up the code for it. However, I imagine that it will make many things nicer in the UI in the future, so it's well worth the bit of work.
btw, crashes when multiselecting layers. Bug reported.
Thanks.
I'd checked for multiple selection issues before, but not since finishing the rest.
Jon A. Cruz a écrit :
I just committed the layers dialog UI based on the Layer Manager that Mental had done.
I use a different build directory than my local source source tree (as written at the end of http://wiki.inkscape.org/wiki/index.php/CompilingInkscape), but an include in src/dialogs/layers-panel.cpp generates an error... So here's my tiny diff to make it compile even if not in the source directory.
mtou
Index: src/dialogs/layers-panel.cpp =================================================================== --- src/dialogs/layers-panel.cpp (r��vision 11806) +++ src/dialogs/layers-panel.cpp (copie de travail) @@ -24,7 +24,7 @@ #include "desktop.h" #include "sp-object.h" #include "sp-item.h" -#include "src/widgets/icon.h" +#include "widgets/icon.h" #include <gtkmm/widget.h>
//#define DUMP_LAYERS 1
On Tue, 16 May 2006, Mathieu Dimanche wrote:
Jon A. Cruz a écrit :
I just committed the layers dialog UI based on the Layer Manager that Mental had done.
I use a different build directory than my local source source tree (as written at the end of http://wiki.inkscape.org/wiki/index.php/CompilingInkscape), but an include in src/dialogs/layers-panel.cpp generates an error... So here's my tiny diff to make it compile even if not in the source directory.
Commited.
Cheers, Michael
participants (5)
-
cedric GEMY -
Jon A. Cruz -
Mathieu Dimanche -
MenTaLguY -
Michael Wybrow