Due to a recent compile error, I have found the following in fixed.cpp:
/* * until 2004-04-22, g_ascii_strtod could not handle having a locale-based * decimal separator immediately following the number ("5,4" would * parse to "5,4" instead of "5.0" in fr_FR) * * This is the corrected function, lifted from 1.107 gstrfuncs.c in glib */
It defines a function fixed_g_ascii_strtod and config.h defines a macro to point g_ascii_strtod to fixed_g_ascii_strtod. Perhaps it is ok now to purge the fixed function from our code and use the normal function? (trying to build now with "#define g_ascii_strtod fixed_g_ascii_strtod" commented out, but since that'll take a while a decided to already mail this)
Cheers, Johan
On 2/18/07, J.B.C.Engelen@...1578... <J.B.C.Engelen@...1578...> wrote:
It defines a function fixed_g_ascii_strtod and config.h defines a macro to point g_ascii_strtod to fixed_g_ascii_strtod. Perhaps it is ok now to purge the fixed function from our code and use the normal function?
Sounds like 2004 is too long ago to care about it anymore. If it's commented out anyway (i.e. removing it won't change anything?) I'd say go on.
Bulia wrote:
On 2/18/07, J.B.C.Engelen@...1578... <J.B.C.Engelen@...1578...> wrote:
It defines a function fixed_g_ascii_strtod and config.h
defines a macro to point g_ascii_strtod to fixed_g_ascii_strtod.
Perhaps it is ok now to purge the fixed function from our
code and use the normal function?
Sounds like 2004 is too long ago to care about it anymore. If it's commented out anyway (i.e. removing it won't change anything?) I'd say go on.
The function is not commented out at this moment, so removal would change stuff. Commenting it out will mean: instead of using our own fixed_ function we will start using the function as provided by glib.
On 2/18/07, J.B.C.Engelen@...1578... <J.B.C.Engelen@...1578...> wrote:
The function is not commented out at this moment, so removal would change stuff. Commenting it out will mean: instead of using our own fixed_ function we will start using the function as provided by glib.
Then you can try it but ask people with non-english locales to watch out for any problems.
On Sun, Feb 18, 2007 at 04:01:02PM +0100, J.B.C.Engelen@...1578... wrote:
Due to a recent compile error, I have found the following in fixed.cpp:
/*
- until 2004-04-22, g_ascii_strtod could not handle having a locale-based
- decimal separator immediately following the number ("5,4" would
- parse to "5,4" instead of "5.0" in fr_FR)
- This is the corrected function, lifted from 1.107 gstrfuncs.c in glib
*/
It defines a function fixed_g_ascii_strtod and config.h defines a macro to point g_ascii_strtod to fixed_g_ascii_strtod. Perhaps it is ok now to purge the fixed function from our code and use the normal function? (trying to build now with "#define g_ascii_strtod fixed_g_ascii_strtod" commented out, but since that'll take a while a decided to already mail this)
This should already be gone from the builds. I fixed this prior to 0.45 releasing:
r13708 | keescook | 2007-01-12 19:07:14 -0800 (Fri, 12 Jan 2007) | 1 line drop unneeded ascii fix, breaking tests
http://inkscape.svn.sourceforge.net/viewvc/inkscape/inkscape/trunk/configure...
Oooh, I see; it's in the Window build still. I should have pulled the entire function out of fixes.cpp. :( I've ifdef'd it totally out now, so any other stragglers should be caught.
participants (3)
-
unknown＠example.com -
bulia byak -
Kees Cook