Hello all,
Because an (what I thought) important Inkscape-devel 'paradigm' is no longer valid, there are a lot of bugs concerning dockable dialogs: I am talking about having only a single instance of dialogs. Most widgets that I use (the Registered* widgets) are not designed to be managed by others than the creator I think. (like Gtk::Widget is, by using Gtk::manage)
It causes for example this bug: https://bugs.launchpad.net/inkscape/+bug/179982
How are we going to solve this for 0.46?
Regards, Johan
On Wed, 9 Jan 2008 01:57:37 +0100 J.B.C.Engelen@...1578... wrote:
Hello all,
Because an (what I thought) important Inkscape-devel 'paradigm' is no longer valid, there are a lot of bugs concerning dockable dialogs: I am talking about having only a single instance of dialogs.
Hi, sorry for the delay...
The reason it was changed is that the single dialog "paradigm" is harder to apply for dockable dialogs. A dockable dialog is more closely tied to its document than a floating dialog.
For example, how would singleton docked dialogs work with multiple documents? Unless the docked dialogs can "move" with the focus of the document, the user can end up with dialogs docked in one document that control a selection in another document, and that's confusing. I agree that the current solution is not perfect as multiple undocked dialogs can be confusing too, but I'm not really sure what a perfect solution would be.
(By the way, the single instance paradigm is still used if the Floating dialogs behavior is chosen.)
Most widgets that I use (the Registered* widgets) are not designed to be managed by others than the creator I think. (like Gtk::Widget is, by using Gtk::manage)
It causes for example this bug: https://bugs.launchpad.net/inkscape/+bug/179982
How are we going to solve this for 0.46?
I wasn't aware of those problems, sorry. I'm going to look into that...
-- Gustav
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of Gustav Broberg Sent: maandag 14 januari 2008 20:48 To: inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Dockable dialog bugs
On Wed, 9 Jan 2008 01:57:37 +0100 J.B.C.Engelen@...1578... wrote:
Hello all,
Because an (what I thought) important Inkscape-devel
'paradigm' is no
longer valid, there are a lot of bugs concerning dockable
dialogs: I
am talking about having only a single instance of dialogs.
Hi, sorry for the delay...
The reason it was changed is that the single dialog "paradigm" is harder to apply for dockable dialogs. A dockable dialog is more closely tied to its document than a floating dialog.
For example, how would singleton docked dialogs work with multiple documents? Unless the docked dialogs can "move" with the focus of the document, the user can end up with dialogs docked in one document that control a selection in another document, and that's confusing. I agree that the current solution is not perfect as multiple undocked dialogs can be confusing too, but I'm not really sure what a perfect solution would be.
(By the way, the single instance paradigm is still used if the Floating dialogs behavior is chosen.)
Sry I was unclear. The dockable dialogs are good and nice to have! I did not mean to maintain the 'paradigm', just stating that I thought it was there. (plus that I never liked the paradigm, nor the RegisteredWidgets classes)
Most widgets that I use (the Registered* widgets) are not
designed to
be managed by others than the creator I think. (like
Gtk::Widget is,
by using Gtk::manage)
It causes for example this bug: https://bugs.launchpad.net/inkscape/+bug/179982
How are we going to solve this for 0.46?
I wasn't aware of those problems, sorry. I'm going to look into that...
I am affraid there are several bugs :( and it is not easy to fix without making new bugs I am affraid. It would help a lot when registered* widgets are subclassed from Gtk::Widget, and rewrite implementations. Then we can just gtk::manage(new Registered* ) things.
Simple solution is to disable docking for the dialogs that are bugged: LPE and document properties that I know of.
Cheers, And thanks for the much requested (by myself aswell) dockable dialogs :) Johan
I just committed changes to LPE's parameter system to work better with multiple dialogs. For each function that needs re-implementing, a warning is issued when it is called. Now work has to focus on making registered widgets work with multiple owners.
Regards, Johan
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of J.B.C.Engelen@...1578... Sent: maandag 14 januari 2008 21:48 To: broberg@...370...; inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Dockable dialog bugs
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of Gustav Broberg Sent: maandag 14 januari 2008 20:48 To: inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Dockable dialog bugs
On Wed, 9 Jan 2008 01:57:37 +0100 J.B.C.Engelen@...1578... wrote:
Hello all,
Because an (what I thought) important Inkscape-devel
'paradigm' is no
longer valid, there are a lot of bugs concerning dockable
dialogs: I
am talking about having only a single instance of dialogs.
Hi, sorry for the delay...
The reason it was changed is that the single dialog "paradigm" is harder to apply for dockable dialogs. A dockable dialog is more closely tied to its document than a floating dialog.
For example, how would singleton docked dialogs work with multiple documents? Unless the docked dialogs can "move" with the
focus of the
document, the user can end up with dialogs docked in one
document that
control a selection in another document, and that's
confusing. I agree
that the current solution is not perfect as multiple
undocked dialogs
can be confusing too, but I'm not really sure what a
perfect solution
would be.
(By the way, the single instance paradigm is still used if the Floating dialogs behavior is chosen.)
Sry I was unclear. The dockable dialogs are good and nice to have! I did not mean to maintain the 'paradigm', just stating that I thought it was there. (plus that I never liked the paradigm, nor the RegisteredWidgets classes)
Most widgets that I use (the Registered* widgets) are not
designed to
be managed by others than the creator I think. (like
Gtk::Widget is,
by using Gtk::manage)
It causes for example this bug: https://bugs.launchpad.net/inkscape/+bug/179982
How are we going to solve this for 0.46?
I wasn't aware of those problems, sorry. I'm going to look into that...
I am affraid there are several bugs :( and it is not easy to fix without making new bugs I am affraid. It would help a lot when registered* widgets are subclassed from Gtk::Widget, and rewrite implementations. Then we can just gtk::manage(new Registered* ) things.
Simple solution is to disable docking for the dialogs that are bugged: LPE and document properties that I know of.
Cheers, And thanks for the much requested (by myself aswell) dockable dialogs :) Johan
Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.n
et/marketplace
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
OK, I just came up with a solution for our problems and tested it on one of the parameter types. This seems to work very very nicely and can be generalized to all "registered widgets". I will try to do this asap.
So please do not work on registeredwidgets!
Johan
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of J.B.C.Engelen@...1578... Sent: dinsdag 15 januari 2008 15:31 To: broberg@...370...; inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Dockable dialog bugs
I just committed changes to LPE's parameter system to work better with multiple dialogs. For each function that needs re-implementing, a warning is issued when it is called. Now work has to focus on making registered widgets work with multiple owners.
Regards, Johan
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of J.B.C.Engelen@...1578... Sent: maandag 14 januari 2008 21:48 To: broberg@...370...; inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Dockable dialog bugs
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On
Behalf Of
Gustav Broberg Sent: maandag 14 januari 2008 20:48 To: inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Dockable dialog bugs
On Wed, 9 Jan 2008 01:57:37 +0100 J.B.C.Engelen@...1578... wrote:
Hello all,
Because an (what I thought) important Inkscape-devel
'paradigm' is no
longer valid, there are a lot of bugs concerning dockable
dialogs: I
am talking about having only a single instance of dialogs.
Hi, sorry for the delay...
The reason it was changed is that the single dialog "paradigm" is harder to apply for dockable dialogs. A dockable dialog is more closely tied to its document than a floating dialog.
For example, how would singleton docked dialogs work with
multiple
documents? Unless the docked dialogs can "move" with the
focus of the
document, the user can end up with dialogs docked in one
document that
control a selection in another document, and that's
confusing. I agree
that the current solution is not perfect as multiple
undocked dialogs
can be confusing too, but I'm not really sure what a
perfect solution
would be.
(By the way, the single instance paradigm is still used if the Floating dialogs behavior is chosen.)
Sry I was unclear. The dockable dialogs are good and nice
to have! I
did not mean to maintain the 'paradigm', just stating that
I thought
it was there. (plus that I never liked the paradigm, nor the RegisteredWidgets classes)
Most widgets that I use (the Registered* widgets) are not
designed to
be managed by others than the creator I think. (like
Gtk::Widget is,
by using Gtk::manage)
It causes for example this bug: https://bugs.launchpad.net/inkscape/+bug/179982
How are we going to solve this for 0.46?
I wasn't aware of those problems, sorry. I'm going to look into that...
I am affraid there are several bugs :( and it is not easy to fix without making new bugs I am affraid. It would help a lot when registered* widgets are subclassed from Gtk::Widget, and rewrite implementations. Then we can just gtk::manage(new Registered* ) things.
Simple solution is to disable docking for the dialogs that
are bugged:
LPE and document properties that I know of.
Cheers, And thanks for the much requested (by myself aswell)
dockable dialogs
:) Johan
Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.n
et/marketplace
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Tue, 15 Jan 2008 17:17:45 +0100 J.B.C.Engelen@...1578... wrote:
OK, I just came up with a solution for our problems and tested it on one of the parameter types. This seems to work very very nicely and can be generalized to all "registered widgets". I will try to do this asap.
That's great news Johan! After your changes I'm not able to reproduce #179982 anymore.
I'm not familiar enough with the registered widgets to evaluate the class design, but just looking diffs themselves, I can't see any problems with it. One minor nit though, couldn't the static cast line in RegisterRandom::setValue be replaced with just "Scalar::setValue (val);"?.
Do you think you'll be able to rewrite the remaining widgets and completely deprecate the old RegisteredWdg in time for the release?
Just tell me if I should prepare a Plan B, e.g. to make just the Document Properties and LPE dialog singleton as you suggested...
-- Gustav
participants (2)
-
unknown＠example.com -
Gustav Broberg