11:10 p.m.
Hi,
Here are several more notes on current implementation of raster effects.
1. Terminology and hints. In some cases terminology used in effects
coming from ImageMagick is not quite obvious. For instance, you might
want to reread a course on math to understand what "Sigma" stands for
in "Sharpen"/"Unsharp Mask" effects ;-) We might either rename some
of
the labels (not good for experienced ImageMagick users) or provide
hints to explain the meaning of each option.
2. Raster effects are not the only ones to suffer from it, but here
goes: effect dialogs inherit caption from menu item name. In several
cases the caption is too long and is shrinked. This is not quite
visually appealing. Two solutions comes to mind: 1) automatically
resize dialog to match caption's length and 2) provide a separate
string to dialog's caption which translators could try to make
smaller.
3. Cancelling isn't working reliably. I run "Reduce noise" on a
2200x1500 picture and when I click "Cancel" nothing really happens.
4.Should we probbaly implement a "Resize" effect too?
Alexandre
1:53 a.m.
On 10/13/07, Alexandre Prokoudine <alexandre.prokoudine@...400...> wrote:
1. Terminology and hints. In some cases terminology used in effects
coming from ImageMagick is not quite obvious. For instance, you might
want to reread a course on math to understand what "Sigma" stands for
in "Sharpen"/"Unsharp Mask" effects ;-) We might either rename some
of
the labels (not good for experienced ImageMagick users) or provide
hints to explain the meaning of each option.
Or, best of all, both.
As a Gimp translator who knows all this stuff, will you mind
submitting a patch for this?
2. Raster effects are not the only ones to suffer from it, but here
goes: effect dialogs inherit caption from menu item name. In several
cases the caption is too long and is shrinked. This is not quite
visually appealing. Two solutions comes to mind: 1) automatically
resize dialog to match caption's length and 2) provide a separate
string to dialog's caption which translators could try to make
smaller.
2 is better of course
3. Cancelling isn't working reliably. I run "Reduce
noise" on a
2200x1500 picture and when I click "Cancel" nothing really happens.
Ted, can you comment on that? (and btw, have we agreed to eliminate
the "pin" checkbox? Are you working on that?)
4.Should we probbaly implement a "Resize" effect too?
There's a patch for Resample, not yet committed.
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org
1:32 a.m.
On Sat, 2007-10-13 at 12:53 -0400, bulia byak wrote:
> 2. Raster effects are not the only ones to suffer from it, but
here
> goes: effect dialogs inherit caption from menu item name. In several
> cases the caption is too long and is shrinked. This is not quite
> visually appealing. Two solutions comes to mind: 1) automatically
> resize dialog to match caption's length and 2) provide a separate
> string to dialog's caption which translators could try to make
> smaller.
2 is better of course
Maybe I'm a little confused; this isn't a translation issue, right? We
need the shorter string in English too? So we're suggesting adding
another entry to the INX file for Window title?
> 3. Cancelling isn't working reliably. I run "Reduce
noise" on a
> 2200x1500 picture and when I click "Cancel" nothing really happens.
Ted, can you comment on that? (and btw, have we agreed to eliminate
the "pin" checkbox? Are you working on that?)
I'm curious about it. I'm restructuring the code a little bit to make
it cleaner -- which may in turn fix this. I'll put it on my list of
things to check to ensure the new code works.
We haven't agreed do remove the pin dialog checkbox. I wanted to get
some of the internal stuff fixed, then go back to that. I'm still not
convinced that everything should be floating palettes, especially the
effects. But, I don't think that the export dialog should be either for
most people. Yes, for people who export things regularly, or several
PNGs of different areas -- but for me, it's just an extra click on a
simple operation.
--Ted
2:35 a.m.
On 10/15/07, Ted Gould <ted@...11...> wrote:
We haven't agreed do remove the pin dialog checkbox. I wanted to
get
some of the internal stuff fixed, then go back to that. I'm still not
convinced that everything should be floating palettes, especially the
effects. But, I don't think that the export dialog should be either for
most people. Yes, for people who export things regularly, or several
PNGs of different areas -- but for me, it's just an extra click on a
simple operation.
Removing "pin" has nothing to do with this. It's just a matter of
changing the UI so it makes sense. If the difference between
fire-and-close and always-on is what holds you back, again, I agree to
make it a preference setting (affecting both effects and Export
dialogs).
When "Dialogs for Export and extension effects stay open after Apply"
in prefs is on (default), the behavior is:
Replace close/ok/execute buttons with two
buttons: Apply and Close (in that order). Remove "pin" checkbox. When
live preview is off, make dialog non-modal and allow to change
selection at any time; Apply would then just apply to the current
selection but not close. When live preview is on, dialog is modal, but
you can preview the effect of parameters on the current selection; and
when you click Apply it not only applies the effect but _also_ unsets
the Live preview, unlocking the dialog to enable new selections.
When it's off, the behavior is:
Replace close/ok/execute buttons with two
buttons: Cancel and OK (in that order). Remove "pin" checkbox. When
live preview is off, make dialog non-modal and allow to change
selection at any time; OK would then just apply to the current
selection and close. When live preview is on, dialog is modal, but
you can preview the effect of parameters on the current selection; and
when you click OK it applies the effect and closes the dialog. The
status of Live preview is remembered per dialog.
Are we finally in agreement on the above?
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org
6:13 p.m.
Ted,
I noticed you made some changes to the effects UI, and I tested them.
Here are the problems I found. I think they are quite serious,
especially the crash, and must be fixed before the release, so I also
made a critical bug https://bugs.launchpad.net/inkscape/+bug/191772
On Oct 15, 2007 1:35 PM, bulia byak <buliabyak@...400...> wrote:
When "Dialogs for Export and extension effects stay open after
Apply"
in prefs is on (default), the behavior is:
I didn't find this setting - did you find it? I assume it work as if
it's on, as the default should be.
Replace close/ok/execute buttons with two
buttons: Apply and Close (in that order). Remove "pin" checkbox. When
live preview is off, make dialog non-modal and allow to change
selection at any time; Apply would then just apply to the current
selection but not close.
This is correctly done, but the button says OK, not Apply. This is
misleading - can you please rename it to Apply?
Bug: if I use Close button to close dialog, I can then open the same
extension dialog again. But if I just click the X button in the title
bar, next attempt to call the extension does nothing - the window does
not show (linux, kde). Only restarting the program fixes this.
When live preview is on, dialog is modal, but
you can preview the effect of parameters on the current selection; and
when you click Apply it not only applies the effect but _also_ unsets
the Live preview, unlocking the dialog to enable new selections.
This does not quite work. I check preview box, and it starts to
preview, but pressing OK does not uncheck it. Moreover, now even Close
does not close the dialog! Only the titlebar button closes it, after
which it cannot be open again (see bug above).
Worst bug of all: do this:
- launch
- draw a path with pencil
- effects/modify path/add nodes
- turn on preview checkbox
- click close (it does not)
- click preview checkbox again - crash:
** (inkscape:14033): CRITICAL **: void
Inkscape::GC::Anchored::release() const: assertion `_anchor' failed
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1235330848 (LWP 14033)]
IA__g_main_loop_quit (loop=0x2f656c61) at gmain.c:2920
2920 g_return_if_fail (g_atomic_int_get (&loop->ref_count) > 0);
(gdb) bt
#0 IA__g_main_loop_quit (loop=0x2f656c61) at gmain.c:2920
#1 0xb7c00a17 in Glib::MainLoop::quit (this=0xb75648ef) at main.cc:614
#2 0x0850a1cc in Inkscape::Extension::ExecutionEnv::livePreview
(this=0xad28d30, state=false)
at extension/execution-env.cpp:302
#3 0x0850bc35 in Inkscape::Extension::PrefDialog::preview_toggle
(this=0xa7d90a8)
at extension/prefdialog.cpp:161
#4 0x08500ac4 in Inkscape::Extension::ParamBoolCheckButton::on_toggle
(this=0xac638b0) at signal.h:544
#5 0xb7c05986 in Glib::SignalProxyNormal::slot0_void_callback
(self=0xb75648ef, data=0xaabf3f8)
at slot.h:440
#6 0xb7776e33 in IA__g_cclosure_marshal_VOID__VOID
(closure=0xaabf428, return_value=0x0, n_param_values=1,
param_values=0xbfae3e7c, invocation_hint=0xbfae3d6c,
marshal_data=0x8082770) at gmarshal.c:77
#7 0xb776af6f in IA__g_closure_invoke (closure=0xaabf428,
return_value=0xb75648ef,
n_param_values=3075885295, param_values=0xb75648ef,
invocation_hint=0xb75648ef) at gclosure.c:490
#8 0xb777a22c in signal_emit_unlocked_R (node=0x9246468, detail=0,
instance=0x95c5008, emission_return=0x0,
instance_and_params=0xbfae3e7c) at gsignal.c:2510
#9 0xb777b559 in IA__g_signal_emit_valist (instance=0x95c5008,
signal_id=139, detail=0,
var_args=<value optimized out>) at gsignal.c:2199
#10 0xb777b8c9 in IA__g_signal_emit (instance=0xb75648ef,
signal_id=3075885295, detail=3075885295)
at gsignal.c:2243
#11 0xb7a85421 in IA__gtk_toggle_button_toggled
(toggle_button=0x95c5008) at gtktogglebutton.c:305
#12 0xb7a857be in gtk_toggle_button_clicked (button=0x95c5008) at
gtktogglebutton.c:438
#13 0xb7e3a031 in Gtk::Button::on_clicked (this=0xac638b0) at button.cc:758
#14 0xb7e3904d in Gtk::Button_Class::clicked_callback (self=0x95c5008)
at button.cc:268
#15 0xb7776e33 in IA__g_cclosure_marshal_VOID__VOID
(closure=0x8d64330, return_value=0x0, n_param_values=1,
param_values=0xbfae43ec, invocation_hint=0xbfae42dc,
marshal_data=0xb7e38fc2) at gmarshal.c:77
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org
5587
days inactive
5711
days old
inkscape-devel@lists.inkscape.org
5 comments
3 participants
participants (3)
-
Alexandre Prokoudine -
bulia byak -
Ted Gould