Fix for LP 273767; was: Re: [Patch] Fix for LP 402274
Joshua, release warden, I do not have "the" solution for https://bugs.launchpad.net/inkscape/+bug/273767 But I have a fix in post #6 of this issue that might prevent further crashing by range overflow. The other one has a deeper impact in everything so I can not judge how it behaves on the other end.
PLs review the first patch and commit.
I agree to concentrate on release critical issues. so please summarise what is still open. And what has to be done.
Thanks, Adib.
On 10/4/09, Joshua A. Andler <scislac@...400...> wrote:
On Sun, 2009-10-04 at 15:58 +0100, Richard Hughes wrote:
- Open file
- On the second line of text in the red box, select "RIA · MEL".
- Change the font size
The black is then stripped from all of the black text on that line (even the stuff not selected).
Well, you've certainly opened up a can of worms here. Attached are three independent patches:
That's what I do. ;)
Looks like it's time for the release wardens to make some hard decisions. If you need any more information on the possible impact of each patch, please ask.
I think that the patches read safe, but obviously the can I opened up was on more of an edge case (at least that's how it appears). I'm not sure that it's worth potentially breaking more so close to a release, then again, what do you think Richard? What is the possible impact of the 2nd and 3rd patches?
I will definitely commit the first patch for the release (one less crash, yay!). If you don't think it's worth chancing so close to release, the other 2 can just go in after trunk opens back up (obviously safest option). However, if you feel that it really fixes a deeper issue that we just weren't aware of and the risks aren't terribly high, I will defer to you in this area. As mentioned before, I'm willing to do a .1 for 0.47 (just would prefer not to).
Cheers, Josh
Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Adib,
Thanks for the clarification, I was waiting on the other issue you mentioned to be fixed too. I went ahead and committed in 22391 and will leave the rest to you to commit post-release.
The last thing that MUST get sorted is: https://bugs.edge.launchpad.net/inkscape/+bug/437929
I do not have an offending preferences file, nor do I know if anyone has one readily available. Jon has talked to users who have had issues, so I filed it on his behalf while he was doing other bug fixing. I will be honest, the more eyes and minds we have on this, the better (I'd really like to cut a final release in a couple weeks)
Cheers, Josh
On Sun, 2009-10-04 at 22:47 +0200, the Adib wrote:
Joshua, release warden, I do not have "the" solution for https://bugs.launchpad.net/inkscape/+bug/273767 But I have a fix in post #6 of this issue that might prevent further crashing by range overflow. The other one has a deeper impact in everything so I can not judge how it behaves on the other end.
PLs review the first patch and commit.
I agree to concentrate on release critical issues. so please summarise what is still open. And what has to be done.
Thanks, Adib.
On 10/4/09, Joshua A. Andler <scislac@...400...> wrote:
On Sun, 2009-10-04 at 15:58 +0100, Richard Hughes wrote:
- Open file
- On the second line of text in the red box, select "RIA · MEL".
- Change the font size
The black is then stripped from all of the black text on that line (even the stuff not selected).
Well, you've certainly opened up a can of worms here. Attached are three independent patches:
That's what I do. ;)
Looks like it's time for the release wardens to make some hard decisions. If you need any more information on the possible impact of each patch, please ask.
I think that the patches read safe, but obviously the can I opened up was on more of an edge case (at least that's how it appears). I'm not sure that it's worth potentially breaking more so close to a release, then again, what do you think Richard? What is the possible impact of the 2nd and 3rd patches?
I will definitely commit the first patch for the release (one less crash, yay!). If you don't think it's worth chancing so close to release, the other 2 can just go in after trunk opens back up (obviously safest option). However, if you feel that it really fixes a deeper issue that we just weren't aware of and the risks aren't terribly high, I will defer to you in this area. As mentioned before, I'm willing to do a .1 for 0.47 (just would prefer not to).
Cheers, Josh
Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 4/10/09 23:12, Joshua A. Andler wrote:
The last thing that MUST get sorted is: https://bugs.edge.launchpad.net/inkscape/+bug/437929
I do not have an offending preferences file, nor do I know if anyone has one readily available. Jon has talked to users who have had issues, so I filed it on his behalf while he was doing other bug fixing. I will be honest, the more eyes and minds we have on this, the better (I'd really like to cut a final release in a couple weeks)
ATM I can't remember a bug report that pointed to such a conflict - the one about numeric precision is limited to users that tested prerelease versions (AFAIK this pref was added after 0.46) - see previous thread "Inkscape SVN crashes on startup" from Sat, 3 Oct 2009.
I have a minor issue that 0.46 again and again deletes my 'Open Recent' file list of 0.47pre, but that's hardly a blocker... just annoying ;-)
console messages from 0.46:
(inkscape-bin:16834): Gtk-WARNING **: Attempting to read the recently used resources file at `/Users/suv/.recently-used.xbel', but the parser failed: Unexpected attribute 'modified' for element 'application'. (inkscape-bin:16834): GLib-CRITICAL **: g_bookmark_file_get_size: assertion `bookmark != NULL' failed (inkscape-bin:16834): Gtk-CRITICAL **: gtk_file_system_unix_get_info: assertion `g_path_is_absolute (filename)' failed
~suv
p.s. (just grep'ed my 0.46 preferences.xml for 'precision' - 'numericprecision="8"' already exists in 0.46, but I found no GUI for it. Still, if a user manually had lowered that value to 1 or 2 and the pref file gets fully 'migrated' - current versions crash at startup. The underlying issue of bug #399604 is not fixed in SVN, but now the user no longer can enter a value lower than 3 in the GUI)
participants (3)
-
Joshua A. Andler -
the Adib -
~suv