Hi, I have recently uploaded a patch[1] which provides an undo history dialog. It is similar to those found in e.g. GIMP[2] and Photoshop[3] (I don't know if it's in Illustrator, CorelDRAW, etc). To get an idea what it looks like without having to apply the patch, here's a screencast (in flash, sorry ;) showing it in action: http://www.csc.kth.se/~broberg/undo-history.html First of all, I'm not sure if this is a requested addition to Inkscape -- I can't recall any discussion about it on the list and I didn't find anything in the wiki. Personally, however, I do find it useful (at least occasionally), so I went ahead and implemented it. Secondly (if it's found to be of value), this patch could use some rather heavy reviewing. It's my first patch and I'm not confident enough with the code base to feel sure about what the "right" solutions are. Here are some additional concerns: * To get the type of an event I rely entirely on the current event context. This obviously not (always) a correct assumption. An example of this problem: setting an object's color while the node tool is the current context. * In order to populate the tree with icons I added a help function to widget/icon.cpp to get the internal Pixbuf of an icon. This could be solved in much a better way when the gktmmified stock icon system is in place, but for now, this was easiest way for me to solve it. * There are bugs lurking which I have not been able to reproduce. Some seem to be the result of problems with undoing of certain types of events; i.e. the bugs are in the current code. I'm looking into this... For now, here is at least one I managed to nail down and put in the tracker: http://sourceforge.net/tracker/index.php?func=detail&aid=1423038&... 1. http://sourceforge.net/tracker/index.php?func=detail&aid=1423034&...) 2. http://docs.gimp.org/images/dialogs/dialogs-undo-history.png 3. http://homepage.cs.uri.edu/tutorials/PhotoshopEl/Help/images/wa_11.gif -- Gustav Broberg ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&... _______________________________________________ Inkscape-devel mailing list Inkscape-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel

> * To get the type of an event I rely entirely on the current > event context. This obviously not (always) a correct > assumption. An example of this problem: setting an object's > color while the node tool is the current context. Probably we'll need to add an extra argument to sp_document_done() to help you out with this.

To the list: I'll not have time to review the patch today ... someone else want to do the honors? I'd like to see this get into the tree in some form.

On 2/2/06, mental@...3... <mental@...3...> wrote:

> > * To get the type of an event I rely entirely on the current > > event context. This obviously not (always) a correct > > assumption. An example of this problem: setting an object's > > color while the node tool is the current context. > > Probably we'll need to add an extra argument to sp_document_done() > to help you out with this.

Exactly, and I remember mentioning this a couple times in the past. Mental, you look like the most natural person since you wrote the undo system. Can you do this or help some volunteer to do this? If someone puts in the infrastructure I will go and fill in the annotations for all document_done calls. Then we'll also be able to display them in the Undo/Redo commands in the menu.

If there are any easy (fail-proof, so to say ;) changes I can do myself, I'd be glad to help out.

I have recently uploaded a patch[1] which provides an undo history dialog. It is similar to those found in e.g. GIMP[2] and Photoshop[3] (I don't know if it's in Illustrator, CorelDRAW, etc). To get an idea what it looks like without having to apply the patch, here's a screencast (in flash, sorry ;) showing it in action: http://www.csc.kth.se/~broberg/undo-history.html

First of all, I'm not sure if this is a requested addition to Inkscape -- I can't recall any discussion about it on the list and I didn't find anything in the wiki. Personally, however, I do find it useful (at least occasionally), so I went ahead and implemented it.