On Sep 25, 2007, at 10:02 PM, bulia byak wrote:

On 9/26/07, Jon A. Cruz <jon@...18...> wrote:

...

I just committed the initial cut of display calibration. Just set the preference to your display correction profile and enable it.

Hmm, what am I supposed to type in there? A .icc filename? Why not provide a Browse button then?

Because the inkscape preferences panel and widgets did not support that.

yet.

:-)

I'm in the middle of converting that to use a file button and/or MRU combo. Should be in sometime after I finish a run to get mochas.

Also, Jon, PLEASE fill in the release notes AT ONCE on any new functionality you add. It will make life much easier for everyone who's trying to figure out what's new. It will also help you remember what you did and what you plan to do.

You also have a number of unfinished placeholders from your past work, including the "secret sauce" which annoys me for half a year now :)

On 9/26/07, bulia byak <buliabyak@...400...> wrote:

On 9/26/07, Jon A. Cruz <jon@...18...> wrote:

...

Hmm, what am I supposed to type in there? A .icc filename? Why not

provide a Browse button then? Because the inkscape preferences panel and widgets did not support that.

OK :)

More generally, are there some free profiles (possibly trivial/demo, although if they are useful it's even better) that we could ship with, to make this feature at least tryable for people who don't happen to have .icc for their display?

-- bulia byak Inkscape. Draw Freely. http://www.inkscape.org

On 9/26/07, Jon A. Cruz <jon@...18...> wrote:

On Sep 25, 2007, at 11:22 PM, bulia byak wrote: Also, Jon, PLEASE fill in the release notes AT ONCE on any new functionality you add. It will make life much easier for everyone

Check the chat logs. Already in progress.

Thanks, but...

Can you try to imagine a _regular user_ when writing? The release notes is a document that should be understandable for any user of Inkscape. You write:

Inkscape now supports optional "icc-color(...)" paint components.

What components? Where? What is "paint"? Where am I supposed to add these components and in what form? This is all really confusing for a regular user.

Please try to expand your explanation and make it understandable. If this means adding a short introduction into SVG features, no problem. Always try to take a wider perspective at what you're doing: this helps in programming too, not only in writing documentation.

On Wednesday, September 26, 2007, 6:17:02 PM, bulia wrote:

bb> Can you try to imagine a _regular user_ when writing? The release bb> notes is a document that should be understandable for any user of bb> Inkscape. You write:

bb> Inkscape now supports optional "icc-color(...)" paint components.

Perhaps:

Inkscape now supports color-managed color definitions that use a colorspace other than sRGB (for example Adobe RGB, or calibrated CMYK colors). In the SVG file, this is done using the optional "icc-color(...)" paint components as described in section 11.2 "Specifying paint" of the SVG 1.1 specification. http://www.w3.org/TR/SVG11/painting.html#SpecifyingPaint

A fallback sRGB value will be used, for non color-managed workflows.

On 9/27/07, bulia byak wrote:

You're very welcome to register at our wiki and edit the release notes, especially on the color management topic which is poorly understood by many and would really benefit from a thorough, detailed explanation, ideally with some examples and usage tips.

IMO, detailed explanation, example and tips should go to user manual :)

We are working onnew outline at the moment and a section/chapter on color management is planned. Contributions are very welcome, be it Jon, Chris or anyone else ;-) In a timely manner ;-)

Alexandre

Hi All,

I'm just continuing to work on the native win32 file dialogs. Things are coming along, slowly, but I've stumbled into yet another problem. In order to render a preview of the selected file I need to be able to rasterise an SVG file. Because of the way the windows file dialog works, it has to be executed from a worker thread - not from the main UI thread, otherwise the rest of inkscape locks up in the background.

To show an SVG preview, I need to be able to rasterise a file in this worker thread. I've prepared the beginnings of a routine to do this, derived from the sp_export_png_file file in png-write.cpp. My problem is that when I call sp_document_new_from_mem in the worker thread, the application crashes, when it comes to the line

Document *rdoc = new Inkscape::XML::SimpleDocument();

in sp_repr_do_read in repr-io.cpp. It seems to work properly when called from the main UI thread though. It would seem like some kind of thread-safety issue, but does anyone have a clearer idea what might be going wrong here? and any suggestions?

If not, then I'll continue to persevere; I just thought I'd ask because it's so hard for me to bring in a debugger, the way my environment's set up.

Thanks Joel

The problem is that no message processing occurs in inkscape whatsoever. As you say, the user input processing is not really any big deal, but there are some messages like paint messages which must be processed. Before adding the second thread, as you dragged the file dialog around over the docucument window, a trail of unpaintedness was left behind - very ugly!

----- Original Message ----- From: "bulia byak" <buliabyak@...400...> To: "Joel Holdsworth" <joel@...1709...> Cc: "Inkscape List Devel" inkscape-devel@lists.sourceforge.net Sent: Thursday, September 27, 2007 12:03 AM Subject: Re: [Inkscape-devel] Rasterising an SVG in a worker thread

On 9/26/07, Joel Holdsworth <joel@...1709...> wrote:

...

I'm just continuing to work on the native win32 file dialogs. Things are coming along, slowly, but I've stumbled into yet another problem. In order to render a preview of the selected file I need to be able to rasterise an SVG file. Because of the way the windows file dialog works, it has to be executed from a worker thread - not from the main UI thread, otherwise the rest of inkscape locks up in the background.

So what is the problem with locking Inkscape while a file dialog is open? AFAIK these dialogs are modal anyway.

-- bulia byak Inkscape. Draw Freely. http://www.inkscape.org

On 9/26/07, bulia byak wrote:

More generally, are there some free profiles (possibly trivial/demo, although if they are useful it's even better) that we could ship with, to make this feature at least tryable for people who don't happen to have .icc for their display?

http://www.adobe.com/support/downloads/detail.jsp?ftpID=3682

Alexandre

On 9/26/07, bulia byak wrote:

On 9/26/07, Alexandre Prokoudine wrote:

...

http://www.adobe.com/support/downloads/detail.jsp?ftpID=3682

I'm not a lawyer but to me, their license sounds way too nasty to allow redistribution with Inkscape.

Another option: http://www.eci.org/eci/en/060_downloads.php

Alexandre

On 9/26/07, Jon A. Cruz wrote:

...

I'm in the middle of converting that to use a file button and/or MRU combo. Should be in sometime after I finish a run to get mochas.

Done.

Here is a simple crash test :) Take any of Adobe free CMYK profiles (say, European Coated, and yes -- I know it's silly to use it for display here) and try to use it. As soon as you enable CMS by clicking the checkbox, Inkscape crashes.

Also, it would probably be a good idea to use View menu for quick enabling and disabling color management (and softproofing whenever it's ready), say, View - Color management - {Off|Calibrated display|Softproof}

Btw, how does Inkscape handle bitmaps that have, say, Adobe RGB (1998) color profile applied? As sRGB?

Alexandre

On Sep 26, 2007, at 3:11 AM, Alexandre Prokoudine wrote:

Here is a simple crash test :) Take any of Adobe free CMYK profiles (say, European Coated, and yes -- I know it's silly to use it for display here) and try to use it. As soon as you enable CMS by clicking the checkbox, Inkscape crashes.

Interesting. When I try that, I just see some warnings come up:

lcms: Error #12288; Output profile is operating on wrong colorspace lcms: Error #12288; Output profile is operating on wrong colorspace lcms: Error #12288; Output profile is operating on wrong colorspace lcms: Error #12288; Output profile is operating on wrong colorspace

I'll just work on things to check and block usage for those, then it should probably stop crashing for you.

BTW, which version of LCMS do you have?

Btw, how does Inkscape handle bitmaps that have, say, Adobe RGB (1998) color profile applied? As sRGB?

It depends on what you mean by "applied".

If there is an <image> tag with a color-profile attribute, Inkscape uses that as the input profile and adjusts the pixels. If you mean embedded inside the image itself, we're not doing anything at the moment.

On Sep 26, 2007, at 9:34 AM, Alexandre Prokoudine wrote:

On 9/26/07, Jon A. Cruz wrote:

...

I'll just work on things to check and block usage for those, then it should probably stop crashing for you.

Does it mean there will be some feedback to user that he's trying to do something silly? :)

Crashing blocked. g_message emitted.

Silly user feedback coming soon.

On Sep 27, 2007, at 12:19 PM, Emanuele Aina wrote:

Where it is configured it could be possible to retrieve the profile automatically from the windowing system.

IIRC eog should support it or it should have some patches in its bugzilla written by Ross Burton to get ICC information from the system.

Thanks.

I actually wrote some test code that does that a while back. I'll be adding a version for Inkscape in shortly.

First, though, I'm trying to refine the color chooser a bit more.