Today I looked into how Inkscape finds and presents fonts (using Xft, i.e. this only affects Linux). Lots of problems are now fixed.
1. For some reason, Inkscape ignored all fonts from *.pfa files, commenting thus:
/* fixme: This is silly and evil */ /* But Freetype just does not load pfa reliably (Lauris) */ /* Changed to exclude pfa, better for OSX */
In my tests, pfa fonts are loaded just as well as any other fonts. So I restored the pfa loading capability. Now I need someone else to confirm that it works with pfa fonts. This may fix bug 894947.
2. Much worse, when parsing a font, Inkscape (that is, Sodipodi, because this part of the code did not change from Sodipodi times) only pays attention to weight and slant - and nothing else. As a result, font faces within a family that differ in some other parameters (condensed, outline, small caps etc) were simply ignored, not used and not shown. Until today, Inkscape only loaded 173 font faces on my system; after I fixed this and the pfa loading, it shows 202! This will likely fix bug 904962.
3. The names for faces within a family were constructed by Inkscape from the numeric weight and slant parameters. As a result, all fonts were shown in the list as "Normal", "Italic", etc., even when the fonts used different style names (Regular, Book, Slanted etc). Now it remembers and uses for display the exact style name of the font as returned by Xft.
4. When sorting full font names into families, a rather stupid algorithm was used which unreliably compared font names with family names. As a result, fonts sometimes ended up in wrong families. This is now fixed, each font remembers its exact full name and family name as reported by Xft.
5. Very annoyingly, the list of styles in the Text dialog was not sorted. Now it is sorted so that Regular or Roman always comes first, then Italic, Bold, Bold Italic.
TODO: This is only tested on Linux. I may well have broken something on Windows. This also requires additional testing (and likely coding) to accommodate non-ASCII font names and style names.
_________________________________________________________________ MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*. http://join.msn.com/?page=features/virus&pgmarket=en-ca&RU=http%3a%2...
bulia byak wrote:
TODO: This is only tested on Linux. I may well have broken something on Windows. This also requires additional testing (and likely coding) to accommodate non-ASCII font names and style names.
This is probably unrelated, but I am getting a segfault on nr-type-w32.cpp on line 139, called from 179, whenever I load an SVG file with text:
void nr_type_w32_build_def (NRTypeFaceDef *def, const unsigned char *name, const unsigned char *family) { def->type = NR_TYPE_TYPEFACE_W32; def->name = (gchar *)g_strdup ((const gchar *)name); <--- HERE def->family = (gchar *)g_strdup ((const gchar *)family); def->typeface = NULL; }
void nr_type_read_w32_list (void) { NRNameList wnames, wfamilies; int i;
nr_type_w32_typefaces_get (&wnames); nr_type_w32_families_get (&wfamilies);
for (i = wnames.length - 1; i >= 0; i--) { NRTypeFaceDef *tdef;
const unsigned char *family = (const unsigned char *) (wnames.families[i]);
// const unsigned char *family; // family = NULL; // for (j = wfamilies.length - 1; j >= 0; j--) { // int len; // len = strlen ((gchar *)wfamilies.names[j]); // if (!strncmp ((gchar *)wfamilies.names[j], (gchar *)wnames.names[i], len)) { // family = (const unsigned char *)wfamilies.names[j]; // break; // } // }
if (family) { tdef = nr_new (NRTypeFaceDef, 1); tdef->next = NULL; tdef->pdef = NULL; //##### CALLED FROM HERE ####### nr_type_w32_build_def (tdef, (const unsigned char *)wnames.names[i], family); nr_type_register (tdef); } }
nr_name_list_release (&wfamilies); nr_name_list_release (&wnames); }
On Fri, 27 Feb 2004, bulia byak wrote:
Today I looked into how Inkscape finds and presents fonts (using Xft, i.e. this only affects Linux). Lots of problems are now fixed.
Wow, very cool. These fixes sound like they'll solve a wide range of font problems we've all been bothered by, including several secondary bugs that arise from our hacky workarounds. :-)
(For example, with this fix, we may be able to deliver the About screen with regular text instead of converting to curves, which has caused several secondary issues. Similarly, probably helps with Tutorial troubles too.)
- For some reason, Inkscape ignored all fonts from *.pfa files, commenting
thus:
/* fixme: This is silly and evil */ /* But Freetype just does not load pfa reliably (Lauris) */ /* Changed to exclude pfa, better for OSX */In my tests, pfa fonts are loaded just as well as any other fonts. So I restored the pfa loading capability. Now I need someone else to confirm that it works with pfa fonts. This may fix bug 894947.
- Much worse, when parsing a font, Inkscape (that is, Sodipodi, because
this part of the code did not change from Sodipodi times) only pays attention to weight and slant - and nothing else. As a result, font faces within a family that differ in some other parameters (condensed, outline, small caps etc) were simply ignored, not used and not shown. Until today, Inkscape only loaded 173 font faces on my system; after I fixed this and the pfa loading, it shows 202! This will likely fix bug 904962.
- The names for faces within a family were constructed by Inkscape from the
numeric weight and slant parameters. As a result, all fonts were shown in the list as "Normal", "Italic", etc., even when the fonts used different style names (Regular, Book, Slanted etc). Now it remembers and uses for display the exact style name of the font as returned by Xft.
- When sorting full font names into families, a rather stupid algorithm was
used which unreliably compared font names with family names. As a result, fonts sometimes ended up in wrong families. This is now fixed, each font remembers its exact full name and family name as reported by Xft.
Think this may solve the issue where if a font is unknown, it defaults to the first in the list, rather than selecting a different font from the same family?
- Very annoyingly, the list of styles in the Text dialog was not sorted.
Now it is sorted so that Regular or Roman always comes first, then Italic, Bold, Bold Italic.
TODO: This is only tested on Linux. I may well have broken something on Windows. This also requires additional testing (and likely coding) to accommodate non-ASCII font names and style names.
Thanks Bulia, this is a major enhancement to the codebase and long needed. I had assumed it'd be a big project to start addressing these issues, it's wonderful to see how quickly that some of the basic issues could be fixed.
Bryce
participants (3)
-
Bob Jamison -
Bryce Harrington -
bulia byak