number seems to be initialized by ss

On Thu, Nov 10, 2011 at 5:05 PM, Kris De Gussem <kris.degussem@...400...>wrote:

Hi all

sorry for reusing this thread. An equally weird issue can be seen in src/xml/repr-css.cpp

On line 310 you'll find: double number; std::string characters; std::string temp; bool number_valid = !(ss >> number).fail();

How is it possible that on line 310 "number" is defined and two lines later, number is used, while no sensible value is read into this variable?

Who can help with this issue?

Kind regards Kris

2011/11/4 Johan Engelen <jbc.engelen@...2592...>:

...

Hi all,

I just found this in the code:

gchar const *sp_svg_length_get_css_units(SVGLength::Unit unit) { switch (unit) { ... case SVGLength::MM: return "mm"; case SVGLength::FOOT: return ""; // Does not have a "foot" unit string in the SVG spec ...

That seems weird. Are we sure this is correct, instead of returning "ft" for the foot unit?

Thanks, Johan

---

...

RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel

---

RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel

On 10-11-2011 21:03, Kris De Gussem wrote:

Drop my message. Misread something...

2011/11/10 Felipe Sanches<juca@...2270...>:

...

number seems to be initialized by ss

On Thu, Nov 10, 2011 at 5:05 PM, Kris De Gussem<kris.degussem@...400...> wrote:

...

Hi all

sorry for reusing this thread. An equally weird issue can be seen in src/xml/repr-css.cpp

On line 310 you'll find: double number; std::string characters; std::string temp; bool number_valid = !(ss>> number).fail();

How is it possible that on line 310 "number" is defined and two lines later, number is used, while no sensible value is read into this variable?

The code should be rewritten to be easier to understand...