Krzysztof,
Please view the following pictures. This is after your commit.
http://halley.cc/inkscape-align-nodes-1.png http://halley.cc/inkscape-align-nodes-1.png
Also see the following conversation about this feature here:
https://bugs.launchpad.net/inkscape/+bug/338521
Can you please tell me why you re-reverted my fix, breaking these buttons yet again?
The code and icons for these buttons were FINE in 0.46. The icons.svg images are pretty clear about what the functions should do, and there's no reason to swap their positions or meanings. The IDs in the icons.svg got swapped and the hicolor icons were named after the swapped IDs.
Please revert your fix, and test it to make sure it (1) matches the 0.46 look and behavior, (2) has tooltips to match the function and appearance of icons, (3) fully works whether using the hicolor icons or the icons.svg, (4) follow up on launchpad when making behavior changes in code.
-- [ e d @ h a l l e y . c c ]
On Apr 13, 2009, at 10:19 PM, Ed Halley wrote:
http://halley.cc/inkscape-align-nodes-1.png http://halley.cc/inkscape-align-nodes-2.png
Obviously, I meant the two linked images to be distinct.
-- [ e d @ h a l l e y . c c ]
Ed Halley wrote:
Can you please tell me why you re-reverted my fix, breaking these buttons yet again?
See the comment in the affected source file. The problem here is that "align points vertically" is ambiguous. I wanted to stay consistent with what e.g. align-vertical-center means: it means that the aligned objects move vertically to line up on a common horizontal line. It may be a bit counter-intuitive at first but it's consistent with how the other actions are named. I also changed how those actions are described to remove that ambiguity. Now, another thing is how to place those icons in the dialog: if you think the old arrangement is better, I can change it back to how it was in 0.46
Regards, Krzysztof Kosiński
2009/4/15 Krzysztof Kosiński <tweenk.pl@...400...>:
See the comment in the affected source file. The problem here is that "align points vertically" is ambiguous. I wanted to stay consistent with what e.g. align-vertical-center means: it means that the aligned objects move vertically to line up on a common horizontal line.
No, that's even more confusing. Please restore the old order of buttons and their images, but simply rename "align horizontally" to "align on horizontal axis" in the tooltip, which is unambiguous. How the icons are named internally does not matter, what matters is their order, images, and tooltips (and the matching functions, of course).
Note that object align buttons do not say "align vertically", but "center on horizonal axis", "align bottoms", etc. This is exactly to avoid this ambiguity.
bulia byak wrote:
No, that's even more confusing. Please restore the old order of buttons and their images, but simply rename "align horizontally" to "align on horizontal axis" in the tooltip, which is unambiguous. How the icons are named internally does not matter, what matters is their order, images, and tooltips (and the matching functions, of course).
The old placement is in revision 21160. I already changed the tooltips earlier (to "align selected nodes to a common vertical/horizontal line") Regards, Krzysztof Kosiński
participants (3)
-
bulia byak -
Ed Halley -
Krzysztof Kosiński