As there have been some talk about my old mockup of the new preferences dialog, I thought it might be nice to have another look at it. Right now [1], it's quite noisy, so I thought it might be a good time to do a bit of the kill-your-darlings. http://ramnet.se/~nisse/diverse/temp/inkscape_new_prefs_mockup4.png
Has anyone actually started coding on this?
If not i'd like to volunteer.
I am making a preferences dialog for my own projects (90% finished), much like the screenshot above, it is in gtkmm (without using glade or libglade), hig compliant and written in a way that will reduce code size considerably compared to the gtk+ version.
It would of course require some work to fit this into inkscape but i have done at least 50% already and i'm willing to do the other 50% as well. So let me know if i can contribute to this excellent project with this.
-- Marco
You wrote
http://ramnet.se/~nisse/diverse/temp/inkscape_new_prefs_mockup4.png
[...] It would of course require some work to fit this into inkscape but i have done at least 50% already and i'm willing to do the other 50% as well.
Please do so! I don't have the impression anyone other than me is doing Gtkmmification right now, and I'm still at Document Properties [sic].
However, you are advised to subclass your dialog from Inkscape::Dialog::Dialog, which takes care of some signals, the transientizing, and the Close Button for you.
On the issue of the Close Button, its existence is controlled by the dialogs.showclose preference which, astonishingly, can nowhere be set in the program, so please add this to the Windows subpage.
When you have something to look at, I might steal the design/code for Doc Props which is HIG-noncompliant in 13 points at the moment, according to the latest bug report.
Regards, ralf
On Dec 19, 2005, at 8:12 AM, Ralf Stephan wrote:
However, you are advised to subclass your dialog from Inkscape::Dialog::Dialog, which takes care of some signals, the transientizing, and the Close Button for you.
One alternative is not to code a dialog.
:-)
Instead, code something that could go into a dialog, but doesn't have to.
http://wiki.inkscape.org/cgi-bin/wiki.pl?DialogReplacement (The main principle here would be to favor aggregation over inheritance)
I'm actually about to some of the interface classes back in and switch the Swatches to it, so that it can come up in the main UI also.
On Dec 19, 2005, at 8:12 AM, Ralf Stephan wrote:
http://ramnet.se/~nisse/diverse/temp/inkscape_new_prefs_mockup4.png
[...] It would of course require some work to fit this into inkscape but i have done at least 50% already and i'm willing to do the other 50% as well.
Please do so! I don't have the impression anyone other than me is doing Gtkmmification right now, and I'm still at Document Properties [sic].
However, you are advised to subclass your dialog from Inkscape::Dialog::Dialog, which takes care of some signals, the transientizing, and the Close Button for you. On the issue of the Close Button, its existence is controlled by the dialogs.showclose preference which, astonishingly, can nowhere be set in the program, so please add this to the Windows subpage.
Maybe that could be my first patch. Wouldn't it be better to fix that in Inkscape::Dialog::Dialog ? I could add a 'show_ok_button' argument to the dialog ctor which defaults to USE_PREFERENCE, but can also be SHOW_BUTTON or HIDE_BUTTON. Or i could overload the ctor with enum InkscapeButtonsType { BUTTONS_NONE, BUTTONS_OK, BUTTONS_CLOSE, BUTTONS_CANCEL, BUTTONS_YES_NO, BUTTONS_OK_CANCEL, BUTTONS_APPLY_OK_CANCEL, BUTTONS_APPLY_OK, BUTTONS_APPLY_CANCEL };
Dialog(const char *prefs_path, int verb_num = 0, InkscapeButtonsType buttons);
When you have something to look at, I might steal the design/code for Doc Props which is HIG-noncompliant in 13 points at the moment, according to the latest bug report.
I will take some time to familiarize myself with the inkscape code, to prevent me from getting off to a false start. But i will have something to look at in a couple of weeks.
-- Marco
Marco Scholten:
On Dec 19, 2005, at 8:12 AM, Ralf Stephan wrote:
On the issue of the Close Button, its existence is controlled by the dialogs.showclose preference which, astonishingly, can nowhere be set in the program, so please add this to the Windows subpage.
Maybe that could be my first patch. Wouldn't it be better to fix that in Inkscape::Dialog::Dialog ? I could add a 'show_ok_button' argument to the dialog ctor which
I think the intention with the dialogs.showclose preference was to give the inkscape user the possibility to add such a button to all dialogs. This would then be saved in the user's preferences.xml file. Who planned this, however, didn't put a widget for it into the Inkscape Preferences dialog. That's why I asked you to add it. When we have that, implementors need not bother with the question anymore, at all, so your fine solutions for the implementors aren't needed then.
ralf
On Tue, 20 Dec 2005 16:00:50 +0100, Ralf Stephan <ralf@...748...> wrote:
Marco Scholten:
On Dec 19, 2005, at 8:12 AM, Ralf Stephan wrote:
On the issue of the Close Button, its existence is controlled by the dialogs.showclose preference which, astonishingly, can nowhere be set in the program, so please add this to the Windows subpage.
Maybe that could be my first patch. Wouldn't it be better to fix that in Inkscape::Dialog::Dialog ? I could add a 'show_ok_button' argument to the dialog ctor which
I think the intention with the dialogs.showclose preference was to give the inkscape user the possibility to add such a button to all dialogs. This would then be saved in the user's preferences.xml file. Who planned this, however, didn't put a widget for it into the Inkscape Preferences dialog. That's why I asked you to add it.
I should have read your mail more carefully, i thought you meant that i should manually add the close buttton to the dialog.
-- Marco
participants (4)
-
Jon A. Cruz -
Marco -
Marco Scholten -
Ralf Stephan