Hi Markus, all,
Markus has done a great job of C++ifying a ton of our C-classes, but... there are still a few left. knot.h display/sp-canvas-item.h ...
Are we taking up that task too? :-))
Cheers, Johan
Hi, I'm already working on the "display"-things ;) .
Regards, Markus
-----Ursprüngliche Nachricht----- Von: Johan Engelen [mailto:jbc.engelen@...2592...] Gesendet: Freitag, 4. Oktober 2013 21:54 An: Markus Engel; Inkscape-Devel Betreff: More C++ify?
Hi Markus, all,
Markus has done a great job of C++ifying a ton of our C-classes, but... there are still a few left. knot.h display/sp-canvas-item.h ...
Are we taking up that task too? :-))
Cheers, Johan
2013/10/4 Johan Engelen <jbc.engelen@...2592...>:
Hi Markus, all,
Markus has done a great job of C++ifying a ton of our C-classes, but... there are still a few left. knot.h display/sp-canvas-item.h
Just a note:
- SPKnot from knot.h should eventually be replaced by Inkscape::UI::ControlPoint from ui/tool/control-point.h, which is a lot easier to use.
- I'm not really sure whether having a separate hierarchy of SPCanvasItem is a good idea; perhaps using a modified DrawingItem for controls is better.
Regards, Krzysztof
On Sat, 2013-10-05 at 00:28 +0200, Krzysztof Kosiński wrote:
- SPKnot from knot.h should eventually be replaced by
Inkscape::UI::ControlPoint from ui/tool/control-point.h, which is a lot easier to use.
- I'm not really sure whether having a separate hierarchy of
SPCanvasItem is a good idea; perhaps using a modified DrawingItem for controls is better.
Which ever refactoring we do for the 0.50/1.0/5.0 release, I'd like to reserve some review time because the align handles will need certain things. Although I've already touched a lot of this code for various reasons and I would have refactoered it into C++ but I'll wait until I've watched a few more inspirational videos ;-)
For now, we have some interesting bugs.
Martin,
Waiting for the time after 0.49 sounds sensible. Just look at all the things I broke by mistake when I was "only" converting these things to c++ without changing any of the logic ;) . For more "inspirational videos" look at these two pages: http://channel9.msdn.com/Events/GoingNative/GoingNative-2012 http://channel9.msdn.com/Events/GoingNative/2013
I can especially recommend Scott Meyers' speech "An Effective C++11/14 Sampler", not only for the topic, but for his presentation. Probably the best speaker I've ever listened to :) .
Regards, Markus
-----Ursprüngliche Nachricht----- Von: Martin Owens [mailto:doctormo@...400...] Gesendet: Samstag, 5. Oktober 2013 01:24 An: Krzysztof Kosiński Cc: Inkscape-Devel Betreff: Re: [Inkscape-devel] More C++ify?
On Sat, 2013-10-05 at 00:28 +0200, Krzysztof Kosiński wrote:
- SPKnot from knot.h should eventually be replaced by
Inkscape::UI::ControlPoint from ui/tool/control-point.h, which is a lot easier to use.
- I'm not really sure whether having a separate hierarchy of
SPCanvasItem is a good idea; perhaps using a modified DrawingItem for controls is better.
Which ever refactoring we do for the 0.50/1.0/5.0 release, I'd like to reserve some review time because the align handles will need certain things. Although I've already touched a lot of this code for various reasons and I would have refactoered it into C++ but I'll wait until I've watched a few more inspirational videos ;-)
For now, we have some interesting bugs.
Martin,
------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clk... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (4)
-
Johan Engelen -
Krzysztof Kosiński -
Markus Engel -
Martin Owens