I've committed a fix to one of the marker menu bugs. Previously, the marker menu had been split to show markers in the <defs> above the line only if they were non-stock markers. However, the problem happens that if one alters the stock marker in the <defs> section without changing its ID, it doesn't show at all in the menu.
Now, the menu shows ALL markers from <defs> above the line, regardless of whether they're stock or not. This obviously has the downside that for people who use a lot of stock markers, the menu will get cluttered, however I suspect that may be a less common use case than we thought initially.
Also, a more important underlying change is that in order to do this I've added some svg preview cache code based on code used by the icon renderer. This allows us to render each marker preview once, instead of three times (once for each menu), and avoids performance trouble if the marker menu is dynamically changed.
(I needed to dynamically update the marker menus when selecting stock id's to ensure that if you select a stock id, it immediately shows up in the above-the-line markers in all three menus.) This will also eventually help solve a problem where if you have the fill-and-stroke dialog open when switching between two docs with custom markers, it doesn't update properly; I haven't fixed this, but just need to figure out how to hook in with the callback for "document selection changed".
(This dynamic marker menu underlying structure is also needed for future anticipated changes to the marker system...)
Bryce
On 2/20/07, Bryce Harrington <bryce@...961...> wrote:
(I needed to dynamically update the marker menus when selecting stock id's to ensure that if you select a stock id, it immediately shows up in the above-the-line markers in all three menus.) This will also eventually help solve a problem where if you have the fill-and-stroke dialog open when switching between two docs with custom markers, it doesn't update properly; I haven't fixed this, but just need to figure out how to hook in with the callback for "document selection changed".
This is the ACTIVATE_DESKTOP signal sent by the global Inkscape object. E.g. the clone tiler dialog listens to it.
Thanks for the fixes Bryce, and please don't forget to describe them at http://wiki.inkscape.org:8080/wiki/index.php/ReleaseNotes046 :)
bulia byak wrote:
http://wiki.inkscape.org:8080/wiki/index.php/ReleaseNotes046 :)
8080!?!? Seriously now. How do you get to the wiki? I'd like to change the links where ever possible to prevent the 8080's. Links need to be like the following to avoid it until we fix squid.
http://wiki.inkscape.org/wiki/index.php
(who setup squid?)
Aaron Spike
On 2/20/07, Aaron Spike <aaron@...749...> wrote:
bulia byak wrote:
http://wiki.inkscape.org:8080/wiki/index.php/ReleaseNotes046 :)
8080!?!? Seriously now. How do you get to the wiki?
The url was just autocompleted by my browser, which is my usual way of going to pages I visit often... so I'm afraid we can't find the original culprit now :)
On Tue, Feb 20, 2007 at 04:51:41PM -0600, Aaron Spike wrote:
bulia byak wrote:
http://wiki.inkscape.org:8080/wiki/index.php/ReleaseNotes046 :)
8080!?!? Seriously now. How do you get to the wiki? I'd like to change the links where ever possible to prevent the 8080's. Links need to be like the following to avoid it until we fix squid.
http://wiki.inkscape.org/wiki/index.php
(who setup squid?)
Me. But I did not kill the deputy. Er, I mean, I didn't put wiki on port 8080.
Bryce
On Tue, 2007-02-20 at 15:13 -0800, Bryce Harrington wrote:
On Tue, Feb 20, 2007 at 04:51:41PM -0600, Aaron Spike wrote:
bulia byak wrote:
http://wiki.inkscape.org:8080/wiki/index.php/ReleaseNotes046 :)
8080!?!? Seriously now. How do you get to the wiki? I'd like to change the links where ever possible to prevent the 8080's. Links need to be like the following to avoid it until we fix squid.
http://wiki.inkscape.org/wiki/index.php
(who setup squid?)
Me. But I did not kill the deputy. Er, I mean, I didn't put wiki on port 8080.
Bryce
It automatically changes to port 8080. Does anyone have experience with this? Kees? :)
Jon
Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=D... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Tue, Feb 20, 2007 at 06:22:37PM -0400, bulia byak wrote:
On 2/20/07, Bryce Harrington <bryce@...961...> wrote:
(I needed to dynamically update the marker menus when selecting stock id's to ensure that if you select a stock id, it immediately shows up in the above-the-line markers in all three menus.) This will also eventually help solve a problem where if you have the fill-and-stroke dialog open when switching between two docs with custom markers, it doesn't update properly; I haven't fixed this, but just need to figure out how to hook in with the callback for "document selection changed".
This is the ACTIVATE_DESKTOP signal sent by the global Inkscape object. E.g. the clone tiler dialog listens to it.
Thanks, that did it. This problem is now solved.
I have also corrected a couple other remaining glitches, such as that if you have a modified instance of a stock marker, without changing the stock-id, then in the dropdown the stock marker is shown as the current selection, which wouldn't be correct. Now, the entry in the "recently used marker" list above the line is selected, as one would expect. I also found an issue that in this particular situation the unmodified stock marker's preview image in the cache would be used in place of the customized one, and fixed this by involving the use of uri's in the keys used for the cache.
Thanks for the fixes Bryce, and please don't forget to describe them at http://wiki.inkscape.org:8080/wiki/index.php/ReleaseNotes046 :)
Sure, done.
I believe this should resolve all of the known issues with the marker dropdowns in the fill-and-stroke dialog. Please give it a test and let me know if you can find any issues.
Bryce
participants (4)
-
Aaron Spike -
Bryce Harrington -
bulia byak -
Jon Phillips