On 2015-11-21 08:03 (+0100), Krzysztof Kosiński wrote:

2015-11-20 4:48 GMT-08:00 Alex Valavanis <valavanisalex@...400...>:

...

Any objections if I go ahead with this merge?

https://code.launchpad.net/~valavanisalex/inkscape/fix-1156664

It will introduce a soft dependency on an external copy of libpotrace. It will still build without the external library, but without the trace bitmap/flood tools. Windows Devlibs will need to be updated separately.

+1, as long as it works - it removes an internal fork.

Is the libpotrace library available as a package on mainstream distributions and in macports?

It is available in MacPorts - see also my comment in the merge proposal: https://code.launchpad.net/~valavanisalex/inkscape/fix-1156664/+merge/277406

Regards, V

Anyone who has compiling problems on windows since the merge of the potracelib branch? (rev 14480) trace/potrace/potracelib.h was removed, while it is still used (and apparently necessery) at trace/potrace/inkscape-potrace.h:21:24

Can anyone help/fix the issue in inkscape or devlibs? btool output below.

Setup: windows 10 64 bit (compiling in 32 bit) devlibs revno: 53 (latest) trunk revno: 14493 (latest, problems started with the the merge of the potracelib branch) tdm-gcc version 4.6.1 (32 bits) A "btool clean" was performed.

Regards, K

--------------------------------------------------------------- compile src/trace/trace.cpp Make error line 307: problem compiling: In file included from src/trace/trace.cpp:15:0: src/trace/potrace/inkscape-potrace.h:21:24: fatal error: potracelib.h: No such file or directory compilation terminated.

compile src/ui/dialog/tracedialog.cpp Make error line 307: problem compiling: In file included from src/ui/dialog/tracedialog.cpp:33:0: src/trace/potrace/inkscape-potrace.h:21:24: fatal error: potracelib.h: No such file or directory compilation terminated.

compile src/ui/tools/flood-tool.cpp Make error line 307: problem compiling: In file included from src/ui/tools/flood-tool.cpp:24:0: src/trace/potrace/inkscape-potrace.h:21:24: fatal error: potracelib.h: No such file or directory compilation terminated. ---------------------------------------------------------------

2015-11-21 11:38 GMT+01:00 Alex Valavanis <valavanisalex@...400...>:

On 21 Nov 2015 7:03 a.m., "Krzysztof Kosiński" <tweenk.pl@...400...> wrote:

...

Is the libpotrace library available as a package on mainstream distributions and in macports?

Yep, at least in Debian derivatives, Fedora, OpenSUSE and MacPorts.

@suv - Thanks for the review; looking into it now.

AV