Can you post this patch to launchpad?

On Sun, Jan 27, 2008 at 07:36:23AM -0500, R M wrote:

...

Also: maybe while you're at it, you could also add the tolerance slider to the controls bar of the tool, which is a very long-standing feature gap.

here's a patch to add the tolerance control to the slider:

http://arcsin.org/temp/toolbox.diff

one major problem is that it doesn't listen for preference changes and will get out of sync with the tolerance control in the inkscape-preferences panel. I didn't see any obvious way to remedy this. Is there one, or does one need to be written (setup a signal to connect to, to be notified)?

rob

R M schrieb:

ok, i figured out how to register for preference change notification. so now, if you have the preferences panel open and change the tolerance it will change in the toolbar of any open documents.

http://arcsin.org/temp/toolbox2.diff

however, the preference's tolerance spin button doesn't expect for the value to be changed out from under it, so it doesn't follow changes.

The obvious fix is to automatically have Pref* widgets register to listen for changes...which seems reasonable, but i'd want to hear others' opinions on such an invasive change before doing it.

I like the tolerance spinbutton in the toolbar of the pencil tool but I personally don't see any value in duplicating its functionality in the preferences dialog. So IMHO either the tolerance control should be removed from prefs or it should provide the default value to which the spinbutton in the toolbar is reset when pressing the "sweep" button. In either case there is no need to make the prefs controls listen for changes from outside (after all, that's why they are in prefs :)).

Anyway, just my 2 cents. Cheers, Max