
Hello, I noticed the trailing whitespace item here http://wiki.inkscape.org/wiki/index.php/InkscapeJanitors#Cleanup:_Whitespace so I made a script which generates a (large) patch.
Should this be done for just .cpp, .c and .h files in src/ or should other files be touched?
, John

On Fri, 2007-07-06 at 13:18 -0600, John Faith wrote:
I noticed the trailing whitespace item here http://wiki.inkscape.org/wiki/index.php/InkscapeJanitors#Cleanup:_Whitespace so I made a script which generates a (large) patch.
John, while I appreciate your work here, and I think it needs to be done. Can we do this as the first commit after a release? Seriously, the diff'ing and merging that this'll create is dramatic.
I think the .cpp, .h and .c in /src should be good.
--Ted

On 7/6/07, Ted Gould <ted@...11...> wrote:
On Fri, 2007-07-06 at 13:18 -0600, John Faith wrote:
I noticed the trailing whitespace item here http://wiki.inkscape.org/wiki/index.php/InkscapeJanitors#Cleanup:_Whitespace so I made a script which generates a (large) patch.
John, while I appreciate your work here, and I think it needs to be done. Can we do this as the first commit after a release? Seriously, the diff'ing and merging that this'll create is dramatic.
I think the .cpp, .h and .c in /src should be good.
--Ted
Hi Ted, I have no preference when it's done, but it just bothered since it was on the todo list for so long.
By the way, this is the script I used in case someone wants to do this at the right time before I do, or if someone wants to find files which they are changing for 0.46 anyway:
#!/bin/bash patch=whitespace.patch rm -f $patch srcdir=inkscape.trunk/src for file in `find $srcdir -name '*.cpp'` `find $srcdir -name '*.c'` `find $srcdir -name '*.h'`; do if egrep --quiet '[:space:]$' < $file; then sed 's/\s*$//' < $file > $file.mod diff -ur $file $file.mod >> $patch fi done
, John

On Fri, 06 Jul 2007 13:27:28 -0700, Ted Gould <ted@...11...> wrote:
John, while I appreciate your work here, and I think it needs to be done. Can we do this as the first commit after a release? Seriously, the diff'ing and merging that this'll create is dramatic.
Personally, I don't think we should be doing this. Rather, just have people fix whitespace when they make other changes to those lines.
Otherwise, we drastically reduce the utility of tools like 'svn blame' and other sorts of history analysis, for no real gain.
-mental
participants (3)
-
John Faith
-
MenTaLguY
-
Ted Gould