I consider these two bugs to be MUSTFIX as well:
- the one found by Kees (without pref file, objects are drawn black), see my post with more details on why this happens
- the new crash on load:
http://sourceforge.net/tracker/index.php?func=detail&aid=1113187&gro...
The first of these bugs appears mild, but they both are in the new repr code by Mental and therefore may be signs of something more sinister which we haven't found yet. And both are regressions compared to 0.40.
Mental, will you please look into them? If you need my help I'll do what I can, though currently I'm swamped by work.
Have both of these bugs been taken care of?
Bryce
On Mon, 31 Jan 2005, bulia byak wrote:
I consider these two bugs to be MUSTFIX as well:
- the one found by Kees (without pref file, objects are drawn black),
see my post with more details on why this happens
- the new crash on load:
http://sourceforge.net/tracker/index.php?func=detail&aid=1113187&gro...
The first of these bugs appears mild, but they both are in the new repr code by Mental and therefore may be signs of something more sinister which we haven't found yet. And both are regressions compared to 0.40.
Mental, will you please look into them? If you need my help I'll do what I can, though currently I'm swamped by work.
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Wed, Feb 02, 2005 at 07:22:50PM -0800, Bryce Harrington wrote:
Have both of these bugs been taken care of?
On Mon, 31 Jan 2005, bulia byak wrote:
- the one found by Kees (without pref file, objects are drawn black),
see my post with more details on why this happens
I've fixed this one with several emails from mental and a few C++ implementation class tutorials. (Which seems to have also been the x86_64/PPC crash bug: 1107922)
- the new crash on load:
http://sourceforge.net/tracker/index.php?func=detail&aid=1113187&gro...
I commented out the assert for this one. The situation that causes the assert isn't fixed, but the assert causing it has been commented out because it's not a problem given how things end up in that state, if that makes any sense. :) So, I don't know what to call this... it's fixed in that the average user shouldn't see it, but it's a problem with the code logic in the XML namespace parser that still needs fixing. Maybe lower the priority?
And we also had:
[ 1050361 ] svgz opening troubles
Thanks to John Cliff, I've fixed this in the win32 builds for ddiaz and myself, and I've put up a modification to Bob's libraries at http://outflux.net/inkscape/ for anyone else doing win32 builds. There was also a problem under Linux if you had the GDK svgz loader available, it would get in the way and fail. This was fixed too.
Wow, Kees, you're a great bug fixer :)
As for the assert-on-load, Mental is looking into it, judging by the comment in the bug. So, let's wait a bit, maybe he'll be able to fix it properly.
On Wed, 2 Feb 2005 23:33:53 -0800, Kees Cook <inkscape@...62...> wrote:
On Wed, Feb 02, 2005 at 07:22:50PM -0800, Bryce Harrington wrote:
Have both of these bugs been taken care of?
On Mon, 31 Jan 2005, bulia byak wrote:
- the one found by Kees (without pref file, objects are drawn black),
see my post with more details on why this happens
I've fixed this one with several emails from mental and a few C++ implementation class tutorials. (Which seems to have also been the x86_64/PPC crash bug: 1107922)
- the new crash on load:
http://sourceforge.net/tracker/index.php?func=detail&aid=1113187&gro...
I commented out the assert for this one. The situation that causes the assert isn't fixed, but the assert causing it has been commented out because it's not a problem given how things end up in that state, if that makes any sense. :) So, I don't know what to call this... it's fixed in that the average user shouldn't see it, but it's a problem with the code logic in the XML namespace parser that still needs fixing. Maybe lower the priority?
And we also had:
[ 1050361 ] svgz opening troubles
Thanks to John Cliff, I've fixed this in the win32 builds for ddiaz and myself, and I've put up a modification to Bob's libraries at http://outflux.net/inkscape/ for anyone else doing win32 builds. There was also a problem under Linux if you had the GDK svgz loader available, it would get in the way and fail. This was fixed too.
-- Kees Cook @outflux.net
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Thu, Feb 03, 2005 at 04:14:19AM -0400, bulia byak wrote:
Wow, Kees, you're a great bug fixer :)
Thanks! I'm impatient and I had today off work. Good combo for bug fixing. :)
I also spent some time cleaning up memory leaks and unassigned value usage. (Most of those cleanups were in libnr and libnrtype. Eek.) I was playing with valgrind, and I tried as many of the code paths as I could think of. It doesn't play nice with libgc, so as long as that's _INKSCAPE_GC=disable'd and I ignore those malloc's, it was a pretty interesting bit of output. I want to go run valgrind on other stuff now. :)
As for the assert-on-load, Mental is looking into it, judging by the comment in the bug. So, let's wait a bit, maybe he'll be able to fix it properly.
Yup. It could very easily be worse than I understand, so I'm happy to wait for that one to close too. I just wanted to get it back to loading enough that I could test the input extensions again.
x86_64/PPC crash bug: 1107922
sk1p verified that his bugs were gone, but we have a few other x86_64 bugs in the queue. I'd love to see if they've gone away too.
http://outflux.net/inkscape/ for anyone else doing win32 builds. There was also a problem under Linux if you had the GDK svgz loader available, it would get in the way and fail. This was fixed too.
Ted may want to look over my changes; another one was to not list file types in the load/save dialogs for a deactivated extension (one that didn't load due to missing requirements). I'd like to have them grey'd out instead (like Gimp seems to do), but there wasn't an obvious hook to grey out a ComboBoxText item.
participants (3)
-
Bryce Harrington -
bulia byak -
Kees Cook