bug tested, ready to commit.. please review
hey guys, as this is my first commit, i wanted to run it by you before i do.
this is the bug in question:
https://bugs.launchpad.net/inkscape/+bug/1098416
this is the command i will run (after cd'ing into the "inkscape" dir that contains the src dir):
bzr commit --fixes lp:1098416 --message="adding dockbar/switcher style toggles in prefs ui" src/ui/dialog/inkscape-preferences.h src/ui/dialog/inkscape-preferences.cpp
is all of this ok?
as a separate note, can i get some of you to check
https://bugs.launchpad.net/inkscape/+bug/1092313 https://bugs.launchpad.net/inkscape/+bug/1062134
and provide some feedback so i can commit soon?
thanks, and its great to be able to contribute to such a great project!
-- View this message in context: http://inkscape.13.n6.nabble.com/bug-tested-ready-to-commit-please-review-tp... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
2013/2/4 insaner <nabble-inkscape@...2943...>:
hey guys, as this is my first commit, i wanted to run it by you before i do.
this is the bug in question:
https://bugs.launchpad.net/inkscape/+bug/1098416
this is the command i will run (after cd'ing into the "inkscape" dir that contains the src dir):
bzr commit --fixes lp:1098416 --message="adding dockbar/switcher style toggles in prefs ui" src/ui/dialog/inkscape-preferences.h src/ui/dialog/inkscape-preferences.cpp
The command is OK. Some remarks:
1. If you have no other changes in your tree, you don't need to specify which files to commit. By default, all modified files will be committed. 2. If you don't pass the --message parameter, Bazaar will open an editor for you where you can conveniently enter your commit message.
We have a good Bazaar tutorial on the wiki: http://wiki.inkscape.org/wiki/index.php/Working_with_Bazaar
Regards, Krzysztof
hi Krzysztof, thanks for answering. it worked!
-- View this message in context: http://inkscape.13.n6.nabble.com/bug-tested-ready-to-commit-please-review-tp... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
participants (2)
-
insaner
-
Krzysztof Kosiński