Wanted: Windows user to review inkscape.nsi patches

Release wardens are supposed to act as reviewer for the patches posted to the tracker, but I don't have access to a Windows machine, nor any other reason to learn NSIS.
Can we have someone to act as release warden for inkscape.nsi ?
Documentation for NSIS files is at
http://nsis.sourceforge.net/Docs/
so you don't really need to have any previous NSIS experience to be a better reviewer than I.
(I haven't yet asked Kees as to whether he has access to a Windows machine or any familiarity with NSIS.)
pjrm.

On Sat, Jul 16, 2005 at 09:59:32PM +1000, Peter Moulder wrote:
Can we have someone to act as release warden for inkscape.nsi ?
I can do this. I kept the Windows XP partition on my recently-purchased laptop almost entirely for Inkscape testing. ;)

Kees Cook schrieb:
On Sat, Jul 16, 2005 at 09:59:32PM +1000, Peter Moulder wrote:
Can we have someone to act as release warden for inkscape.nsi ?
I can do this. I kept the Windows XP partition on my recently-purchased laptop almost entirely for Inkscape testing. ;)
I have myself a WinXP Notebook. And also test in the office on Win2k. The Win98 functionality (only singleuser screen appears) I tested on a virtual Win98 running inside my WinXP.
I updated the patchtracker entry: 1233880 new win32 installer with the translations from 1238014 Czech strings for NSI installer 1239399 Polish strings for NSI installer
I made the pre2 installer with all of that and put into the incomming of the sf ftp.
I put some screenshots on http://www.geocities.com/theAdib The italian titles for install and uninstall exceeds the predefined length of 2 rows. So we need one to correct this. I can ask in the office on monday for a shorter version.
All the best,
Adib.

Adib Taraben napsal(a):
Kees Cook schrieb:
On Sat, Jul 16, 2005 at 09:59:32PM +1000, Peter Moulder wrote:
Can we have someone to act as release warden for inkscape.nsi ?
I can do this. I kept the Windows XP partition on my recently-purchased laptop almost entirely for Inkscape testing. ;)
I have myself a WinXP Notebook. And also test in the office on Win2k. The Win98 functionality (only singleuser screen appears) I tested on a virtual Win98 running inside my WinXP.
I updated the patchtracker entry: 1233880 new win32 installer with the translations from 1238014 Czech strings for NSI installer 1239399 Polish strings for NSI installer
I made the pre2 installer with all of that and put into the incomming of the sf ftp.
Hi, I've tested the new nsi installer for pre2-1 to check czech strings and found an encoding issue. Fix for this is in the patch tracker: https://sourceforge.net/tracker/index.php?func=detail&aid=1240006&gr... . Just fyi, source file for this fix was the one from cvs. The encoding issue is the only problem I've found there. Keep up good work, cornelius

Now that the patch is in the codebase somewone is able to close those bugs: ??? 1189537 WinXP Multiuser installation possible 1166358 uninstallation incomplete in Win32 1086827 Installer for Windows did not create menu for normal user
Thx,
Adib.
Peter Moulder schrieb:
Release wardens are supposed to act as reviewer for the patches posted to the tracker, but I don't have access to a Windows machine, nor any other reason to learn NSIS.
Can we have someone to act as release warden for inkscape.nsi ?
Documentation for NSIS files is at
http://nsis.sourceforge.net/Docs/
so you don't really need to have any previous NSIS experience to be a better reviewer than I.
(I haven't yet asked Kees as to whether he has access to a Windows machine or any familiarity with NSIS.)
pjrm.
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel

On Tue, Jul 19, 2005 at 11:36:47PM +0200, Adib Taraben wrote:
Now that the patch is in the codebase somewone is able to close those bugs: ??? 1189537 WinXP Multiuser installation possible 1166358 uninstallation incomplete in Win32 1086827 Installer for Windows did not create menu for normal user
Looks like "theadib" has rights now, so you can feel free to close things things in the future. I've done them for now.
(Status=Closed, Resolution=Fixed)

Kees Cook schrieb:
On Tue, Jul 19, 2005 at 11:36:47PM +0200, Adib Taraben wrote:
Now that the patch is in the codebase somewone is able to close those bugs: ??? 1189537 WinXP Multiuser installation possible 1166358 uninstallation incomplete in Win32 1086827 Installer for Windows did not create menu for normal user
Looks like "theadib" has rights now, so you can feel free to close things things in the future. I've done them for now.
(Status=Closed, Resolution=Fixed)
Kees,
I thought that I can but I can't.
Adib. --- (theAdib)
participants (4)
-
Adib Taraben
-
Josef Vybíral
-
Kees Cook
-
Peter Moulder