Hey Devs,
This is the bi-weekly report on our release-hope goal:
Blockers: 3 * High #1163449 Imported bitmap appear blurry when zoomed in * Medium #953992 Imported pattern fill disappers while transforming * Medium #1005892 Patterns applied to text objects are blurred
If you can fix one of these, please do. We can use all the help to debug, locate the errors causing these regressions and fix them. These blockers are high priority for our project goals.
We have 49 targeted bugs for the release:
If you see something that you could easily fix, then this is a great way to make the next inkscape version better.
I want to make a special mention of novalis' flowText fallback branch. It's going through review right now but I want to give my biggest amazed thanks to Novalis for tacking this difficult and long standing problem.
See the review here: https://code.launchpad.net/~novalis/inkscape/fix-167335/+merge/190297
Keep up the good work everyone! Exciting to see so much work get done.
Best Regards, Martin Owens
El 17/10/13 14:09, Martin Owens escribió:
- High #1163449 Imported bitmap appear blurry when zoomed in
Hi, I have a question regarding these bitmap scaling bugs. As far as I know the patch for bitmap scaling with Cairo has been applied, but it requires the new version of Cairo to work properly. I wonder what will happen with distros that don't have the new version of Cairo yet once inkscape 0.49 is released. Are you going to make that specific version of cairo a requirement for building/install inkscape? As far as I could see, inkscape works with older versions of cairo, but the bitmap scaling is still broken in that case. IMO it doesn't seem a good idea to allow that. Maybe it's better to make the right version of Cairo a hard dependency so distros that hasn't update that package yet stick with 0.48.x
So what's the plan?
Kind regards, Gez.
On Thu, 2013-10-17 at 15:21 -0300, Guillermo Espertino (Gez) wrote:
I have a question regarding these bitmap scaling bugs. As far as I know the patch for bitmap scaling with Cairo has been applied
If this bug is fixed with the new Cairo, then it should be made a dup. suv~ thoughts?
I wonder what will happen with distros that don't have the new version of Cairo yet once inkscape 0.49 is released.
We already have the new Cairo in PPA. Bryce can probably be more specific, but the goal I believe is to make the new Cairo a hard dep, bundle it with Windows and Mac versions and keep the PPA until Debian FDOs catch up and can include the new inkscape version. Same might apply to the Hat FDOs but I don't know about their PPA.
So what's the plan?
Fix bugs and hope we can make a release ;-)
Martin,
The upstream fix is committed in Cairo but has not yet been released. As such, we can't yet specify a hard dependency. The version in the ppa is actually just a patched version of the stable Cairo package.
Once a suitable Cairo version is released, we should bump our dependency level and mark the regressions as fix released (the downscaling issues were never in a stable inkscape release). I don't think we should release 0.49 until then.
AV On 17 Oct 2013 19:51, "Martin Owens" <doctormo@...400...> wrote:
On Thu, 2013-10-17 at 15:21 -0300, Guillermo Espertino (Gez) wrote:
I have a question regarding these bitmap scaling bugs. As far as I know the patch for bitmap scaling with Cairo has been applied
If this bug is fixed with the new Cairo, then it should be made a dup. suv~ thoughts?
I wonder what will happen with distros that don't have the new version of Cairo yet once inkscape 0.49 is released.
We already have the new Cairo in PPA. Bryce can probably be more specific, but the goal I believe is to make the new Cairo a hard dep, bundle it with Windows and Mac versions and keep the PPA until Debian FDOs catch up and can include the new inkscape version. Same might apply to the Hat FDOs but I don't know about their PPA.
So what's the plan?
Fix bugs and hope we can make a release ;-)
Martin,
October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clk... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 2013-10-17 20:50 +0200, Martin Owens wrote:
On Thu, 2013-10-17 at 15:21 -0300, Guillermo Espertino (Gez) wrote:
I have a question regarding these bitmap scaling bugs. As far as I know the patch for bitmap scaling with Cairo has been applied
If this bug is fixed with the new Cairo, then it should be made a dup. suv~ thoughts?
About what exactly? Sorry, I'm not really sure which bug report you suspect to be a duplicate which is not marked as such...
Here's my take on the two reports affecting scaled bitmap images:
- Bug #1163449 (upscaling) Still open (not fixed automagically by a patched cairo version - needs a solution in Inkscape). This report is NOT a duplicate of bug #804162.
- Bug #804162 (downscaling) This bug report was closed by you as 'Fix Committed'. However, it was not "fixed in inkscape" by a commit to inkscape - actually what happened is that code added temporarily to inkscape trunk by Jasper to fix downscaling of bitmap images (r12227) was removed again (r12599) because it was finally committed upstream in cairo git master.
For anyone using an unpatched stable cairo version the downscaling bug is again 'open' (after r12599), and inkscape now has declared this not being its own bug (by relying/depending on a future uptream cairo version).
Personally, I would not have closed bug #804162 as 'Fix Committed' - I would have kept it as 'Triaged', and closed it as 'Invalid' once a newer stable cairo version is available on all major distros, and with all binary packages distributed by the Inkscape project itself (that's how we track other cairo bugs which had been reported for Inkscape instead of cairo, so far).
Regards, V
El 18/10/13 05:54, su_v escribió:
For anyone using an unpatched stable cairo version the downscaling bug is again 'open' (after r12599), and inkscape now has declared this not being its own bug (by relying/depending on a future uptream cairo version).
Personally, I would not have closed bug #804162 as 'Fix Committed' - I would have kept it as 'Triaged', and closed it as 'Invalid' once a newer stable cairo version is available on all major distros, and with all binary packages distributed by the Inkscape project itself (that's how we track other cairo bugs which had been reported for Inkscape instead of cairo, so far).
As a user who relies on bitmaps a lot (Inkscape is my main design application, all my professional work is done with it) I'd be very disappointed if a new version of inkscape is released with that bug (upsteam or not). If packagers unaware of this situation build inkscape for major distros (for instance debian and its derivatives) while the new version of cairo isn't released, it would be a catastrophe for anyone using bitmaps in their inkscape designs. It would mean a lot of users will have to pin their old versions of inkscape or revert, because the new version will be unusable.
For anyone using inkscape with bitmaps this is a really big deal.
So, even though I'm not a developer and I'm probably missing a thing or two about release cycles and packaging, I'd recommend to:
- Wait until the right version of cairo is released, and make it a hard dependency so nobody packages 0.49 against the wrong version of cairo, or - Include the right cairo lib (I know it's not a good idea, but it's far worse to realease with that bug).
It is already a bad thing that image viewers like Eye of Gnome switched to cairo with such a nasty bug (and they have been out for a couple of years making images look like crap), it would be terrible if a creative tool like inkscape suffers the same issue.
Please, consider this when the moment of releasing inkscape comes. In creative tools quality is one of the most important aspects, and this is a critical issue.
Gez.
Yes, your first idea is what I propose too. The "fix" in inkscape will be the imposition of a hard dependency on cairo >= 13.1 On 18 Oct 2013 16:23, "Guillermo Espertino (Gez)" <gespertino@...400...> wrote:
El 18/10/13 05:54, su_v escribió:
For anyone using an unpatched stable cairo version the downscaling bug is again 'open' (after r12599), and inkscape now has declared this not being its own bug (by relying/depending on a future uptream cairo
version).
Personally, I would not have closed bug #804162 as 'Fix Committed' - I would have kept it as 'Triaged', and closed it as 'Invalid' once a newer stable cairo version is available on all major distros, and with all binary packages distributed by the Inkscape project itself (that's how we track other cairo bugs which had been reported for Inkscape instead of cairo, so far).
As a user who relies on bitmaps a lot (Inkscape is my main design application, all my professional work is done with it) I'd be very disappointed if a new version of inkscape is released with that bug (upsteam or not). If packagers unaware of this situation build inkscape for major distros (for instance debian and its derivatives) while the new version of cairo isn't released, it would be a catastrophe for anyone using bitmaps in their inkscape designs. It would mean a lot of users will have to pin their old versions of inkscape or revert, because the new version will be unusable.
For anyone using inkscape with bitmaps this is a really big deal.
So, even though I'm not a developer and I'm probably missing a thing or two about release cycles and packaging, I'd recommend to:
- Wait until the right version of cairo is released, and make it a hard
dependency so nobody packages 0.49 against the wrong version of cairo, or
- Include the right cairo lib (I know it's not a good idea, but it's far
worse to realease with that bug).
It is already a bad thing that image viewers like Eye of Gnome switched to cairo with such a nasty bug (and they have been out for a couple of years making images look like crap), it would be terrible if a creative tool like inkscape suffers the same issue.
Please, consider this when the moment of releasing inkscape comes. In creative tools quality is one of the most important aspects, and this is a critical issue.
Gez.
October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clk... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (4)
-
Alex Valavanis
-
Guillermo Espertino (Gez)
-
Martin Owens
-
su_v