Re: [Inkscape-devel] Please clean up console output
-----Original Message----- From: bulia byak [mailto:buliabyak@...400...] Sent: donderdag 28 september 2006 4:23
- Three "(inkscape:12772): GLib-GObject-CRITICAL **:
g_object_set_qdata_full: assertion `quark > 0' failed" warnings when I run Inkscape with a query, for example "inkscape -W file.svg".
Two of the errors were indeed spawned by paramnotebook.cpp. I fixed the bug (something with tooltips). After quite a search: the third error is not caused by my code but by event-log.cpp. Newing SPDocumentPrivate() causes the error => Member 'Inkscape::EventLog event_log;' causes the error => and finally "_event_list_store ( Gtk::TreeStore::create(_columns) )" is the cause of the error. The code should be changed to create the TreeStore only if there is a UI which can actually call Undo/Redo. Because I am not familiar with the EventLog (mental proposed a better name: 'HistoryLog'), I hope the author can look into this. I tried to correct it but it started becoming a nasty hack; I gave up for now.
Side note: we should make it clear to windows developers to enable the console. I vote for enabling it standard in the SVN's makefiles, and disable it for the pre-compiled distributions. I think people who are keen enough to compile their own Inkscape can also cope with a console screen. This should prevent some of the errors being missed. However, since I never use inkscape from the commandline, I still would have missed some of the errors caused by my code...
Now back to work on the axonometric grid :-) - Johan
On Sun, Oct 01, 2006 at 04:03:59AM +0200, Johan Engelen wrote:
- Three "(inkscape:12772): GLib-GObject-CRITICAL **:
g_object_set_qdata_full: assertion `quark > 0' failed" warnings when I run Inkscape with a query, for example "inkscape -W file.svg".
[...]
After quite a search: the third error is not caused by my code but by event-log.cpp. Newing SPDocumentPrivate() causes the error => Member 'Inkscape::EventLog event_log;' causes the error => and finally "_event_list_store ( Gtk::TreeStore::create(_columns) )" is the cause of the error. The code should be changed to create the TreeStore only if there is a UI which can actually call Undo/Redo.
Good catch, I wasn't aware of this. Should be fixed in trunk now.
Because I am not familiar with the EventLog (mental proposed a better name: 'HistoryLog' [...]
I thought "EventLog" made sense since it stores Inkscape::Events, but "HistoryLog" might be clearer. I can rename it...
-- Gustav
On Sun, 2006-10-01 at 22:38 +0200, Gustav Broberg wrote:
Because I am not familiar with the EventLog (mental proposed a better name: 'HistoryLog' [...]
I thought "EventLog" made sense since it stores Inkscape::Events, but "HistoryLog" might be clearer. I can rename it...
How about calling it UndoHistory ?
-mental
participants (3)
-
Gustav Broberg
-
Johan Engelen
-
MenTaLguY