Hi all, Currently, these tests fail:
./svg/svg-affine-test.h:179: Error: Test failed: matrix(1,2,3,4,5,6,) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: matrix(1,2,3,4,5e6-3) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: matrix(1,2,3,4,5e6.3) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: translate(1,) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: translate(1,6,) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm)
The current code is too permissive, and (perhaps unintentionally) tries to do its best in making sense of the matrix string. What do you guys think? Should we allow "matrix(1,2,3,4,5,6,)" to become "matrix(1,2,3,4,5,6)" ? (similar for the other failures)
thanks, Johan
In general I would recommend against being more permissive than the standard allows, otherwise you easily run into interoperability issues.
On 02/10/2015 10:03 PM, Johan Engelen wrote:
Hi all, Currently, these tests fail:
./svg/svg-affine-test.h:179: Error: Test failed: matrix(1,2,3,4,5,6,) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: matrix(1,2,3,4,5e6-3) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: matrix(1,2,3,4,5e6.3) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: translate(1,) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: translate(1,6,) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm)
The current code is too permissive, and (perhaps unintentionally) tries to do its best in making sense of the matrix string. What do you guys think? Should we allow "matrix(1,2,3,4,5,6,)" to become "matrix(1,2,3,4,5,6)" ? (similar for the other failures)
thanks, Johan
Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Wed, 2015-02-11 at 10:00 +0100, Jasper van de Gronde wrote:
In general I would recommend against being more permissive than the standard allows, otherwise you easily run into interoperability issues.
I agree. As an authoring tool we should write out only standards compliant SVG. Renderers (browsers) can be more relaxed in what they accept.
Tav
On 02/10/2015 10:03 PM, Johan Engelen wrote:
Hi all, Currently, these tests fail:
./svg/svg-affine-test.h:179: Error: Test failed: matrix(1,2,3,4,5,6,) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: matrix(1,2,3,4,5e6-3) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: matrix(1,2,3,4,5e6.3) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: translate(1,) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm) ./svg/svg-affine-test.h:179: Error: Test failed: translate(1,6,) ./svg/svg-affine-test.h:179: Error: Assertion failed: !sp_svg_transform_read(read_fail_tests[i], &cm)
The current code is too permissive, and (perhaps unintentionally) tries to do its best in making sense of the matrix string. What do you guys think? Should we allow "matrix(1,2,3,4,5,6,)" to become "matrix(1,2,3,4,5,6)" ? (similar for the other failures)
thanks, Johan
Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (3)
-
Jasper van de Gronde -
Johan Engelen -
Tavmjong Bah