Can we remove acinclude.m4 ?
inkscape seems to compile fine if I do
rm -rf acinclude.m4 `cat .cvsignore` builddir ./autogen.sh && mkdir builddir && cd builddir && ../configure blah && make -sj4
A simplistic check suggests that none of the macros it defines are used by configure.in (with the arguable exception of AC_PROG_LIBTOOL, which is defined by /usr/share/aclocal/libtool.m4 anyway).
(This check ignores the possibility of configure.in invoking a macro in /usr/share/aclocal that invokes a macro whose definition is overridden by something in acinclude.m4, but in these cases it's questionable that we would want the acinclude.m4 version anyway if we never update acinclude.m4.)
Our acinclude.m4 causes a number of warnings with automake-1.8.
Has anyone any objection to removing acinclude.m4 from CVS ?
pjrm.
On Mon, 2004-04-26 at 05:58, Peter Moulder wrote:
Has anyone any objection to removing acinclude.m4 from CVS ?
I think it should be okay to remove so long as it contains no custom feature test macros.
The remaining macros should be pulled into aclocal.m4 at autogen time.
-mental
On Mon, 2004-04-26 at 21:09, MenTaLguY wrote:
On Mon, 2004-04-26 at 05:58, Peter Moulder wrote:
Has anyone any objection to removing acinclude.m4 from CVS ?
I think it should be okay to remove so long as it contains no custom feature test macros.
The remaining macros should be pulled into aclocal.m4 at autogen time.
Hrm, I didn't phrase that too well.
autogen.sh, by way of aclocal, will populate aclocal.m4 with standard macros. acinclude.m4 should really only be used for entirely custom macros.
-mental
participants (2)
-
MenTaLguY -
Peter Moulder