Convolve Matrix filter implemented

I have implemented the convolve matrix filter
The patch and the 2 new files have been posted to the patch tracker: /src/display/nr-filter-convolve-matrix.cpp /src/display/nr-filter-convolve-matrix.h
See http://sourceforge.net/tracker/index.php?func=detail&aid=1757228&gro...
The implementation isn't complete yet, but the basic is already working. For example, you can see that now inkscape renders correctly the 4th test in the SVG1.1 test suite. A screenshot is available at
http://bighead.poli.usp.br/~juca/code/inkscape/inkscape-SVG1.1-testsuite-con...
I am wondering what is causing the spurious horizontal or vertical lines when we scroll the screen. Any clue on that?
Felipe "Juca" Sanches

Thu, 19 Jul 2007 22:49:39 -0300 "Felipe Sanches" <felipe.sanches@...400...> kirjoitti:
I have implemented the convolve matrix filter
The patch and the 2 new files have been posted to the patch tracker: /src/display/nr-filter-convolve-matrix.cpp /src/display/nr-filter-convolve-matrix.h
See http://sourceforge.net/tracker/index.php?func=detail&aid=1757228&gro...
Wow, great. I haven't tested that yet, but looking at the code, it seems fine.
I am wondering what is causing the spurious horizontal or vertical lines when we scroll the screen. Any clue on that?
Since feConvolveMatrix uses other pixels than the target pixel itself, you need to implement area_enlarge in the renderer.
That function, given the to-be-rendered area and object space - screen coordinates transformation matrix, should modify the area to contain all pixels that are required to correctly render the original area.
See display/nr-filter-gaussian.cpp for an example.

On 7/20/07, Niko Kiirala <niko@...1267...> wrote:
Wow, great. I haven't tested that yet, but looking at the code, it seems fine.
So, Niko, will you please take care of committing this when it's ready?
Thanks a lot Felipe!

Fri, 20 Jul 2007 11:13:53 -0400 "bulia byak" <buliabyak@...400...> kirjoitti:
So, Niko, will you please take care of committing this when it's ready?
Thanks a lot Felipe!
Yes, this is now in Inkscape SVN, with a minor modification.
Also, in SVN is now patch for lighting effects, i.e. feDiffuseLighting and feSpecularLighting. The thanks for these goes to Jean-René Reinhard.
Offtopic: it kind a bugs me that my mails are sponsored by Microsoft...
participants (3)
-
bulia byak
-
Felipe Sanches
-
Niko Kiirala