Re: [Inkscape-devel] removal of nr_arena_item_new()
I removed nr_arena_item_new() today and replaced it with calls to NRArenaWhatever::clear() static members.
Now opening any file with text crashes with multiple asserts:
File display/nr-arena-glyphs.cpp line 761 (?): Assertion NR_IS_ARENA_GLYPHS_GROUP (gg) failed File libnr/nr-object.cpp line 55 (?): Assertion nr_type_is_a (((NRObject *) ip)->klass->type, tc) failed
Mental, please do not commit changes without doing at least basic "runs and loads" type tests. One thing which would be very easy for you to do is to collect a number of various files (including tutorials, keys.svg, etc) in a directory and, when you're about to commit, run "inkscape *" in that directory to make sure it loads them OK.
_________________________________________________________________ MSN Premium helps eliminate e-mail viruses. Get 2 months FREE* http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI...
bulia byak wrote:
I removed nr_arena_item_new() today and replaced it with calls to NRArenaWhatever::clear() static members.
Now opening any file with text crashes with multiple asserts:
File display/nr-arena-glyphs.cpp line 761 (?): Assertion NR_IS_ARENA_GLYPHS_GROUP (gg) failed File libnr/nr-object.cpp line 55 (?): Assertion nr_type_is_a (((NRObject *) ip)->klass->type, tc) failed
Mental, please do not commit changes without doing at least basic "runs and loads" type tests. One thing which would be very easy for you to do is to collect a number of various files (including tutorials, keys.svg, etc) in a directory and, when you're about to commit, run "inkscape *" in that directory to make sure it loads them OK.
Even better would be for there to be a set of such files in CVS, tested with make check (one could run inkscape -z and compare the output to known good examples).
njh
On Tue, 2004-05-04 at 16:46, bulia byak wrote:
I removed nr_arena_item_new() today and replaced it with calls to NRArenaWhatever::clear() static members.
Now opening any file with text crashes with multiple asserts:
File display/nr-arena-glyphs.cpp line 761 (?): Assertion NR_IS_ARENA_GLYPHS_GROUP (gg) failed File libnr/nr-object.cpp line 55 (?): Assertion nr_type_is_a (((NRObject *) ip)->klass->type, tc) failed
Mental, please do not commit changes without doing at least basic "runs and loads" type tests. One thing which would be very easy for you to do is to collect a number of various files (including tutorials, keys.svg, etc) in a directory and, when you're about to commit, run "inkscape *" in that directory to make sure it loads them OK.
Ouch. I have been using Inkscape for design work lately, so I wouldn't have missed that one. I think I forgot to do the final 'make' before testing and comitting.
But, yes, I'll add a quick runthrough of the tutorial to my pre-commit routine.
At least it was a pretty simple problem to fix in this case -- I had written NR_TYPE_ARENA_GLYPHS instead of NR_TYPE_ARENA_GLYPHS_GROUP in NRArenaGlyphsGroup::create().
Fix comitted.
-mental
participants (3)
-
bulia byak -
MenTaLguY -
Nathan Hurst