I don't know what the standard way to submit patches is, but I've attached a patch that implements loading, saving, and computing of the clip-rule property.
I'm playing with getting it to work in the cairo renderer. It's a bit of a pain for two reasons. First, the existing fill-rule implementation for clip paths is not just incorrect (fill-rule shouldn't affect clip paths) but is also very buggy. Second, I don't know how to ask cairo to generate a clipping region that is the union of two paths unless both paths use the nonzero rule. That being said, I have a gross hack that at least gets multiple nonzero paths or a single evenodd path right. I'll make it less ugly before I mail it in.
I understand approximately nothing about the nr renderer (or whatever the code that I assume renders the editing view is), so I've made no progress on honoring clip-rule in the edit view.
What should I do from here?
(Note: I'm not really inclined to try to invent a sensible UI for clip-rule. I mainly want to be able to edit my own figures that need clip-rule=evenodd.
--Andy
Hey Andrew,
Sorry about the delay in getting back to you. The standard way to submit patches is to attach a patch to a relevant bug report. If no such bug report exists, please file a bug and attach the patch.
When you speak of getting it to work with the cairo renderer are you speaking of exporting or the actual gsoc-cairo branch from launchpad? Basically, if I were you, I would get it working against the cairo branch as opposed to trunk as the nr renderer will end up going away (hopefully sometime relatively soon).
Please let me or the list know what further Qs you have.
Cheers, Josh
On Fri, Mar 4, 2011 at 11:04 AM, Andrew Lutomirski <luto@...1007...> wrote:
I don't know what the standard way to submit patches is, but I've attached a patch that implements loading, saving, and computing of the clip-rule property.
I'm playing with getting it to work in the cairo renderer. It's a bit of a pain for two reasons. First, the existing fill-rule implementation for clip paths is not just incorrect (fill-rule shouldn't affect clip paths) but is also very buggy. Second, I don't know how to ask cairo to generate a clipping region that is the union of two paths unless both paths use the nonzero rule. That being said, I have a gross hack that at least gets multiple nonzero paths or a single evenodd path right. I'll make it less ugly before I mail it in.
I understand approximately nothing about the nr renderer (or whatever the code that I assume renders the editing view is), so I've made no progress on honoring clip-rule in the edit view.
What should I do from here?
(Note: I'm not really inclined to try to invent a sensible UI for clip-rule. I mainly want to be able to edit my own figures that need clip-rule=evenodd.
--Andy
What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (2)
-
Andrew Lutomirski -
Josh Andler