Hi all, The Windows build is broken. Possibly after rev. 13225?
Error output:
compile src/ui/dialog/pixelartdialog.cpp Make error line 304: problem compiling: src/ui/dialog/pixelartdialog.cpp: In member function 'void Inkscape::UI::Dialog::PixelArtDialogImpl::vectorize()': src/ui/dialog/pixelartdialog.cpp:414:65: error: no matching function for call to 'Glib::Thread::create(sigc::bound_mem_functor0<void, Inkscape::UI::Dialog::PixelArtDialogImpl>)' src/ui/dialog/pixelartdialog.cpp:414:65: note: candidates are: c:\devlibs/include/glibmm-2.4/glibmm/thread.h:228:18: note: static Glib::Thread* Glib::Thread::create(const sigc::slot<void>&, bool) c:\devlibs/include/glibmm-2.4/glibmm/thread.h:228:18: note: candidate expects 2 arguments, 1 provided c:\devlibs/include/glibmm-2.4/glibmm/thread.h:273:18: note: static Glib::Thread* Glib::Thread::create(const sigc::slot<void>&, long unsigned int, bool, bool, Glib::ThreadPriority) c:\devlibs/include/glibmm-2.4/glibmm/thread.h:273:18: note: candidate expects 5 arguments, 1 provided
Thanks for the fix, Johan
Em Dom, 2014-03-30 às 22:04 +0200, Johan Engelen escreveu:
The Windows build is broken. Possibly after rev. 13225?
Thanks for the report. It seems it was related to code that I wrote.
Error output:
compile src/ui/dialog/pixelartdialog.cpp Make error line 304: problem compiling: src/ui/dialog/pixelartdialog.cpp: In member function 'void Inkscape::UI::Dialog::PixelArtDialogImpl::vectorize()': src/ui/dialog/pixelartdialog.cpp:414:65: error: no matching function for call to 'Glib::Thread::create(sigc::bound_mem_functor0<void, Inkscape::UI::Dialog::PixelArtDialogImpl>)' src/ui/dialog/pixelartdialog.cpp:414:65: note: candidates are: c:\devlibs/include/glibmm-2.4/glibmm/thread.h:228:18: note: static Glib::Thread* Glib::Thread::create(const sigc::slot<void>&, bool) c:\devlibs/include/glibmm-2.4/glibmm/thread.h:228:18: note: candidate expects 2 arguments, 1 provided
Official Glibmm documentation informs that only one argument is required. The other has a default value, that was omitted in Inkscape code and should be inferred/defaulted: https://developer.gnome.org/glibmm/unstable/classGlib_1_1Thread.html#a2775df...
I believe it's a glibmm bug, not Inkscape. Maybe it's related to the Glibmm installation, not the code.
Anyway, it's easy to workaround this issue and I'm attaching a patch. Can you test it? I won't be able to access a Windows machine so soon.
Thanks for the patch, Windows build succeeds again. I've committed the fix. I very much like the little comment you put in front of the 2nd argument (many devs won't know that function's argument list).
Cheers, Johan
On 31-3-2014 6:48, Vinícius dos Santos Oliveira wrote:
Em Dom, 2014-03-30 às 22:04 +0200, Johan Engelen escreveu:
The Windows build is broken. Possibly after rev. 13225?
Thanks for the report. It seems it was related to code that I wrote.
Error output:
compile src/ui/dialog/pixelartdialog.cpp Make error line 304: problem compiling: src/ui/dialog/pixelartdialog.cpp: In member function 'void Inkscape::UI::Dialog::PixelArtDialogImpl::vectorize()': src/ui/dialog/pixelartdialog.cpp:414:65: error: no matching function for call to 'Glib::Thread::create(sigc::bound_mem_functor0<void, Inkscape::UI::Dialog::PixelArtDialogImpl>)' src/ui/dialog/pixelartdialog.cpp:414:65: note: candidates are: c:\devlibs/include/glibmm-2.4/glibmm/thread.h:228:18: note: static Glib::Thread* Glib::Thread::create(const sigc::slot<void>&, bool) c:\devlibs/include/glibmm-2.4/glibmm/thread.h:228:18: note: candidate expects 2 arguments, 1 provided
Official Glibmm documentation informs that only one argument is required. The other has a default value, that was omitted in Inkscape code and should be inferred/defaulted: https://developer.gnome.org/glibmm/unstable/classGlib_1_1Thread.html#a2775df...
I believe it's a glibmm bug, not Inkscape. Maybe it's related to the Glibmm installation, not the code.
Anyway, it's easy to workaround this issue and I'm attaching a patch. Can you test it? I won't be able to access a Windows machine so soon.
-- Vinícius dos Santos Oliveira https://about.me/vinipsmaker
Em Seg, 2014-03-31 às 22:55 +0200, Johan Engelen escreveu:
I very much like the little comment you put in front of the 2nd argument (many devs won't know that function's argument list).
And if you let me say, I wanna add that I very much like your C ++ification work to Inkscape code base.
participants (2)
-
Johan Engelen -
Vinícius dos Santos Oliveira