Please don't reformat code and fix things in same commit!
Hi all, Please don't fix a bug or change code in a commit where you reformat a lot of the code aswell.
As an example, it is extremely hard to see what part of this commit actually changed code: http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12548
Thanks! Johan
On Sep 20, 2013, at 1:22 PM, Johan Engelen wrote:
Hi all, Please don't fix a bug or change code in a commit where you reformat a lot of the code aswell.
As an example, it is extremely hard to see what part of this commit actually changed code: http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12548
Thanks! Johan
Yes. Johan makes a very good point here.
If you have code that needs whitespace cleanup and/or reformatting it is best to do those in a separate commit. Among other things it will keep your meaningful changes easier to spot. Additionally it can help with merging between branches.
participants (2)
-
Johan Engelen
-
Jon Cruz