Hi, I downloaded Inkscape and noticed that it didn't have any way to put arrowheads on strokes; so I added that feature. I have had no contact with the Inkscape group previously, how do I offer the feature for use in the code? I've added to the stroke-style dialog two additional cap types (solid triangle arrow and line-drawn arrow like "->"), and also a head-size numeric selector kind of similar to the existing stroke width selector and a radio button for selecting whether the arrowhead should be on both, left, right, or neither end of the stroke (non-arrowhead ends get butt_straight rather than the specified cap style.) I believe the interface look-and-feel and also the code style of the stuff I've added are basically indistinguishable from what's already there. Some caveats: I haven't delved into libart, so if you set Inkscape to use the libart stroke calls instead of the livarot calls, then it will basically ignore my additions. Also, there seemed to be some disabled WITH_MARKER_GUI code that maybe was intended to do something similar, but didn't seem to do anything when enabled. My additions ignore the existing disabled marker stuff. - jason
Jason Modisette http://snork.home.texas.net/jason
On Sun, 7 Mar 2004 jasonmod@...262... wrote:
Hi, I downloaded Inkscape and noticed that it didn't have any way to put arrowheads on strokes; so I added that feature. I have had no contact with the Inkscape group previously, how do I offer the feature for use in the code?
Post a patch to the patch tracker, or send it my way if you'd like it reviewed first.
We generally provide direct CVS access after you've made two contributions, so longer term if you want to work on the codebase, you'll have that option.
I've added to the stroke-style dialog two additional cap types (solid triangle arrow and line-drawn arrow like "->"), and also a head-size numeric selector kind of similar to the existing stroke width selector and a radio button for selecting whether the arrowhead should be on both, left, right, or neither end of the stroke (non-arrowhead ends get butt_straight rather than the specified cap style.) I believe the interface look-and-feel and also the code style of the stuff I've added are basically indistinguishable from what's already there.
Cool! Were you able to get the end markers working correctly? I'd run into a bug where the start markers would auto-orient correctly but the end markers didn't.
Some caveats: I haven't delved into libart, so if you set Inkscape to use the libart stroke calls instead of the livarot calls, then it will basically ignore my additions. Also, there seemed to be some disabled WITH_MARKER_GUI code that maybe was intended to do something similar, but didn't seem to do anything when enabled. My additions ignore the existing disabled marker stuff.
- jason
Yeah that's my code. I'd gotten some of the underlying rendering calls hooked up, made the icons, etc. but ran out of time prior to the 0.37 release to figure out how to hook it to the interface. This was also pre-livarot so probably your code is more relevant. I look forward to seeing it!
Bryce
participants (2)
-
unknown@example.com
-
Bryce Harrington