Since recently, adjusting a blur of an object in Fill & Stroke not only adds Gaussian blur but also a feBlend. Do you have any idea of who added this and for what reason? I think this is a bug and must be fixed.
On Tue, Feb 10, 2009 at 2:31 PM, bulia byak <buliabyak@...400...> wrote:
Since recently, adjusting a blur of an object in Fill & Stroke not only adds Gaussian blur but also a feBlend. Do you have any idea of who added this and for what reason? I think this is a bug and must be fixed.
OK, I figured this out and fixed. It was a combination of two bugs, one old and one recent.
- (old) the SimpleFilterModifier returned its blend mode even if it was hidden. Usually it was at "normal" and so this didn't do any harm, i.e. feBlend was not inserted, but recently -
- (new) Johan added sorting of ComboEnum which utterly broke the blend mode selector - its input didn't match its output, and it started to return "darken" instead of "normal" and a wrong feBlend was added to account for that, whenever you adjust blur.
Once again: Please test carefully your changes before committing! In particular, Johan, could you please review all other users of ComboEnum to make sure they are OK with sorting (I added an optional constructor parameter to suppress it)?
Thanks for your fix bulia.
-----Original Message----- From: bulia byak [mailto:buliabyak@...400...] Sent: Wednesday, February 11, 2009 00:28 To: Inkscape Devel List; Engelen, J.B.C. (Johan) Subject: Re: Blur slider inserts feBlend???
On Tue, Feb 10, 2009 at 2:31 PM, bulia byak <buliabyak@...400...> wrote:
Since recently, adjusting a blur of an object in Fill & Stroke not only adds Gaussian blur but also a feBlend. Do you have any idea of who added this and for what reason? I think this is a bug
and must be
fixed.
OK, I figured this out and fixed. It was a combination of two bugs, one old and one recent.
- (old) the SimpleFilterModifier returned its blend mode even
if it was hidden. Usually it was at "normal" and so this didn't do any harm, i.e. feBlend was not inserted, but recently -
- (new) Johan added sorting of ComboEnum which utterly broke
the blend mode selector - its input didn't match its output, and it started to return "darken" instead of "normal" and a wrong feBlend was added to account for that, whenever you adjust blur.
Once again: Please test carefully your changes before committing! In particular, Johan, could you please review all other users of ComboEnum to make sure they are OK with sorting (I added an optional constructor parameter to suppress it)?
-- bulia byak Inkscape. Draw Freely. http://www.inkscape.org
participants (2)
-
unknown＠example.com -
bulia byak