Hi All,
The code in src/ui/widget/icon-widget.[cpp,h] doesn't appear to be used anywhere. I searched for header inclusion, and use of the IconWidget class, and I don't see anything in trunk or 0.48.x.
In fact, the C++ source looks rather like a placeholder file that was never completed. Can anyone shed some light on this?
The file is contributing to the GTK+ 3 build failure, so if it's not used and not usable, am I OK to delete it?
Thanks,
AV
Hey Alex,
It appears to me that it was part of the c++ification effort from years back, and just not completed. At this point I would say it's safe to delete as it will still exist in the revision history.
Cheers, Josh
On Thu, May 31, 2012 at 2:19 PM, Alex Valavanis <valavanisalex@...400...> wrote:
Hi All,
The code in src/ui/widget/icon-widget.[cpp,h] doesn't appear to be used anywhere. I searched for header inclusion, and use of the IconWidget class, and I don't see anything in trunk or 0.48.x.
In fact, the C++ source looks rather like a placeholder file that was never completed. Can anyone shed some light on this?
The file is contributing to the GTK+ 3 build failure, so if it's not used and not usable, am I OK to delete it?
Thanks,
AV
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
OK, thanks. I'll go ahead and we can revert if necessary.
AV
On 31 May 2012 23:01, Josh Andler <scislac@...400...> wrote:
Hey Alex,
It appears to me that it was part of the c++ification effort from years back, and just not completed. At this point I would say it's safe to delete as it will still exist in the revision history.
Cheers, Josh
On Thu, May 31, 2012 at 2:19 PM, Alex Valavanis <valavanisalex@...400...> wrote:
Hi All,
The code in src/ui/widget/icon-widget.[cpp,h] doesn't appear to be used anywhere. I searched for header inclusion, and use of the IconWidget class, and I don't see anything in trunk or 0.48.x.
In fact, the C++ source looks rather like a placeholder file that was never completed. Can anyone shed some light on this?
The file is contributing to the GTK+ 3 build failure, so if it's not used and not usable, am I OK to delete it?
Thanks,
AV
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (2)
-
Alex Valavanis
-
Josh Andler